Change in vdsm[master]: logging: remove log messages which give little or no value
automat...@ovirt.org has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 2: * Update tracker::#1239062::OK * Set MODIFIED::bug 1239062#1239062IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Dan Kenigsberg has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Dan Kenigsberg has submitted this change and it was merged. Change subject: logging: remove log messages which give little or no value .. logging: remove log messages which give little or no value Some of the messages logged during jsonrpc request processing give no or little value when diagnosing the issues but are logged quite often. This patch removes those messages. Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1239062 Reviewed-on: https://gerrit.ovirt.org/43720 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dima Kuznetsov dkuzn...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompreactor.py 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Oved Ourfali has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: can we merge this one? -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Dima Kuznetsov has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Yaniv Bronhaim has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Piotr Kliczewski has uploaded a new change for review. Change subject: logging: remove log messages which give little or no value .. logging: remove log messages which give little or no value Some of the messages logged during jsonrpc request processing give no or little value when diagnosing the issues but are logged quite often. This patch removes those messages. Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1239062 --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompreactor.py 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/43720/1 diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py index 68af242..778b9c0 100644 --- a/lib/yajsonrpc/__init__.py +++ b/lib/yajsonrpc/__init__.py @@ -530,7 +530,6 @@ @traceback(on=log.name) def serve_requests(self): while True: -self.log.debug(Waiting for request) obj = self._workQueue.get() if obj is None: break diff --git a/lib/yajsonrpc/stompreactor.py b/lib/yajsonrpc/stompreactor.py index e3b71bf..3ed451d 100644 --- a/lib/yajsonrpc/stompreactor.py +++ b/lib/yajsonrpc/stompreactor.py @@ -232,7 +232,6 @@ self._req_dest[request.get(id)] = req_dest def handle_frame(self, dispatcher, frame): -self.log.debug(Handling message %s, frame) try: self._commands[frame.command](dispatcher, frame) except KeyError: -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
Piotr Kliczewski has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: Verified+1 Verified on ovirt-3.5 and by running local build. -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logging: remove log messages which give little or no value
automat...@ovirt.org has posted comments on this change. Change subject: logging: remove log messages which give little or no value .. Patch Set 1: * Update tracker::#1239062::OK * Check Bug-Url::OK * Check Public Bug::#1239062::OK, public bug * Check Product::#1239062::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
