Change in vdsm[master]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 4: * update_tracker: OK * Set MODIFIED::bug 1358348#1358348::IGNORE, skipping for branch 'master' -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
Adam Litke has submitted this change and it was merged. Change subject: lvm: Improve logging lv activation logging .. lvm: Improve logging lv activation logging Log vg name and lv names when we activate, refresh or deactivate lvs. All are important state changes that should be logged in INFO level. The actual lvm commands are logged in DEBUG level, and may not be available when we change the default log level to INFO. Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Bug-Url: https://bugzilla.redhat.com/1358348 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/61286 Reviewed-by: Allon Mureinik Reviewed-by: Adam Litke Continuous-Integration: Jenkins CI --- M vdsm/storage/lvm.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 3: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358348::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
Adam Litke has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
Nir Soffer has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: Allon, DEBUG log means we will never see the message since we are moving to log INFO by default. -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
Allon Mureinik has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: Code-Review+1 Definitely +1 on the concept. I'm on the fence on whether this should be log.info or log.debug, but info is definitely better than not logging at att. -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
Nir Soffer has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: Verified+1 The new logs reveals lot of unneeded activations, resulting in refreshes: Each 5 minutes we create new domain object for each domain, activating the domain special lvs: Thread-346::INFO::2016-07-24 23:05:47,203::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=65059e74-7577-4356-8ce1-89e9634d986b lvs=['leases'] Thread-31::INFO::2016-07-24 23:10:22,373::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=65059e74-7577-4356-8ce1-89e9634d986b lvs=['metadata'] Thread-31::INFO::2016-07-24 23:10:25,216::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=65059e74-7577-4356-8ce1-89e9634d986b lvs=['ids'] Thread-31::INFO::2016-07-24 23:10:25,364::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=65059e74-7577-4356-8ce1-89e9634d986b lvs=['leases'] Thread-31::INFO::2016-07-24 23:10:25,573::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=65059e74-7577-4356-8ce1-89e9634d986b lvs=['metadata', 'leases', 'ids', 'inbox', 'outbox', 'master'] Each time we start a vm, we activate the leases lv twice (probably once per each volume): Thread-511::INFO::2016-07-24 23:15:49,613::lvm::1207::Storage.LVM::(activateLVs) Activating lvs: vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['35be1f52-5b28-4c90-957a-710dbbb8f13f', 'd49919b4-30fc-440f-9b21-3367ddfdf396'] Thread-511::INFO::2016-07-24 23:15:51,207::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['leases'] Thread-511::INFO::2016-07-24 23:15:52,039::lvm::1203::Storage.LVM::(activateLVs) Refreshing lvs: vg=5f35b5c0-17d7-4475-9125-e97f1cdb06f9 lvs=['leases'] -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358348::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/61286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
