Change in vdsm[master]: m2c: get more information about ssl connection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: m2c: get more information about ssl connection
..


m2c: get more information about ssl connection

Sometimes during runtime we see in the logs: "M2Crypto.SSL.SSLError:
unexpected eof". In order to understand the state of the connection we
want temporarily print ssl session information.

This patch provides a configuration flag to enable/disable logging.


Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Signed-off-by: pkliczewski 
Reviewed-on: https://gerrit.ovirt.org/57016
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/config.py.in
M lib/vdsm/m2cutils.py
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> It doesn't work like that. I ask them to set engine log level to debug from
OK
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> we can ask qe to enable this option for some time. Wouldn't this be good en
It doesn't work like that. I ask them to set engine log level to debug from 
time to time and still I get logs with info level. I will push a patch to 
disable it by default so we do not forget. Is it OK with you?
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> My intention is to have it enabled for some time. I need it to diagnose whe
we can ask qe to enable this option for some time. Wouldn't this be good enough?
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> This should be disabled by default, otherwise we are spamming the journal. 
My intention is to have it enabled for some time. I need it to diagnose whether 
unexpected eof is something that I should worry about or not. I will disable it 
once I know that it is OK or I have fix for the issue.
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
This should be disabled by default, otherwise we are spamming the journal. When 
a user has a problem we can enable it for debugging.
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Verified+1

Verified by running local build.

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
> So instead of adding this and reverting, lets add a [debug] option to enabl
We could add the option to enable/disable it but it should be enable by 
default. At least for some time.
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
> In is logged to stderr and you can find in journal.
So instead of adding this and reverting, lets add a [debug] option to enable 
and disable it.
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
> Where would we get this with this patch? in vdsm log? stderr?
In is logged to stderr and you can find in journal.
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
> Here is sample log:
Where would we get this with this patch? in vdsm log? stderr?
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
> Can you show an example of the output in the log?
Here is sample log:

python[2139]: DIGEST-MD5 client step 2
python[2139]: DIGEST-MD5 parse_server_challenge()
python[2139]: DIGEST-MD5 ask_user_info()
python[2139]: DIGEST-MD5 client step 2
python[2139]: DIGEST-MD5 ask_user_info()
python[2139]: DIGEST-MD5 make_client_response()
python[2139]: DIGEST-MD5 client step 3
python[2139]: DIGEST-MD5 client mech dispose
python[2139]: DIGEST-MD5 common mech dispose
python[2158]: DIGEST-MD5 client step 2
python[2158]: DIGEST-MD5 parse_server_challenge()
python[2158]: DIGEST-MD5 ask_user_info()
python[2158]: DIGEST-MD5 client step 2
python[2158]: DIGEST-MD5 ask_user_info()
python[2158]: DIGEST-MD5 make_client_response()
python[2158]: DIGEST-MD5 client step 3
python[2158]: DIGEST-MD5 client mech dispose
python[2158]: DIGEST-MD5 common mech dispose
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
Can you show an example of the output in the log?
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1: Verified+1

Verified by installing vdsm and seeing tha debug messages are part of journal.

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: m2c: get more information about ssl connection
..

m2c: get more information about ssl connection

Sometimes during runtime we see in the logs: "M2Crypto.SSL.SSLError:
unexpected eof". In order to understand the state of the connection we
want temporarily print ssl session information.

This patch should be reverted when we know that the error is expected or
the issue was fixed.


Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Signed-off-by: pkliczewski 
---
M lib/vdsm/m2cutils.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/57016/1

diff --git a/lib/vdsm/m2cutils.py b/lib/vdsm/m2cutils.py
index fa0d2aa..20b0e2a 100644
--- a/lib/vdsm/m2cutils.py
+++ b/lib/vdsm/m2cutils.py
@@ -100,6 +100,7 @@
 def __init__(self, raw, certfile=None, keyfile=None, ca_certs=None,
  session_id="vdsm", protocol="sslv23"):
 self.context = SSL.Context(protocol)
+self.context.set_info_callback()
 self.context.set_session_id_ctx(session_id)
 
 if certfile and keyfile:
@@ -174,6 +175,7 @@
 
 def _initContext(self):
 self.context = context = SSL.Context(self.protocol)
+self.context.set_info_callback()
 context.set_session_id_ctx(self.session_id)
 
 self._loadCertChain()


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[automation]

gerrit-hooks has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches