Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-05-01 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-05-01 Thread nsoffer 
Nir Soffer has abandoned this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Abandoned

Replaced by https://gerrit.ovirt.org/56886

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-01-03 Thread nsoffer 
Nir Soffer has restored this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-01-02 Thread Jenkins CI RO 
Jenkins CI RO has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 3:

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-01-02 Thread Jenkins CI RO 
Jenkins CI RO has abandoned this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2016-01-02 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-05-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-05-06 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-05-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-03-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17081/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17255/ : FAILURE

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-03-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 2:

Build Started (2/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17255/

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-03-24 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-03-24 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 2:

Build Started (1/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17081/

-- 
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/38041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-02-23 Thread laravot 
Liron Aravot has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 1:

I've replied on your comment there- pending for your reply. Tou can rebase so 
that one will be merged on top of the other patch to ease the process - this 
patch is just refacor and unneded for the 3.5 branch, so it'll be appreciated.

-- 
To view, visit http://gerrit.ovirt.org/38041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-02-23 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 1:

I cannot rebase on http://gerrit.ovirt.org/37952 because it is not ready yet.

Please address my comments on that patch and I will rebase this one on top of 
it.

-- 
To view, visit http://gerrit.ovirt.org/38041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-02-23 Thread laravot 
Liron Aravot has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 1:

Please rebase your change on top of http://gerrit.ovirt.org/#/c/37952/ which 
was the trigger for this patch.
The change in http://gerrit.ovirt.org/#/c/37952/ is targeted for 3.5, as we 
don't want to take this one as well (more noise) it means that the provided 
patch will have to be re-written which means more work for nothing.
as this patch is just a refactor patch, please change the order.
thanks.

-- 
To view, visit http://gerrit.ovirt.org/38041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-02-22 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15937/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15136/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16107/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/913/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/38041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Clarify the semantics of MonitorThread.nextStatus

2015-02-22 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..

monitor: Clarify the semantics of MonitorThread.nextStatus

MonitorThread.nextStatus is a temporary value menaningful only during
MonitorThread._monitorDomain(). Keeping it as an instance variable
create confusion about its semantics.

This patch changes nextStatus to a temporary and pass it to the methods
accessing it.

Change-Id: Ife082fac7cedfd85a497a7a4fbfed1e7ff683551
Signed-off-by: Nir Soffer 
---
M vdsm/storage/monitor.py
1 file changed, 30 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/38041/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index eec68ff..b795b47 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -171,8 +171,7 @@
 self.hostId = hostId
 self.interval = interval
 self.firstChange = True
-self.nextStatus = Status()
-self.status = FrozenStatus(self.nextStatus)
+self.status = FrozenStatus(Status())
 self.isIsoDomain = None
 self.isoPrefix = None
 self.lastRefresh = time.time()
@@ -222,7 +221,7 @@
 self.stopEvent.wait(self.interval)
 
 def _monitorDomain(self):
-self.nextStatus = Status()
+nextStatus = Status()
 
 # Pick up changes in the domain, for example, domain upgrade.
 if self._shouldRefreshDomain():
@@ -244,36 +243,36 @@
 self._setIsoDomainInfo()
 
 self._performDomainSelftest()
-self._checkReadDelay()
-self._collectStatistics()
+self._checkReadDelay(nextStatus)
+self._collectStatistics(nextStatus)
 except Exception as e:
 self.log.exception("Error monitoring domain %s", self.sdUUID)
-self.nextStatus.error = e
+nextStatus.error = e
 
-self.nextStatus.checkTime = time.time()
-self.nextStatus.valid = (self.nextStatus.error is None)
+nextStatus.checkTime = time.time()
+nextStatus.valid = (nextStatus.error is None)
 
-if self._statusDidChange():
-self._notifyStatusChanges()
+if self._statusDidChange(nextStatus):
+self._notifyStatusChanges(nextStatus)
 self.firstChange = False
 
 if self._shouldAcquireHostId():
 self._acquireHostId()
 
-self.status = FrozenStatus(self.nextStatus)
+self.status = FrozenStatus(nextStatus)
 
 # Notifiying status changes
 
-def _statusDidChange(self):
-return self.firstChange or self.status.valid != self.nextStatus.valid
+def _statusDidChange(self, nextStatus):
+return self.firstChange or self.status.valid != nextStatus.valid
 
 @utils.cancelpoint
-def _notifyStatusChanges(self):
+def _notifyStatusChanges(self, nextStatus):
 self.log.info("Domain %s became %s", self.sdUUID,
-  "VALID" if self.nextStatus.valid else "INVALID")
+  "VALID" if nextStatus.valid else "INVALID")
 try:
 self.domainMonitor.onDomainStateChange.emit(
-self.sdUUID, self.nextStatus.valid)
+self.sdUUID, nextStatus.valid)
 except:
 self.log.exception("Error notifying state change for domain %s",
self.sdUUID)
@@ -313,37 +312,33 @@
 self.domain.selftest()
 
 @utils.cancelpoint
-def _checkReadDelay(self):
+def _checkReadDelay(self, nextStatus):
 # This may block for long time if the storage server is not accessible.
 # On overloaded machines we have seen this take up to 15 seconds.
-self.nextStatus.readDelay = self.domain.getReadDelay()
+nextStatus.readDelay = self.domain.getReadDelay()
 
-def _collectStatistics(self):
+def _collectStatistics(self, nextStatus):
 stats = self.domain.getStats()
-self.nextStatus.diskUtilization = (stats["disktotal"],
-   stats["diskfree"])
-
-self.nextStatus.vgMdUtilization = (stats["mdasize"],
-   stats["mdafree"])
-
-self.nextStatus.vgMdHasEnoughFreeSpace = stats["mdavalid"]
-self.nextStatus.vgMdFreeBelowThreashold = stats["mdathreshold"]
+nextStatus.diskUtilization = (stats["disktotal"], stats["diskfree"])
+nextStatus.vgMdUtilization = (stats["mdasize"], stats["mdafree"])
+nextStatus.vgMdHasEnoughFreeSpace = stats["mdavalid"]
+nextStatus.vgMdFreeBelowThreashold = stats["mdathreshold"]
 
 masterStats = self.domain.validateMaster()
-self.nextStatus.masterValid = masterStats['valid']
-self.nextStatus.masterMounted = masterStats['mount']
+nextStatus.masterValid = masterStats['valid']
+nextStatus.masterMo