Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 15: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 8: -Code-Review

We need tests

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-16 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-13 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-02 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitor: Eliminate nextStatus instance variable
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-02 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: monitor: Eliminate nextStatus instance variable
..

monitor: Eliminate nextStatus instance variable

Preparing for separate domain status, collected by the monitor thread
and path status, collected by the path checking thread.  Status is
created now in _monitorDomain and passed to collecting methods for
adding status.

Change-Id: Ida732918625c7eb0f12bbbcaeaaa84aea1c3af86
Signed-off-by: Nir Soffer 
---
M vdsm/storage/monitor.py
1 file changed, 33 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/56886/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 5f16a7e..f2f026d 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -201,8 +201,10 @@
 self.hostId = hostId
 self.interval = interval
 self.monitoringPath = None
-self.nextStatus = Status(actual=False)
-self.status = FrozenStatus(self.nextStatus)
+# For backward compatibility, we must present a fake status before
+# collecting the first sample. The fake status is marked as
+# actual=False so engine can handle it correctly.
+self.status = FrozenStatus(Status(actual=False))
 self.isIsoDomain = None
 self.isoPrefix = None
 self.lastRefresh = time.time()
@@ -254,7 +256,7 @@
 self.stopEvent.wait(self.interval)
 
 def _monitorDomain(self):
-self.nextStatus = Status()
+status = Status()
 
 # Pick up changes in the domain, for example, domain upgrade.
 if self._shouldRefreshDomain():
@@ -276,35 +278,35 @@
 self._setIsoDomainInfo()
 
 self._performDomainSelftest()
-self._checkReadDelay()
-self._collectStatistics()
+self._checkReadDelay(status)
+self._collectStatistics(status)
 except Exception as e:
 log.exception("Error monitoring domain %s", self.sdUUID)
-self.nextStatus.error = e
+status.error = e
 
-self.nextStatus.checkTime = time.time()
+status.checkTime = time.time()
 
-if self._statusDidChange():
-self._notifyStatusChanges()
+if self._statusDidChange(status):
+self._notifyStatusChanges(status)
 
-if self._shouldAcquireHostId():
+if self._shouldAcquireHostId(status):
 self._acquireHostId()
 
-self.status = FrozenStatus(self.nextStatus)
+self.status = FrozenStatus(status)
 
 # Notifiying status changes
 
-def _statusDidChange(self):
+def _statusDidChange(self, status):
 return (not self.status.actual or
-self.status.valid != self.nextStatus.valid)
+self.status.valid != status.valid)
 
 @utils.cancelpoint
-def _notifyStatusChanges(self):
+def _notifyStatusChanges(self, status):
 log.info("Domain %s became %s", self.sdUUID,
- "VALID" if self.nextStatus.valid else "INVALID")
+ "VALID" if status.valid else "INVALID")
 try:
 self.domainMonitor.onDomainStateChange.emit(
-self.sdUUID, self.nextStatus.valid)
+self.sdUUID, status.valid)
 except:
 log.exception("Error notifying state change for domain %s",
   self.sdUUID)
@@ -346,38 +348,35 @@
 self.domain.selftest()
 
 @utils.cancelpoint
-def _checkReadDelay(self):
+def _checkReadDelay(self, status):
 # This may block for long time if the storage server is not accessible.
 # On overloaded machines we have seen this take up to 15 seconds.
 stats = misc.readspeed(self.monitoringPath, 4096)
-self.nextStatus.readDelay = stats['seconds']
+status.readDelay = stats['seconds']
 
-def _collectStatistics(self):
+def _collectStatistics(self, status):
 stats = self.domain.getStats()
-self.nextStatus.diskUtilization = (stats["disktotal"],
-   stats["diskfree"])
+status.diskUtilization = (stats["disktotal"], stats["diskfree"])
 
-self.nextStatus.vgMdUtilization = (stats["mdasize"],
-   stats["mdafree"])
-
-self.nextStatus.vgMdHasEnoughFreeSpace = stats["mdavalid"]
-self.nextStatus.vgMdFreeBelowThreashold = stats["mdathreshold"]
+status.vgMdUtilization = (stats["mdasize"], stats["mdafree"])
+status.vgMdHasEnoughFreeSpace = stats["mdavalid"]
+status.vgMdFreeBelowThreashold = stats["mdathreshold"]
 
 masterStats = self.domain.validateMaster()
-self.nextStatus.masterValid = masterStats['valid']
-self.nextStatus.masterMounted = masterStats['mount']
+status.masterValid = masterStats['valid']
+