Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 32:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 31:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 30: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 30:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 29:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 28:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 27:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 26:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 25: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 25:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 24:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 23:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 22:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 21:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 20: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 20:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 19:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-27 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 18:

(3 comments)

https://gerrit.ovirt.org/#/c/54849/18/lib/vdsm/storage/asyncevent.py
File lib/vdsm/storage/asyncevent.py:

Line 265: This method is not implemented by Python 3 BaseEventLoop. 
There is no
Line 266: way to integrate asyncore with asyncio in Python 3.
Line 267: """
Line 268: assert "map" not in kwargs, "map is set by the event loop"
Line 269: return dispatcher_class(*args, map=self._channels, **kwargs)
I don't really like this solution, but the other option was to expose 
self._channels to callers, which seems even uglier. However, this is how 
asyuncore works, so maybe it is better solution, keep ugly stuff visible 
instead of hiding them in strange ways.
Line 270: 
Line 271: # Testing
Line 272: 
Line 273: def is_running(self):


Line 338: self._callback = _CANCELLED
Line 339: self._args = None
Line 340: 
Line 341: @property
Line 342: def _cancelled(self):
> this is private because it was so in python3, right?
Yes, I kept the same api, so when we move to python 3, we will not have code 
trying to access non existing api.

There is only one non-standard function here which is create_dispatcher, and 
I'm thinking about removing it.
Line 343: return self._callback is _CANCELLED
Line 344: 
Line 345: def _run(self):
Line 346: try:


Line 412: 
Line 413: The read end of the pipe is watched by the event loop, while 
other threads
Line 414: may wakeup the event loop by writing a byte to the write end.
Line 415: 
Line 416: Based on twisted.internet.posixbase._UnixWaker.
> question: did you considered eventfd? If it was discarded, could you provid
I don't like to depend on ctypes based code, and I'm not sure that the 
implementation is correct - it is very hard to review ctypes based code - much 
easier to review real c extension.

Eventfd will save us one file descriptor, and should have less overhead in the 
kernel, but it is not very interesting here.

If you think using event fd is worth the effort you are invited to send a patch 
integrating it :-)
Line 417: """
Line 418: 
Line 419: def __init__(self, map):
Line 420: rfd, wfd = os.pipe()


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-27 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 18: Code-Review+1

(3 comments)

very nice patch and sensible approach, keeping one eye on python3 (and 
borrowing code :)) is the right thing to do.
Conditional ACK: if we -projectwise- we want another better event loop, this 
seems a very good step forward.
I'm inclined to think fixing current code is not a better approach, for once.

https://gerrit.ovirt.org/#/c/54849/16/lib/vdsm/storage/asyncevent.py
File lib/vdsm/storage/asyncevent.py:

PS16, Line 305: vdsmm
typo: Vdsm


https://gerrit.ovirt.org/#/c/54849/18/lib/vdsm/storage/asyncevent.py
File lib/vdsm/storage/asyncevent.py:

PS18, Line 342: _cancelled
this is private because it was so in python3, right?
Otherwise I think it should be public.


PS18, Line 413: The read end of the pipe is watched by the event loop, 
while other threads
  : may wakeup the event loop by writing a byte to the write 
end.
  : 
  : Based on twisted.internet.posixbase._UnixWaker.
question: did you considered eventfd? If it was discarded, could you provide 
the rationale (for documentation purposes)?


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-25 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 18: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 18:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-08 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 17: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-08 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 17:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 16:

Francesco, I did not compare this to vmchannels or any other implementation.

Without scheduled calls this perform just like asyncore, which is quite fast 
compared with other python frameworks (e.g twisted).

Like asyncore, it is based on poll, so it will not scale well to 1000's of 
channels. The python 3 version supports epoll, so it should scale better.

Adding scheduled calls does not slow down the loop, as getting the next 
deadline is O(1). Adding and removing scheduled calls is O(logN) (based on 
binary heap), but it is not free. This use the same code we use in our 
scheduler.

Comparing with vmchannels, this implementation is single threaded, so it does 
not have the overhead of switching between threads. The only thing you can do 
from another thread is call_soon_threadsafe(), which append a callback to a 
deque (lock free). This callback will run on the event loop thread soon.

Here some numbers from the unit tests, see the tests for more info:

$ ./run_tests_local.sh storage_asyncevent_test.py --enable-slow-tests -s

 storage_asyncevent_test.TestEventLoopTiming
test_call_at(1)   1 calls: 
0.32
test_call_at(100)   100 calls: 
0.000535
test_call_at(1000) 1000 calls: 
0.005312
test_call_at(1)   1 calls: 
0.034455
test_call_at(10) 10 calls: 
0.285853
test_call_at_latency(, 1)   avg=0.37, 
min=0.37, med=0.37, max=0.37
test_call_at_latency(, 100) avg=0.10, 
min=0.03, med=0.07, max=0.46
test_call_at_latency(, 1000)avg=0.10, 
min=0.03, med=0.08, max=0.001217
test_call_at_latency(, 
1)avg=0.009000, min=0.009000, med=0.009000, max=0.009000
test_call_at_latency(, 
100)avg=0.005500, min=0.001000, med=0.005000, max=0.01
test_call_at_latency(, 
1000)avg=0.005500, min=0.001000, med=0.005000, max=0.01
test_call_later_counters(1)   1 
counters: 0.001179
test_call_later_counters(100)   100 
counters: 0.065841
test_call_later_counters(1000) 1000 
counters: 0.735294
test_call_later_loop(1)   1 loops: 
0.000194
test_call_later_loop(100)   100 loops: 
0.001125
test_call_later_loop(1000) 1000 loops: 
0.009732
test_call_soon_counters(1)1 
counters: 0.001258
test_call_soon_counters(100)100 
counters: 0.029263
test_call_soon_counters(1000)  1000 
counters: 0.274226
test_call_soon_loop(1)1 loops: 
0.000155
test_call_soon_loop(100)100 loops: 
0.000742
test_call_soon_loop(1000)  1000 loops: 
0.006204
test_call_soon_threadsafe(1)  1 calls: 
0.000656 seconds
test_call_soon_threadsafe(10)10 calls: 
0.000472 seconds
test_call_soon_threadsafe(1000)1000 calls: 
0.007304 seconds
test_call_soon_threadsafe(1)  1 calls: 
0.079299 seconds
test_echo(1)  1 echos: 
0.000128 seconds
test_echo(100)  100 echos: 
0.002077 seconds
test_echo(400)  400 echos: 
0.007679 seconds

I think the best way to evaluate this would be to write a prototype simulating 
the way we use vmchannels and see how it perform.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-04-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 16:

Nir, ok, understood what betterAsyncore and vmchannels does not provide.
Vmchannels has poor performance, we already know this. How fast is this new 
implementation?

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-03-30 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 16:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-03-25 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 14: Verified+1

Verified using the tests.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-03-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 14:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-03-25 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 13:

This version rename the module using the same style as asyncore and asynchat. 
The code is mostly take from asyncio, but the usage is limited to asyncore and 
asynchat.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-03-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the asyncevent module
..


Patch Set 13:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches