Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 16:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 15:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 14: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 14:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 13:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 12:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 11:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 10:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 9:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 8:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 7:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 6:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 5:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 4:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 3:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 2:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: monitoring: Use new monitoring infrastructure
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-13 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: monitoring: Use new monitoring infrastructure
..

monitoring: Use new monitoring infrastructure

DomainMonitor is keeping now a checker object, providing path checking
services. The checker starts with the domain monitor is created, and
stopped when shutting down vdsm.

Monitor threads use the checker to start checking the monitoring path
during setupLoop, and stop checking when the thread is stopping.

Since path checker events are received on a different thread, creating
new status and updating it is done under a lock to races when evaluating
status changes.

Change-Id: I18c87f3be6c570ee914388fc2ef7d6b847516b7c
Signed-off-by: Nir Soffer 
---
M vdsm/storage/monitor.py
1 file changed, 54 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/57432/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index d86853c..169375d 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -26,6 +26,7 @@
 from vdsm import concurrent
 from vdsm import utils
 from vdsm.config import config
+from vdsm.storage import check
 
 from . import clusterlock
 from . import misc
@@ -129,8 +130,12 @@
 def __init__(self, interval):
 self._monitors = {}
 self._interval = interval
+# NOTE: This must be used in asynchronous mode to prevent blocking of
+# the checker event loop thread.
 self.onDomainStateChange = misc.Event(
-"Storage.DomainMonitor.onDomainStateChange")
+"Storage.DomainMonitor.onDomainStateChange", sync=False)
+self._checker = check.CheckService()
+self._checker.start()
 
 @property
 def domains(self):
@@ -165,7 +170,7 @@
 
 log.info("Start monitoring %s", sdUUID)
 monitor = MonitorThread(weakref.proxy(self), sdUUID, hostId,
-self._interval)
+self._interval, self._checker)
 monitor.poolDomain = poolDomain
 monitor.start()
 # The domain should be added only after it succesfully started
@@ -205,6 +210,7 @@
 """
 log.info("Shutting down domain monitors")
 self._stopMonitors(self._monitors.values(), shutdown=True)
+self._checker.stop()
 
 def _stopMonitors(self, monitors, shutdown=False):
 # The domain monitor issues events that might become raceful if
@@ -234,7 +240,7 @@
 
 class MonitorThread(object):
 
-def __init__(self, domainMonitor, sdUUID, hostId, interval):
+def __init__(self, domainMonitor, sdUUID, hostId, interval, checker):
 self.thread = concurrent.thread(self._run, logger=log.name)
 self.domainMonitor = domainMonitor
 self.stopEvent = threading.Event()
@@ -242,6 +248,8 @@
 self.sdUUID = sdUUID
 self.hostId = hostId
 self.interval = interval
+self.checker = checker
+self.lock = threading.Lock()
 self.monitoringPath = None
 # For backward compatibility, we must present a fake status before
 # collecting the first sample. The fake status is marked as
@@ -287,6 +295,7 @@
 finally:
 log.debug("Domain monitor for %s stopped (shutdown=%s)",
   self.sdUUID, self.wasShutdown)
+self._stopCheckingPath()
 if self._shouldReleaseHostId():
 self._releaseHostId()
 
@@ -322,6 +331,12 @@
 if self.domain is None:
 self._produceDomain()
 
+# This may fail even if the domain was produced. We will try again in
+# the next cycle.
+if self.monitoringPath is None:
+self.monitoringPath = self.domain.getMonitoringPath()
+self.checker.start_checking(self.monitoringPath, self._pathChecked)
+
 # The isIsoDomain assignment is deferred because the isoPrefix
 # discovery might fail (if the domain suddenly disappears) and we
 # could risk to never try to set it again.
@@ -331,9 +346,7 @@
 @utils.cancelpoint
 def _produceDomain(self):
 log.debug("Producing domain %s", self.sdUUID)
-domain = sdCache.produce(self.sdUUID)
-self.monitoringPath = domain.getMonitoringPath()
-self.domain = domain
+self.domain = sdCache.produce(self.sdUUID)
 
 @utils.cancelpoint
 def _setIsoDomainInfo(self):
@@ -362,28 +375,10 @@
 if self._shouldRefreshDomain():
 self._refreshDomain()
 
-if self._checkPathStatus():
-self._checkDomainStatus()
+self._checkDomainStatus()
 
 if self._shouldAcquireHostId():
 self._acquireHostId()
-
-@utils.cancelpoint
-def _checkPathStatus(self):
-# This may block for long time if the storage server is not accessible.
-# On overloaded machines we have seen this take up to 15