Change in vdsm[master]: mount: Remove pointless force=True usage

2016-09-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-09-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount: Remove pointless force=True usage
..


mount: Remove pointless force=True usage

Using force=True when unmounting loop device is pointless - this option
will cause umount(8) to call the umount(2) syscall with the MNT_FORCE
flag, which is useful only for NFS mounts.

Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/56524
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
---
M tests/mkimageTests.py
M tests/mountTests.py
M vdsm/mkimage.py
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-09-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-09-13 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-09-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-05-15 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-05-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-04-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-04-24 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-04-23 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: mount: Remove pointless force=True usage
..

mount: Remove pointless force=True usage

Using force=True when unmounting loop device is pointless - this option
will cause umount(8) to call the umount(2) syscall with the MNT_FORCE
flag, which is useful only for NFS mounts.

Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Signed-off-by: Nir Soffer 
---
M tests/mkimageTests.py
M tests/mountTests.py
M vdsm/mkimage.py
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/56524/1

diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py
index d44054f..5332912 100644
--- a/tests/mkimageTests.py
+++ b/tests/mkimageTests.py
@@ -175,7 +175,7 @@
 self._check_content(checkPerms=False)
 self._check_label(floppy, label)
 finally:
-m.umount(force=True, freeloop=True)
+m.umount(freeloop=True)
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
@@ -197,7 +197,7 @@
 self._check_content()
 self._check_label(iso_img, label)
 finally:
-m.umount(force=True, freeloop=True)
+m.umount(freeloop=True)
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
diff --git a/tests/mountTests.py b/tests/mountTests.py
index 7903e9e..ad17b05 100644
--- a/tests/mountTests.py
+++ b/tests/mountTests.py
@@ -133,7 +133,7 @@
 try:
 self.assertTrue(m.isMounted())
 finally:
-m.umount(force=True, freeloop=True)
+m.umount(freeloop=True)
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
@@ -157,7 +157,7 @@
 try:
 self.assertTrue(m.isMounted())
 finally:
-m.umount(force=True, freeloop=True)
+m.umount(freeloop=True)
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py
index a737e1a..59940c5 100644
--- a/vdsm/mkimage.py
+++ b/vdsm/mkimage.py
@@ -112,7 +112,7 @@
 try:
 _decodeFilesIntoDir(files, dirname)
 finally:
-m.umount(force=True, freeloop=True)
+m.umount(freeloop=True)
 finally:
 _commonCleanFs(dirname, floppy)
 


-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove pointless force=True usage

2016-04-23 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: mount: Remove pointless force=True usage
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ff97d882f292f9c6325903ed9072b7146f682e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches