Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount: Remove unneeded freeloop=True usage
..


mount: Remove unneeded freeloop=True usage

On modern systems loop devices are mounted with the autoclear option, so
the loop device is automatically removed when unmounting it.

For example:

$ cat /sys/block/loop2/loop/autoclear
1

Checking umount(8) code show that it ignores the -d/--detach-loop option
in this case.

This patch removes this option when unmounting loop device.

Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/56543
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M tests/mkimageTests.py
M tests/mountTests.py
M vdsm/mkimage.py
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 5: Code-Review+2

taking your word about the unneededness of this arg.

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[fromani]

Francesco Romani has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: mount: Remove unneeded freeloop=True usage
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: mount: Remove unneeded freeloop=True usage

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: mount: Remove unneeded freeloop=True usage
..

mount: Remove unneeded freeloop=True usage

On modern systems loop devices are mounted with the autoclear option, so
the loop device is automatically removed when unmounting it.

For example:

$ cat /sys/block/loop2/loop/autoclear
1

Checking umount(8) code show that it ignores the -d/--detach-loop option
in this case.

This patch removes this option when unmounting loop device.

Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Signed-off-by: Nir Soffer 
---
M tests/mkimageTests.py
M tests/mountTests.py
M vdsm/mkimage.py
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/56543/1

diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py
index 5332912..fa18908 100644
--- a/tests/mkimageTests.py
+++ b/tests/mkimageTests.py
@@ -175,7 +175,7 @@
 self._check_content(checkPerms=False)
 self._check_label(floppy, label)
 finally:
-m.umount(freeloop=True)
+m.umount()
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
@@ -197,7 +197,7 @@
 self._check_content()
 self._check_label(iso_img, label)
 finally:
-m.umount(freeloop=True)
+m.umount()
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
diff --git a/tests/mountTests.py b/tests/mountTests.py
index ad17b05..781ffec 100644
--- a/tests/mountTests.py
+++ b/tests/mountTests.py
@@ -133,7 +133,7 @@
 try:
 self.assertTrue(m.isMounted())
 finally:
-m.umount(freeloop=True)
+m.umount()
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
@@ -157,7 +157,7 @@
 try:
 self.assertTrue(m.isMounted())
 finally:
-m.umount(freeloop=True)
+m.umount()
 # TODO: Use libudev to wait for specific event
 with stopwatch("Wait for udev events"):
 udevadm.settle(5)
diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py
index 59940c5..a6ed4a3 100644
--- a/vdsm/mkimage.py
+++ b/vdsm/mkimage.py
@@ -112,7 +112,7 @@
 try:
 _decodeFilesIntoDir(files, dirname)
 finally:
-m.umount(freeloop=True)
+m.umount()
 finally:
 _commonCleanFs(dirname, floppy)
 


-- 
To view, visit https://gerrit.ovirt.org/56543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91d8963ac04ec2569b6ccc9e9b03afc4d8d79f2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches