Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-13 Thread jniederm 
Jakub Niedermertl has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/57108/1/lib/vdsm/network/netinfo/nics.py
File lib/vdsm/network/netinfo/nics.py:

PS1, Line 44: 0 otherwise
this needs to be updated.


-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1:

please explain (in the commit message) what would happen on Engine side when 
this patch is applied

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-06 Thread jniederm 
Jakub Niedermertl has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-05 Thread mmirecki 
Marcin Mirecki has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1:

* #1322529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1322529::OK, public bug
* Check Product::#1322529::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

2016-05-05 Thread mmirecki 
Marcin Mirecki has uploaded a new change for review.

Change subject: net: Network speed reported as -1 if it can not be determined
..

net: Network speed reported as -1 if it can not be determined

If network speed can not be determined, as is for example the case
with virtio devices, the reported network speed should be -1

Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Bug-Url: https://bugzilla.redhat.com/1322529
Signed-off-by: mirecki 
---
M lib/vdsm/network/netinfo/nics.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/57108/1

diff --git a/lib/vdsm/network/netinfo/nics.py b/lib/vdsm/network/netinfo/nics.py
index 1fd6aaa..07240cf 100644
--- a/lib/vdsm/network/netinfo/nics.py
+++ b/lib/vdsm/network/netinfo/nics.py
@@ -56,8 +56,10 @@
 return _ibHackedSpeed(nic_name)
 else:
 logging.exception('cannot read %s nic speed', nic_name)
+return -1
 except Exception:
 logging.exception('cannot read %s speed', nic_name)
+return -1
 return 0
 
 
@@ -68,9 +70,9 @@
 https://bugzilla.redhat.com/show_bug.cgi?id=1101314
 """
 try:
-return 1 if drv_name(nic_name) == 'ib_ipoib' else 0
+return 1 if drv_name(nic_name) == 'ib_ipoib' else -1
 except IOError:
-return 0
+return -1
 
 
 def info(link, paddr):


-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches