Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Dan Kenigsberg has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Remove OVS bond implementation. .. net: Remove OVS bond implementation. The OVS bond is to be replaced by Linux bond. This patch removes all related OVS bond code. Note: Functional tests will fail with this patch and restored with the next patch. Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Signed-off-by: Edward Haas Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/63850 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/network/netswitch.py M lib/vdsm/network/ovs/info.py M lib/vdsm/network/ovs/switch.py M lib/vdsm/network/ovs/validator.py M tests/network/ovs_info_test.py M tests/network/ovs_switch_test.py M tests/network/ovs_test.py 7 files changed, 23 insertions(+), 258 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Petr Horáček has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Petr Horáček has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/63850/8/lib/vdsm/network/ovs/validator.py File lib/vdsm/network/ovs/validator.py: PS8, Line 65: No slaves defined Changed to: "Missing nics attribute" -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/63850/8/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:
Line 58: # TODO: Pass all nets and bonds to validator at once, not one by one.
Line 59: def validate_bond_configuration(bond, attrs, nets, running_nets,
kernel_nics):
Line 60: if 'remove' in attrs:
Line 61: _validate_bond_removal(bond, nets, running_nets)
Line 62: elif 'nics' in attrs:
> i can still pass {'nics': []}.
It was changed to pass a failure of no passing 'nics' key at all.
If it is passed empty, we have no problem creating the bond without slaves. We
will not explode on it.
Line 63: _validate_bond_addition(attrs['nics'], kernel_nics)
Line 64: else:
Line 65: raise ne.ConfigNetworkError(ne.ERR_BAD_NIC, 'No slaves
defined')
Line 66:
https://gerrit.ovirt.org/#/c/63850/8/tests/network/ovs_test.py
File tests/network/ovs_test.py:
Line 119: def test_add_bond_with_one_slave_twice(self):
Line 120: fake_kernel_nics = ['eth0']
Line 121: nets = {}
Line 122: running_nets = {}
Line 123: with self.assertNotRaises():
> i would remove this test.
I think we should explicit document (through tests) that we are ok if two same
slaves are added.
Some other implementation may raise an error on this, but we do not.
Line 124: ovs_validator.validate_bond_configuration(
Line 125: 'bond1', {'nics': ['eth0', 'eth0'], 'switch': 'ovs'},
nets,
Line 126: running_nets, fake_kernel_nics)
Line 127:
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Petr Horáček has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 8: Code-Review-1
(3 comments)
just a nit
https://gerrit.ovirt.org/#/c/63850/5/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS5, Line 221: '',
> ''
Done
https://gerrit.ovirt.org/#/c/63850/8/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:
Line 58: # TODO: Pass all nets and bonds to validator at once, not one by one.
Line 59: def validate_bond_configuration(bond, attrs, nets, running_nets,
kernel_nics):
Line 60: if 'remove' in attrs:
Line 61: _validate_bond_removal(bond, nets, running_nets)
Line 62: elif 'nics' in attrs:
i can still pass {'nics': []}.
should not this change be in following patch?
Line 63: _validate_bond_addition(attrs['nics'], kernel_nics)
Line 64: else:
Line 65: raise ne.ConfigNetworkError(ne.ERR_BAD_NIC, 'No slaves
defined')
Line 66:
https://gerrit.ovirt.org/#/c/63850/8/tests/network/ovs_test.py
File tests/network/ovs_test.py:
Line 119: def test_add_bond_with_one_slave_twice(self):
Line 120: fake_kernel_nics = ['eth0']
Line 121: nets = {}
Line 122: running_nets = {}
Line 123: with self.assertNotRaises():
i would remove this test.
it used to make sense when we needed it to explode. now it does no make sense
anymore as an unit test (we should test it on functional level)
Line 124: ovs_validator.validate_bond_configuration(
Line 125: 'bond1', {'nics': ['eth0', 'eth0'], 'switch': 'ovs'},
nets,
Line 126: running_nets, fake_kernel_nics)
Line 127:
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 6: Code-Review+1 Ack-ing changes from patch2. -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63850/5/lib/vdsm/network/ovs/info.py File lib/vdsm/network/ovs/info.py: PS5, Line 221: None '' -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/63850/3/tests/network/ovs_info_test.py File tests/network/ovs_info_test.py: Lets do all the changes in this file in a separate patch, before this one. It will be easier to review the patch of ovs bond removal in the future. Line 1: # Copyright 2016 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/63850/2/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:
Line 106: obtained_bridges_by_sb = ovs_info.bridges_by_sb
Line 107: self.assertEqual(obtained_bridges_by_sb, {})
Line 108:
Line 109:
Line 110: # class MockedOvsInfo(info.OvsInfo):
Having hard time decoding these tests, they need to be adjusted to OVS no bond
support.
In the next patch, some tests for bonds should be added here.
Line 111: # def __init__(self):
Line 112: # self._bridges = {
Line 113: # TEST_BRIDGE: {
Line 114: # 'stp': False,
--
To view, visit https://gerrit.ovirt.org/63850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 2: This patch will pass only unit tests, it breaks functional ovs tests. Only the next patch will fix them all. This patch must be merged with the next one. -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63850/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-09-14 14:26:55 +0300 Line 4: Commit: Edward Haas Line 5: CommitDate: 2016-09-14 14:33:20 +0300 Line 6: Line 7: net: Remove OVS bond setup. > But it works with bondings created by us, with other_config: vdsm_level=sou Right. Removing everything. Line 8: Line 9: The OVS bond is to be replaced by Linux bond. Line 10: This patch removes all setup related OVS bond code. Line 11: -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Remove OVS bond implementation.
gerrit-hooks has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/63850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e3d6ba6ecd64bbf22d4be88af6a69ed2f476cea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
