Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-14 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-14 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: clearer log for unavailable bonds
..


net: clearer log for unavailable bonds

Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Signed-off-by: Ido Barkan ibar...@redhat.com
Reviewed-on: https://gerrit.ovirt.org/40542
Reviewed-by: Ondřej Svoboda osvob...@redhat.com
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/vdsm-restore-net-config
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Verified
  Ondřej Svoboda: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-07 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-07 Thread ibarkan 
Ido Barkan has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-06 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-06 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-05 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: net: clearer log for unavailable bonds
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: clearer log for unavailable bonds

2015-05-05 Thread ibarkan 
Ido Barkan has uploaded a new change for review.

Change subject: net: clearer log for unavailable bonds
..

net: clearer log for unavailable bonds

Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M vdsm/vdsm-restore-net-config
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/40542/1

diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index ba24007..4af83b6 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -135,8 +135,8 @@
 nic = attrs.get('nic')
 if bond is not None:
 if bond not in persisted_bonds:
-logging.error('Bond %s is not configured. '
-  'Network %s will not be '
+logging.error('Bond %s is not persisted and will not be '
+  'configured. Network %s will not be '
   'configured as a consequence', bond, net)
 elif bond not in available_bonds:
 logging.error('Some of the nics required by bond %s (%s) '


-- 
To view, visit https://gerrit.ovirt.org/40542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches