Change in vdsm[master]: net: remove delNetwork old API

2015-11-22 Thread ibarkan 
Ido Barkan has uploaded a new change for review.

Change subject: net: remove delNetwork old API
..

net: remove delNetwork old API

This API is not supported anymore in 4.x clusters hence should be
removed.

Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Signed-off-by: Ido Barkan 
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/jsonrpcvdscli.py
M tests/functional/networkTests.py
M tests/functional/networkTestsOVS.py
M tests/functional/utils.py
M vdsm/API.py
M vdsm/network/api.py
M vdsm/rpc/bindingxmlrpc.py
9 files changed, 4 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/48911/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 4e6decd..ce8236c 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1755,21 +1755,6 @@
 status = self.s.setupNetworks(networks, bondings, params)
 return status['status']['code'], status['status']['message']
 
-def do_delNetwork(self, args):
-params = self._eqSplit(args)
-try:
-nics = params['nics'].split(',')
-except:
-raise ValueError
-bridge = params.get('bridge', '')
-vlan = params.get('vlan', '')
-bond = params.get('bond', '')
-for k in ['bridge', 'vlan', 'bond', 'nics']:
-if k in params:
-del params[k]
-status = self.s.delNetwork(bridge, vlan, bond, nics, params)
-return status['status']['code'], status['status']['message']
-
 def do_setSafeNetworkConfig(self, args):
 status = self.s.setSafeNetworkConfig()
 return status['status']['code'], status['status']['message']
@@ -2763,11 +2748,6 @@
'Setup new configuration of multiple networks and '
'bonds.'
)),
-'delNetwork': (serv.do_delNetwork,
-   ('bridge= [vlan=] [bond=] '
-'nics=nic[,nic]',
-'Remove a network (and parts thereof) from this vds.'
-)),
 'setSafeNetworkConfig': (serv.do_setSafeNetworkConfig,
  ('',
   'declare current network configuration as '
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index 6287250..0f8b73e 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -75,28 +75,6 @@
   '*hostQos': 'HostQoSParams'}}
 
 ##
-# @Host.delNetwork:
-#
-# Remove a network from this host.
-#
-# @bridge:   The name of the network to remove
-#
-# @vlan: #optional The name of an associated vlan to remove
-#
-# @bond: #optional The name of an associated bond device to remove
-#
-# @nics: #optional A list of associated network devices to remove
-#
-# @options:  #optional A @NetworkOptions structure
-#
-# Since: 4.10.0
-##
-
-{'command': {'class': 'Host', 'name': 'delNetwork'},
- 'data': {'bridge': 'str', '*vlan': 'str', '*bond': 'str', '*nics': ['str'],
-  '*options': 'NetworkOptions'}}
-
-##
 # @SetupNetworkNetAttributes:
 #
 # Configuration attributes for a single host network.
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 2c6280a..a63437e 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -38,7 +38,6 @@
 
 _COMMAND_CONVERTER = {
 'create': 'VM.create',
-'delNetwork': 'Host.delNetwork',
 'destroy': 'VM.destroy',
 'fullList': 'Host.getVMFullList',
 'getAllVmStats': 'Host.getAllVmStats',
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index b3cfb48..961b13f 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -713,12 +713,10 @@
 self.assertEqual(status, SUCCESS, msg)
 
 @cleanupNet
-@permutations([[True], [False]])
-def testDelWithoutAdd(self, bridged):
-with dummyIf(1) as nics:
-status, msg = self.vdsm_net.delNetwork(NETWORK_NAME, nics=nics,
-   opts={'bridged': bridged})
-self.assertEqual(status, errors.ERR_BAD_BRIDGE, msg)
+def testDelWithoutAdd(self):
+status, msg = self.vdsm_net.setupNetworks(
+{NETWORK_NAME: {'remove': True}}, {}, NOCHK)
+self.assertEqual(status, errors.ERR_BAD_BRIDGE, msg)
 
 @cleanupNet
 @permutations([[True], [False]])
diff --git a/tests/functional/networkTestsOVS.py 
b/tests/functional/networkTestsOVS.py
index 5a5a9d5..273247b 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -104,8 +104,6 @@
 does_not_use_ovs = [
 'testAddDelBondedNetwork(False)',
 'testAddDelBondedNetwork(True)',
-'testAddDelNetwork(False)',
-'testAddDelNetwork(True)',
 'testBondHwAddress(False)',
 'testBondHwAddress(True)',
 'testDelNetwo

Change in vdsm[master]: net: remove delNetwork old API

2015-11-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-24 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-24 Thread ibarkan 
Ido Barkan has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/48911/6/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 43
Line 44
Line 45
Line 46
Line 47
can be dropped, as setupNetworks uses its own @SetupNetworkNetAttributes


-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-26 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-26 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-26 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 7:

Please make jenkins happy.

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-26 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: remove delNetwork old API
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: remove delNetwork old API

2015-11-27 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: remove delNetwork old API
..


net: remove delNetwork old API

This API is not supported anymore in 4.x clusters hence should be
removed.

Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/48911
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Tested-by: Edward Haas 
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/jsonrpcvdscli.py
M tests/functional/networkTests.py
M tests/functional/networkTestsOVS.py
M tests/functional/utils.py
M vdsm/API.py
M vdsm/network/api.py
M vdsm/rpc/bindingxmlrpc.py
9 files changed, 4 insertions(+), 135 deletions(-)

Approvals:
  Ido Barkan: Verified
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7224923ef77282a1abfe4af49f114784358c154
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches