Change in vdsm[master]: net: remove el6 support for libnl binding
Dan Kenigsberg has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: remove el6 support for libnl binding .. net: remove el6 support for libnl binding Since 3.6 does not support el6 this commit reverts 2 other commits: 02ab984 vdsm: Fix memory leak in netlink/link.py 66aa7d8 libnl: workaround for _rtnl_link_get_kernel on el6 The workaround is no longer needed hence also the fix for the memory leak it created. Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Signed-off-by: Ido Barkan Reviewed-on: https://gerrit.ovirt.org/40571 Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg Continuous-Integration: Dan Kenigsberg --- M lib/vdsm/netlink/link.py 1 file changed, 21 insertions(+), 52 deletions(-) Approvals: Ido Barkan: Verified Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
Dan Kenigsberg has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: Code-Review+2 Raising score -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
Petr Horáček has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove el6 support for libnl binding
automat...@ovirt.org has posted comments on this change. Change subject: net: remove el6 support for libnl binding .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I146744a1346b56b7064d841370c7fbfea2a4a0ef Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
