Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 50: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24456/50//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-02-07 02:56:31 +0100
Line 4: Commit: Ondřej Svoboda osvob...@redhat.com
Line 5: CommitDate: 2014-05-20 19:23:38 +0200
Line 6:
Line 7: netinfo: Retrieve bonding options differing from defaults
the commit messsage should describe the modified output, as well as the
motivation for the change.
Line 8:
Line 9: Functional network tests were extended to check for live values.
Line 10:
Line 11: Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
http://gerrit.ovirt.org/#/c/24456/50/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1403:
Line 1404: self.assertBondExists(BONDING_NAME, nics[:2],
Line 1405:
bondings[BONDING_NAME].get('options'))
Line 1406:
self.assertEquals(self.vdsm_net.getBondMode(BONDING_NAME),
Line 1407: REQMODE_BROADCAST) # TODO:
redundant?
If you want to add a TODO, make it clear so that other engineers can understand
the issue.
Line 1408:
Line 1409: bondings = {BONDING_NAME: dict(remove=True)}
Line 1410: status, msg = self.vdsm_net.setupNetworks({},
bondings, {})
Line 1411:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 50
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 46: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1367/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9053/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9194/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8265/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 46 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 47: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1370/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8288/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 47 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 48: -Code-Review -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1373/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9081/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9222/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8293/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 48 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 48:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/48/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1403:
Line 1404: self.assertBondExists(BONDING_NAME, nics[:2],
Line 1405:
bondings[BONDING_NAME].get('options'))
Line 1406:
self.assertEquals(self.vdsm_net.getBondMode(BONDING_NAME),
Line 1407: REQMODE_BROADCAST) # TODO:
redundant?
getBondMode (in tests/functional/utils.py) is made redundant by the new check
in assertBondExists.
Line 1408:
Line 1409: bondings = {BONDING_NAME: dict(remove=True)}
Line 1410: status, msg = self.vdsm_net.setupNetworks({},
bondings, {})
Line 1411:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 49: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1376/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8297/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 49 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 50: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1379/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9237/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8308/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 50 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 43: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1359/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9022/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9163/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8234/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 43 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 44: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1362/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9030/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9171/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8242/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 44 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 45: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1365/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9035/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9176/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8247/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 45 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 41: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24456/41/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1216: # See if live options (read from sysfs) match those requested Line 1217: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1218: self.assertEqual(set(cfg['BONDING_OPTS'].split()), Line 1219: set(bondDict['options'].split())) Line 1220: I'd rather have this check integrated as an optional check inside assertBondExists Line 1221: @cleanupNet Line 1222: @permutations([[True], [False]]) Line 1223: @RequireDummyMod Line 1224: @ValidateRunningAsRoot -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 42: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1354/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9006/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8080/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 42 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 39: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1343/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8967/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8041/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 40: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1347/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8060/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 40 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 41: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1351/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8854/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8064/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 33: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8191/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8304/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1271/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7401/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 32:
(6 comments)
http://gerrit.ovirt.org/#/c/24456/32/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 43: from .ipwrapper import Route
Line 44: from .ipwrapper import routeGet
Line 45: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways
Line 46: from . import libvirtconnection
Line 47: from .utils import execCmd, memoized, CommandPath
.utils should come after .netlink ( alphabetically)
Done
Line 48: from .netconfpersistence import RunningConfig
Line 49: from .netlink import iter_addrs, iter_links
Line 50:
Line 51:
Line 535: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 536:
Line 537:
Line 538: @memoized
Line 539: def _getDefaultBondingOptions():
This function still misses a docstring explained king its return value.
Done
Line 540: teeCmd = _TEE_BINARY.cmd
Line 541: MAX_MODE = 6
Line 542:
Line 543: bondName = _randomIfaceName()
Line 593: Options having symbolic values, e.g. 'mode', are presented by
sysfs in
Line 594: the order symbolic name, numeric value, e.g. 'balance-rr 0'.
Line 595: From a list given by bondOpts(), the numeric value is chosen.
Line 596:
Line 597: 'mode' is ordered the first so e.g. iproute2 configurator sets it
first.
Iproute2 configurator should be fixed to take mode first. (in a separate
After sending a new iteration of this patch, I will investigate.
Line 598: '''
Line 599: mode = opts.pop('mode', None)
Line 600: ifcfg = sorted(opts.iteritems())
Line 601: if mode:
http://gerrit.ovirt.org/#/c/24456/32/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1043:
Line 1044: self.assertNetworkExists(NETWORK_NAME, bridged=bridged)
Line 1045: self.assertBondExists(BONDING_NAME, nics)
Line 1046:
Line 1047: # Reduce bond size and create Network on detached NIC
please avoid whitespace noise.
I thought I had already edited this out. Fixed :-)
Line 1048:
Line 1049: with nonChangingOperstate(BONDING_NAME):
Line 1050: netName = NETWORK_NAME + '-2'
Line 1051: networks = {netName: dict(nic=nics[0],
http://gerrit.ovirt.org/#/c/24456/32/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:
Line 152: self.configApplier.setIfaceMtu(iface.name, maxMtu)
Line 153: return maxMtu
Line 154:
Line 155: def _waitForBondUp(self, bond):
Line 156: # TODO: avoid polling
indeed. the easiest way to do this is
Thanks! This was more of a proof-of-concept, written off the top of my head.
Line 157: INTERVAL = 0.1
Line 158: for _ in range(50):
Line 159: if netinfo.operstate(bond) == netinfo.OPERSTATE_UP:
Line 160: return
http://gerrit.ovirt.org/#/c/24456/32/vdsm/sudoers.vdsm.in
File vdsm/sudoers.vdsm.in:
Line 1: Cmnd_Alias VDSM_LIFECYCLE = \
Line 2: @DMIDECODE_PATH@, \
Line 3: @TEE_PATH@ /sys/class/net/bonding_masters, \
Line 4: @TEE_PATH@ /sys/class/net/*/bonding/mode, \
Would you place that under a new Cmnd_Alias called VDSM_NETWORK ?
Done
Line 5: @VDSMDIR@/mk_sysprep_floppy, \
Line 6: @SERVICE_PATH@ ksmtuned *, \
Line 7: @SERVICE_PATH@ ksm *
Line 8: Cmnd_Alias VDSM_STORAGE = @MOUNT_PATH@, @UMOUNT_PATH@, \
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 34: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8193/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8306/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1273/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7403/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 35: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8195/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8308/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1275/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7405/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 36: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8197/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8310/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1277/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7407/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 37: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8199/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8312/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1279/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7409/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 37 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 38: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8201/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8314/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1281/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7411/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 32: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8106/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7203/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 32:
(3 comments)
very partial review
http://gerrit.ovirt.org/#/c/24456/32/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 43: from .ipwrapper import Route
Line 44: from .ipwrapper import routeGet
Line 45: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways
Line 46: from . import libvirtconnection
Line 47: from .utils import execCmd, memoized, CommandPath
.utils should come after .netlink ( alphabetically)
Line 48: from .netconfpersistence import RunningConfig
Line 49: from .netlink import iter_addrs, iter_links
Line 50:
Line 51:
Line 535: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 536:
Line 537:
Line 538: @memoized
Line 539: def _getDefaultBondingOptions():
This function still misses a docstring explained king its return value.
Line 540: teeCmd = _TEE_BINARY.cmd
Line 541: MAX_MODE = 6
Line 542:
Line 543: bondName = _randomIfaceName()
Line 593: Options having symbolic values, e.g. 'mode', are presented by
sysfs in
Line 594: the order symbolic name, numeric value, e.g. 'balance-rr 0'.
Line 595: From a list given by bondOpts(), the numeric value is chosen.
Line 596:
Line 597: 'mode' is ordered the first so e.g. iproute2 configurator sets it
first.
Iproute2 configurator should be fixed to take mode first. (in a separate
patch!)
Line 598: '''
Line 599: mode = opts.pop('mode', None)
Line 600: ifcfg = sorted(opts.iteritems())
Line 601: if mode:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 32: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/24456/32/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1043:
Line 1044: self.assertNetworkExists(NETWORK_NAME, bridged=bridged)
Line 1045: self.assertBondExists(BONDING_NAME, nics)
Line 1046:
Line 1047: # Reduce bond size and create Network on detached NIC
please avoid whitespace noise.
Line 1048:
Line 1049: with nonChangingOperstate(BONDING_NAME):
Line 1050: netName = NETWORK_NAME + '-2'
Line 1051: networks = {netName: dict(nic=nics[0],
http://gerrit.ovirt.org/#/c/24456/32/vdsm/network/configurators/__init__.py
File vdsm/network/configurators/__init__.py:
Line 151: else:
Line 152: self.configApplier.setIfaceMtu(iface.name, maxMtu)
Line 153: return maxMtu
Line 154:
Line 155: def _waitForBondUp(self, bond):
nothing in this function is specific to bond. it could be any iface for us to
wait for.
Line 156: # TODO: avoid polling
Line 157: INTERVAL = 0.1
Line 158: for _ in range(50):
Line 159: if netinfo.operstate(bond) == netinfo.OPERSTATE_UP:
Line 152: self.configApplier.setIfaceMtu(iface.name, maxMtu)
Line 153: return maxMtu
Line 154:
Line 155: def _waitForBondUp(self, bond):
Line 156: # TODO: avoid polling
indeed. the easiest way to do this is
mon = ipwrapper.Monitor()
mon.start()
to fire a new thread, that does
for event in mon:
if iface is up:
return
and in this function, join() on that thread with a timeout.
This new function is better split to another patch, with its own test, and
should be placed in ipwrapper.
Line 157: INTERVAL = 0.1
Line 158: for _ in range(50):
Line 159: if netinfo.operstate(bond) == netinfo.OPERSTATE_UP:
Line 160: return
http://gerrit.ovirt.org/#/c/24456/32/vdsm/sudoers.vdsm.in
File vdsm/sudoers.vdsm.in:
Line 1: Cmnd_Alias VDSM_LIFECYCLE = \
Line 2: @DMIDECODE_PATH@, \
Line 3: @TEE_PATH@ /sys/class/net/bonding_masters, \
Line 4: @TEE_PATH@ /sys/class/net/*/bonding/mode, \
Would you place that under a new Cmnd_Alias called VDSM_NETWORK ?
Line 5: @VDSMDIR@/mk_sysprep_floppy, \
Line 6: @SERVICE_PATH@ ksmtuned *, \
Line 7: @SERVICE_PATH@ ksm *
Line 8: Cmnd_Alias VDSM_STORAGE = @MOUNT_PATH@, @UMOUNT_PATH@, \
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 28: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7904/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7114/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8016/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1226/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 29: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7907/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7117/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8019/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1227/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 30: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7932/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7142/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8044/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1231/ : ABORTED -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 31: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7933/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7143/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/8045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1233/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7058/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1221/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 21: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7023/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7925/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7814/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1203/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 534: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH)) Line 535: Line 536: Line 537: @memoized Line 538: def _getDefaultBondingOptions(): Actually, the nature of the bonding options is that only the 802.3ad (4) mo Additionally, the 'extra' 802.3ad options have to be examinated if they are 'options' at all. I will read up on them in the kernel documentation. Line 539: teeCmd = _TEE_BINARY.cmd Line 540: MAX_MODE = 6 Line 541: Line 542: bondName = _randomIfaceName() -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7024/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1204/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 23: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7028/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7930/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1207/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7033/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1212/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7037/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7939/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1216/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7039/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1218/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7890/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1191/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7892/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1192/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7894/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7783/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1193/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 17: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6997/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7899/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7788/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1196/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7900/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7789/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1197/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6999/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7901/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7790/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1198/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7000/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7902/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1199/ : FAILURE -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 20: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 534: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 535:
Line 536:
Line 537: @memoized
Line 538: def _getDefaultBondingOptions():
please document the two-level dictionary returned here
Line 539: teeCmd = _TEE_BINARY.cmd
Line 540: MAX_MODE = 6
Line 541:
Line 542: bondName = _randomIfaceName()
Line 569: def _getBondingOptions(bond):
Line 570: '''
Line 571: Returns non-empty options differing from defaults, excluding e.g.
'slaves'.
Line 572:
Line 573: A string key=value representation (as in ifcfg) is also returned
for
A function should do one thing. Please split the dict-to-legacy conversion to
another helper function.
Line 574: backwards compatibility reasons.
Line 575: '''
Line 576: EXCLUDED = frozenset(('slaves', 'active_slave', 'mii_status',
'queue_id'))
Line 577:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 20: (obviously, the most important thing is to understand why testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)ERROR testSetupNetworksAddOverExistingBond(kwargs=False) ERROR ) -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 20:
(2 comments)
The functional tests are being solved by making sure only the expected options
(reverting any divergence) are applied when adding/changing a bond.
http://gerrit.ovirt.org/#/c/24456/20/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 534: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 535:
Line 536:
Line 537: @memoized
Line 538: def _getDefaultBondingOptions():
please document the two-level dictionary returned here
Actually, the nature of the bonding options is that only the 802.3ad (4) mode
uses a few specific, extra options whose values are empty for other modes. The
rest of the options is all the same, both key-wise and value-wise.
The simplicity of the design makes great sense here and I suppose the concept
of modes sharing the defaults is going to stay. Thus I propose to combine the
defaults in a single dictionary.
Line 539: teeCmd = _TEE_BINARY.cmd
Line 540: MAX_MODE = 6
Line 541:
Line 542: bondName = _randomIfaceName()
Line 569: def _getBondingOptions(bond):
Line 570: '''
Line 571: Returns non-empty options differing from defaults, excluding e.g.
'slaves'.
Line 572:
Line 573: A string key=value representation (as in ifcfg) is also returned
for
A function should do one thing. Please split the dict-to-legacy conversion
Agreed, locally, I have already moved the code out.
Line 574: backwards compatibility reasons.
Line 575: '''
Line 576: EXCLUDED = frozenset(('slaves', 'active_slave', 'mii_status',
'queue_id'))
Line 577:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: For our planned resetting of bonding options before taking a bond up we definitely need to remember either default options per mode (if the mode would for some reason be believed to be already pre-set and thus not touched at all) or just default options for the default mode 0 (which sounds more probable). -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7515/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 13: Verified-1 There are a few functional tests that fail, we are dealing with them, therefore a -1. For a later iteration we might consider gathering default values of different bonding modes. E.g. after VDSM sets the miimon to its own default of 150 and, importantly, the mode to 4 (802.3ad), there appear new /sys nodes, which results in BONDING_OPTS reporting them too: ad_actor_key=0 ad_aggregator=0 ad_num_ports=0 ad_partner_key=0 miimon=150 mode=4 -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 13:
When running all functional network tests (in alphabetical order), the
testIPv6ConfigNetwork failing leaves bonding options in a non-clean state:
ad_actor_key=0 ad_aggregator=6 ad_num_ports=1 ad_partner_key=1
ad_partner_mac=00:00:00:00:00:00 miimon=9 mode=4
Running NOSE_EXCLUDE=testIPv6ConfigNetwork ./run_tests_local.sh
functional/networkTests.py avoids this.
However, testSetupNetworksAddOverExistingBond(kwargs=False) and
testSetupNetworksKeepNetworkOnBondAfterBondResizing(kwargs=True) error out due
to OperStateChangedError: bond0 operstate changed: DOWN - [('bond0', 'UP'),
('bond0', 'UP')] or the like.
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7371/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7486/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7326/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7444/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: Code-Review-1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) using set(split()) on both sides would be more elegant than forcing everybody to sort their options. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) using set(split()) on both sides would be more elegant than forcing everybo It assures that the new function returns options sorted, maybe this deserves a comment. Given that we only test bonding options here, I would rather reorder the options manually instead of possible ' '.join(sorted(bondDict['options'].split())) which is ugly. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) It assures that the new function returns options sorted, maybe this deserve As you said, ' '.join(sorted(bondDict['options'].split())) is ugly. That's why I suggested self.assertEqual(set(cfg['BONDING_OPTS'].split()), set(bondDict['options']).split()) This way, you do not force future test writers to remember that they have to sort their option. Options may be unsorted in real life, so this should be possible also in the test framework. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1162: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1163: Line 1164: # See if live options (read from sysfs) match those requested Line 1165: cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg'] Line 1166: self.assertEqual(cfg['BONDING_OPTS'], bondDict['options']) As you said, Okay, it's not much of an advantage that we know our bondopts are sorted. Line 1167: Line 1168: with dummyIf(3) as nics: Line 1169: with self.vdsm_net.pinger(): Line 1170: # Add initial vlanned net over bond -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7459/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults (WIP) .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7320/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7438/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: # (TODO: but the kernel default for mode is
balance-rr, 0)
Line 1193: cfg =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
Line 1194: self.assertEqual(cfg['BONDING_OPTS'], 'miimon=9')
If the default mode is 0 shouldn't you put before this
opts = 'mode=4 miimon=9'
and after the operation
cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
for element in cfg['BONDING_OPTS'].split(' '):
self.assertIn(element, opts.split(' '))
Line 1195:
Line 1196: # cleanup
Line 1197: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
Line 1198: num in range(5))
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 8: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24456/8/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 581: # Actual options in /sys are multi-valued and again, separated by a space, Line 582: # including 'mode' which reads: 'balance-rr 0' Line 583: # For compatibility with older Engines we should return 'mode' as a number Line 584: # and never handle other multi-valued options Line 585: opts = ' '.join((k + '=' + ','.join(v) for (k, v) in opts.iteritems())) How about just: You should not return dictionary, but a space-separated string. Not all opts are as-important, but we should match whatever Engine used to send. slaves should be blacklisted, and maybe others, but in general - please report anything that differs from the defaults. Line 586: info['cfg']['BONDING_OPTS'] = opts Line 587: Line 588: return info Line 589: -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7:
(5 comments)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 75:
Line 76: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 77: DUMMY_BRIDGE = ';vdsmdummy;'
Line 78: DEFAULT_MTU = '1500'
Line 79: MAX_BOND_NAME_LENGTH = 15
being a class member is not a real problem. but being out of lib/vdsm direc
Yes, that. Moved back.
Line 80:
Line 81: REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3',
'bond4'))
Line 82:
Line 83: _Qos = namedtuple('Qos', 'inbound outbound')
Line 538: return info
Line 539:
Line 540:
Line 541: def _randomIfaceName():
Line 542: CHARS = string.ascii_lowercase + string.ascii_uppercase
string.digits are valid, too, btw.
Yep, I was trying them too. Adding.
Line 543:
Line 544: return ''.join(random.choice(CHARS) for _ in
range(MAX_BOND_NAME_LENGTH))
Line 545:
Line 546:
Line 565: def _getBondingOptions(bond):
Line 566: defaults = _getDefaultBondingOptions()
Line 567: opts = bondOpts(bond)
Line 568:
Line 569: for key, val in dict(opts).iteritems():
creating a copy and deleting elements from it is a bit cumbersome. Starting
Dictionary comprehension should work well in this case, defaults.get(k) returns
None which never comes out of bondOpts.
Line 570: if key in defaults and val == defaults[key]:
Line 571: del opts[key]
Line 572:
Line 573: return opts
http://gerrit.ovirt.org/#/c/24456/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: opts =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['options']
Line 1193: self.assertEqual(opts, {'miimon': ['9']})
please add an assertion for legacy ['cfg'][BONDING_OPTS]
Assertion added.
The check is not general. The default of 802.3ad 4 is actually VDSM's
(vdsm/netmodels.py:182), normally I get balance-rr 0. To move the assertion
inside the function I would have to pass the expected bonding options.
Line 1194:
Line 1195: # cleanup
Line 1196: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
Line 1197: num in range(5))
http://gerrit.ovirt.org/#/c/24456/7/tests/netinfoTests.py
File tests/netinfoTests.py:
Line 344:
Line 345: with open(BONDING_MASTERS, 'w') as bonds:
Line 346: try:
Line 347: bonds.write('+' + bondName)
Line 348: bonds.flush()
these should be taken out of the try block: -bondName should be written on
Done
Line 349:
Line 350: self.assertEqual(_getBondingOptions(bondName), {},
Line 351: 'No options should be returned.')
Line 352:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/24456/8/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 581: # Actual options in /sys are multi-valued and again, separated by a space, Line 582: # including 'mode' which reads: 'balance-rr 0' Line 583: # For compatibility with older Engines we should return 'mode' as a number Line 584: # and never handle other multi-valued options Line 585: opts = ' '.join((k + '=' + ','.join(v) for (k, v) in opts.iteritems())) k + '=' + v[-1] if v would return the number for 'mode' and break other multi-valued options (e.g. 'slaves'), but we do not use them, do we? Instead of 'slaves', BOND=bond0 is used in bonded interfaces' ifcfg. Line 586: info['cfg']['BONDING_OPTS'] = opts Line 587: Line 588: return info Line 589: -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 8: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7319/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6417/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7201/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/24456/8/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 581: # Actual options in /sys are multi-valued and again, separated by
a space,
Line 582: # including 'mode' which reads: 'balance-rr 0'
Line 583: # For compatibility with older Engines we should return 'mode' as
a number
Line 584: # and never handle other multi-valued options
Line 585: opts = ' '.join((k + '=' + ','.join(v) for (k, v) in
opts.iteritems()))
k + '=' + v[-1] if v
yeah, slaves should not be reported in BONDING_OPTS.
Line 586: info['cfg']['BONDING_OPTS'] = opts
Line 587:
Line 588: return info
Line 589:
http://gerrit.ovirt.org/#/c/24456/8/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:],
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: self.assertIn(BONDING_NAME,
self.vdsm_net.netinfo.bondings)
This is not the assertion I requested. You need to verify that [BONDING_
NAME][cfg][BONDING_OPTS] is as expected.
Line 1193: opts =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['options']
Line 1194: self.assertEqual(opts, {'miimon': ['9']})
Line 1195:
Line 1196: # cleanup
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/8/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 581: # Actual options in /sys are multi-valued and again, separated by
a space,
Line 582: # including 'mode' which reads: 'balance-rr 0'
Line 583: # For compatibility with older Engines we should return 'mode' as
a number
Line 584: # and never handle other multi-valued options
Line 585: opts = ' '.join((k + '=' + ','.join(v) for (k, v) in
opts.iteritems()))
yeah, slaves should not be reported in BONDING_OPTS.
How about just:
info['cfg']['BONDING_OPTS'] = {
'mode': opts['mode'][-1], # the last in ['balance-rr', '0']
'miimon': opts['miimon']
}
Assaf already said that not many options matter. And all this is for
compatibility's sake.
Line 586: info['cfg']['BONDING_OPTS'] = opts
Line 587:
Line 588: return info
Line 589:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/8/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:],
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: self.assertIn(BONDING_NAME,
self.vdsm_net.netinfo.bondings)
This is not the assertion I requested. You need to verify that [BONDING_ NA
I will check on my RHEL6.5 host what to actually expect because the default
mode is 0, not 4...
Line 1193: opts =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['options']
Line 1194: self.assertEqual(opts, {'miimon': ['9']})
Line 1195:
Line 1196: # cleanup
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24456/4/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1729: self.assertEqual(status, SUCCESS, msg) Line 1730: self.assertNetworkDoesntExist(NETWORK_NAME) Line 1731: Line 1732: # naroubovat getBondingOptions do testuu s bondy Line 1733: # assertBondOptsEqual Read as: use _getBondingOptions in functional bonding tests, too. -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7312/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6410/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7194/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7315/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6413/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7197/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24456/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:],
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: self.assertEqual(_getBondingOptions(BONDING_NAME),
This should be checked by using the netinfo information inside self.vdsm_net
that is automatically updated after each request to vdsm, not by using netinfo.
Line 1193: {'miimon': ['9']})
Line 1194:
Line 1195: # cleanup
Line 1196: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 575:
Line 576: def _bondinfo(link, ipaddrs):
Line 577: info = _devinfo(link, ipaddrs)
Line 578: info.update({'hwaddr': link.address, 'slaves': slaves(link.name),
Line 579: 'options': _getBondingOptions(link)})
you should also overwrite ['cfg']['BONDING_OPTS'] - older Engines depend on it.
Line 580: return info
Line 581:
Line 582:
Line 583: def _vlaninfo(link, ipaddrs):
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/24456/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 575:
Line 576: def _bondinfo(link, ipaddrs):
Line 577: info = _devinfo(link, ipaddrs)
Line 578: info.update({'hwaddr': link.address, 'slaves': slaves(link.name),
Line 579: 'options': _getBondingOptions(link)})
you should also overwrite ['cfg']['BONDING_OPTS'] - older Engines depend on
Done
Line 580: return info
Line 581:
Line 582:
Line 583: def _vlaninfo(link, ipaddrs):
http://gerrit.ovirt.org/#/c/24456/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1188: {'nics': nics[1:],
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: self.assertEqual(_getBondingOptions(BONDING_NAME),
This should be checked by using the netinfo information inside self.vdsm_ne
Done
Line 1193: {'miimon': ['9']})
Line 1194:
Line 1195: # cleanup
Line 1196: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7316/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6414/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7198/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 75:
Line 76: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 77: DUMMY_BRIDGE = ';vdsmdummy;'
Line 78: DEFAULT_MTU = '1500'
Line 79: MAX_BOND_NAME_LENGTH = 15
Maybe I was blind but I could not find a constant to use, maybe it should be
the other way around. The one in vdsm/netmodels.py is a member of the Bridge
class.
Line 80:
Line 81: REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3',
'bond4'))
Line 82:
Line 83: _Qos = namedtuple('Qos', 'inbound outbound')
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7317/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6415/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7199/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 7: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 75:
Line 76: LIBVIRT_NET_PREFIX = 'vdsm-'
Line 77: DUMMY_BRIDGE = ';vdsmdummy;'
Line 78: DEFAULT_MTU = '1500'
Line 79: MAX_BOND_NAME_LENGTH = 15
Maybe I was blind but I could not find a constant to use, maybe it should b
being a class member is not a real problem. but being out of lib/vdsm
directory, is.
Please hide this constant inside the only function that needs to know about it.
Line 80:
Line 81: REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3',
'bond4'))
Line 82:
Line 83: _Qos = namedtuple('Qos', 'inbound outbound')
Line 538: return info
Line 539:
Line 540:
Line 541: def _randomIfaceName():
Line 542: CHARS = string.ascii_lowercase + string.ascii_uppercase
string.digits are valid, too, btw.
Line 543:
Line 544: return ''.join(random.choice(CHARS) for _ in
range(MAX_BOND_NAME_LENGTH))
Line 545:
Line 546:
http://gerrit.ovirt.org/#/c/24456/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1189: 'options': 'mode=4
miimon=9'})
Line 1190:
Line 1191: # Check that only the 'miimon' option is different
from default
Line 1192: opts =
self.vdsm_net.netinfo.bondings[BONDING_NAME]['options']
Line 1193: self.assertEqual(opts, {'miimon': ['9']})
please add an assertion for legacy ['cfg'][BONDING_OPTS]
I believe this can be placed within createBondedNetAndCheck(), so it is
repeatedly used.
Line 1194:
Line 1195: # cleanup
Line 1196: networks = dict((NETWORK_NAME + str(num), {'remove':
True}) for
Line 1197: num in range(5))
http://gerrit.ovirt.org/#/c/24456/7/tests/netinfoTests.py
File tests/netinfoTests.py:
Line 344:
Line 345: with open(BONDING_MASTERS, 'w') as bonds:
Line 346: try:
Line 347: bonds.write('+' + bondName)
Line 348: bonds.flush()
these should be taken out of the try block: -bondName should be written only
if +bondName succeeded.
Line 349:
Line 350: self.assertEqual(_getBondingOptions(bondName), {},
Line 351: 'No options should be returned.')
Line 352:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/24456/7/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 565: def _getBondingOptions(bond): Line 566: defaults = _getDefaultBondingOptions() Line 567: opts = bondOpts(bond) Line 568: Line 569: for key, val in dict(opts).iteritems(): creating a copy and deleting elements from it is a bit cumbersome. Starting with an empty dict and adding non-default elements is simpler. Or verify and consider: return dict((k, v) for (k, v) in opts.iteritems() if v != defaults.get(k)) Line 570: if key in defaults and val == defaults[key]: Line 571: del opts[key] Line 572: Line 573: return opts -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 537: def _getDefaultBondingOptions():
Line 538: teeCmd = _TEE_BINARY.cmd
Line 539:
Line 540: rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541: data='+' + DUMMY_BOND, sudo=True)
normal vdsm user does not have the permissions to run `sudo tee`. You have to
update vdsm.sudoers for that - which is something we do not really want to do.
To avoid that, our alternatives include:
- calling supervdsm. introducing a supervdsm dependency into lib/vdsm is
something a normal library wouldn't do.
- hard-coding the default options. that's my favorite option at the moment,
provided that you add a unit test verifying that the default has not changed.
Line 542: if rc:
Line 543: raise OSError('Creating a reference bond failed: %s.', err)
Line 544:
Line 545: try:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24456/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 537: def _getDefaultBondingOptions():
Line 538: teeCmd = _TEE_BINARY.cmd
Line 539:
Line 540: rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541: data='+' + DUMMY_BOND, sudo=True)
normal vdsm user does not have the permissions to run `sudo tee`. You have
+1 for hard coding with unit test. The only other alternative that I thought
about was that we'd hard code it at compile time but IIRC it is not that
legal in most linux packaging to perform privileged actions like creating and
removing a bond.
You can find the current defaults in the linux source tree in:
drivers/net/bonding/bond_options.c
Note that the defaults are marked by BOND_VALFLAG_DEFAULT.
Line 542: if rc:
Line 543: raise OSError('Creating a reference bond failed: %s.', err)
Line 544:
Line 545: try:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/24456/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 537: def _getDefaultBondingOptions():
Line 538: teeCmd = _TEE_BINARY.cmd
Line 539:
Line 540: rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541: data='+' + DUMMY_BOND, sudo=True)
normal vdsm user does not have the permissions to run `sudo tee`. You have
Written before Toni commented:
[I could exploit dd (which is in vdsm.sudoers) for writing to bonding_masters
but yeah, it sounds like a hack.
Toni ruled out supervdsm as a possibility, we do not want to call it from the
library.
And after communicating with a kernel developer he told me distributions
sometimes modify the default options...]
So let's focus only on the test then. With this approach we have to read all
options to be sure no exotic ones are modified.
Line 542: if rc:
Line 543: raise OSError('Creating a reference bond failed: %s.', err)
Line 544:
Line 545: try:
Line 539:
Line 540: rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541: data='+' + DUMMY_BOND, sudo=True)
Line 542: if rc:
Line 543: raise OSError('Creating a reference bond failed: %s.', err)
the err for OSError shoud be an errno. Generally it would fail due to EEXIS
EEXISTS would mean that a previous instance of VDSM didn't remove the bond, I
think I want to know about this.
Do you mean I could somehow obtain an errno, in addition to a useless return
code and strerror(errno) if I read the command' stderr?
Line 544:
Line 545: try:
Line 546: opts = bondOpts(DUMMY_BOND)
Line 547: finally:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
netinfo: Retrieve bonding options differing from defaults (WIP)
On failure, an empty dictionary is returned.
Tests are yet to be created.
Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
M tests/functional/supervdsmFuncTests.py
M vdsm/supervdsmServer
4 files changed, 53 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/24456/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index dbacb2f..fe48f81 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -41,7 +41,7 @@
from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways
from . import libvirtconnection
from .ipwrapper import linkShowDev
-from .utils import anyFnmatch
+from .utils import anyFnmatch, execCmd, memoized, CommandPath
from .netconfpersistence import RunningConfig
@@ -68,9 +68,11 @@
_BONDING_LOADBALANCE_MODES = frozenset(('0', '2', '4', '5', '6'))
_IFCFG_ZERO_SUFFIXED = frozenset(
('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
+_TEE_BINARY = CommandPath('tee', '/usr/bin/tee')
LIBVIRT_NET_PREFIX = 'vdsm-'
DUMMY_BRIDGE = ';vdsmdummy;'
+DUMMY_BOND = ';vdsmdummybond;'
DEFAULT_MTU = '1500'
REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3', 'bond4'))
@@ -531,9 +533,44 @@
return info
+@memoized
+def _getDefaultBondingOptions():
+teeCmd = _TEE_BINARY.cmd
+
+rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
+ data='+' + DUMMY_BOND, sudo=True)
+if rc:
+raise OSError('Creating a reference bond failed: %s.', err)
+
+try:
+opts = bondOpts(DUMMY_BOND)
+finally:
+rc, _, _ = execCmd([teeCmd, BONDING_MASTERS],
+ data='-' + DUMMY_BOND, sudo=True)
+
+return opts
+
+
+def _getBondingOptions(bond):
+try:
+defaults = _getDefaultBondingOptions()
+opts = bondOpts(bond)
+
+except Exception as e:
+logging.exception('Reading bonding options failed.')
+return {}
+
+for key, val in dict(opts).iteritems():
+if key in defaults and val == defaults[key]:
+del opts[key]
+
+return opts
+
+
def _bondinfo(link):
info = _devinfo(link)
-info.update({'hwaddr': link.address, 'slaves': slaves(link.name)})
+info.update({'hwaddr': link.address, 'slaves': slaves(link.name),
+ 'options': _getBondingOptions(bond)})
return info
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 695a29f..f2a785d 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -41,7 +41,7 @@
from vdsm.utils import RollbackContext
from vdsm.netinfo import (operstate, prefix2netmask, getRouteDeviceTo,
- getDhclientIfaces)
+ getDhclientIfaces, _getBondingOptions)
from vdsm import ipwrapper
from vdsm.utils import pgrep
@@ -1728,3 +1728,9 @@
NOCHK)
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
+
+def testGetBondingOptions(self):
+# TODO: Create a bond with mode and miimon options set and check
+# that no other options are returned.
+
+_getBondingOptions('bond0')
diff --git a/tests/functional/supervdsmFuncTests.py
b/tests/functional/supervdsmFuncTests.py
index 4596306..fa94291 100644
--- a/tests/functional/supervdsmFuncTests.py
+++ b/tests/functional/supervdsmFuncTests.py
@@ -37,3 +37,9 @@
self.dropPrivileges()
proxy = supervdsm.getProxy()
self.assertTrue(proxy.ping())
+
+@testValidation.ValidateRunningAsRoot
+def testDefaultBondingOptions(self):
+proxy = supervdsm.getProxy()
+print proxy.defaultBondingOptions()
+raise Exception()
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 21351c3..ce07dea 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -49,7 +49,7 @@
except ImportError:
_glusterEnabled = False
-from vdsm import utils
+from vdsm import netinfo, utils
from vdsm.tool import restore_nets
from parted_utils import getDevicePartedInfo as _getDevicePartedInfo
from md_utils import getMdDeviceUuidMap as _getMdDeviceUuidMap
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults (WIP) .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7237/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6347/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7131/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults (WIP)
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24456/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 539:
Line 540: rc, _, err = execCmd([teeCmd, BONDING_MASTERS],
Line 541: data='+' + DUMMY_BOND, sudo=True)
Line 542: if rc:
Line 543: raise OSError('Creating a reference bond failed: %s.', err)
the err for OSError shoud be an errno. Generally it would fail due to EEXISTS
or ENOPERM
Line 544:
Line 545: try:
Line 546: opts = bondOpts(DUMMY_BOND)
Line 547: finally:
--
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults (WIP)
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Retrieve bonding options differing from defaults (WIP) .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6349/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7133/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
