Change in vdsm[master]: network: change objectivizeNetwork to private
automat...@ovirt.org has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
automat...@ovirt.org has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Petr Horáček has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Verified+1 Passed unit tests except testHostSampleHandlesDisappearingVlanInterfaces and testHostSampleReportsNewInterface which fail on master too. Passed functional tests except OperStateChangedError on testSetupNetworksAddNetworkToNicAfterBondResizing, it is not related to this patch, failing on master too. -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: change objectivizeNetwork to private .. network: change objectivizeNetwork to private Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Signed-off-by: Petr Horáček phora...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37567 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Ondřej Svoboda osvob...@redhat.com --- M vdsm/network/api.py 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Ondřej Svoboda: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/235/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/612/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/239/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/633/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6458/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Ondřej Svoboda has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Dan Kenigsberg has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14660/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2596/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/438/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Petr Horáček has uploaded a new change for review.
Change subject: network: change objectivizeNetwork to private
..
network: change objectivizeNetwork to private
Change-Id: I0b83081f453cef8de2b698152869c35850a036b3
Signed-off-by: Petr Horáček phora...@redhat.com
---
M vdsm/network/api.py
1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/37567/1
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 0f74f47..6841a62 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -79,13 +79,13 @@
persistence = _getPersistenceModule()
-def objectivizeNetwork(bridge=None, vlan=None, bonding=None,
- bondingOptions=None, nics=None, mtu=None, ipaddr=None,
- netmask=None, gateway=None, bootproto=None,
- ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
- dhcpv6=None, defaultRoute=None, _netinfo=None,
- configurator=None, blockingdhcp=None,
- implicitBonding=None, opts=None):
+def _objectivizeNetwork(bridge=None, vlan=None, bonding=None,
+bondingOptions=None, nics=None, mtu=None, ipaddr=None,
+netmask=None, gateway=None, bootproto=None,
+ipv6addr=None, ipv6gateway=None, ipv6autoconf=None,
+dhcpv6=None, defaultRoute=None, _netinfo=None,
+configurator=None, blockingdhcp=None,
+implicitBonding=None, opts=None):
Constructs an object hierarchy that describes the network configuration
that is passed in the parameters.
@@ -308,7 +308,7 @@
bootproto = options.pop('bootproto', None)
-net_ent = objectivizeNetwork(
+net_ent = _objectivizeNetwork(
bridge=network if bridged else None, vlan=vlan, bonding=bonding,
bondingOptions=bondingOptions, nics=nics, mtu=mtu, ipaddr=ipaddr,
netmask=netmask, gateway=gateway, bootproto=bootproto, dhcpv6=dhcpv6,
@@ -420,11 +420,11 @@
def _delNonVdsmNetwork(network, vlan, bonding, nics, _netinfo, configurator):
if network in netinfo.bridges():
-net_ent = objectivizeNetwork(bridge=network, vlan=vlan,
- bonding=bonding, nics=nics,
- _netinfo=_netinfo,
- configurator=configurator,
- implicitBonding=False)
+net_ent = _objectivizeNetwork(bridge=network, vlan=vlan,
+ bonding=bonding, nics=nics,
+ _netinfo=_netinfo,
+ configurator=configurator,
+ implicitBonding=False)
net_ent.remove()
else:
raise ConfigNetworkError(ne.ERR_BAD_BRIDGE, Cannot delete network
@@ -475,10 +475,10 @@
if not utils.tobool(force):
_validateDelNetwork(network, vlan, bonding, nics, bridged, _netinfo)
-net_ent = objectivizeNetwork(bridge=network if bridged else None,
- vlan=vlan, bonding=bonding, nics=nics,
- _netinfo=_netinfo, configurator=configurator,
- implicitBonding=implicitBonding)
+net_ent = _objectivizeNetwork(bridge=network if bridged else None,
+ vlan=vlan, bonding=bonding, nics=nics,
+ _netinfo=_netinfo, configurator=configurator,
+ implicitBonding=implicitBonding)
net_ent.ip.bootproto = ('dhcp' if _netinfo.networks[network]['dhcpv4']
else 'none')
--
To view, visit http://gerrit.ovirt.org/37567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
