Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: persist sriov devices number of vfs .. network: persist sriov devices number of vfs vdsm-restore-net-config will attempt to restore the number of vfs from the last successful change. This is done before network restoration so that networks can be configured based on the restored vfs. Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Signed-off-by: Ido Barkan ibar...@redhat.com Reviewed-on: https://gerrit.ovirt.org/40088 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/hostdev.py M vdsm/network/api.py M vdsm/supervdsmServer M vdsm/vdsm-restore-net-config 5 files changed, 87 insertions(+), 11 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 28: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 27: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 27: Verified+1 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 25:
(2 comments)
https://gerrit.ovirt.org/#/c/40088/25/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 55: def _get_persisted_numvfs(existing_sriov_devices):
Line 56: numvfs_by_device = {}
Line 57:
Line 58: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 59: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
this directory should be created when we persist a running config, right? I
Done
Line 60: return numvfs_by_device
Line 61:
Line 62: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 63: if file_name not in existing_sriov_devices:
Line 60: return numvfs_by_device
Line 61:
Line 62: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 63: if file_name not in existing_sriov_devices:
Line 64: logging.error('Phisycal device in %s no longer exists.
Skipping '
actually, the former spelling (Physical) is the correct one.
Done
Line 65: 'numvfs restoration.', file_name)
Line 66: else:
Line 67: with open(os.path.join(
Line 68: _VIRTUAL_FUNCTIONS_PATH, file_name)) as f:
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 26: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40088/26/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 53:
Line 54:
Line 55: def _get_persisted_numvfs(existing_sriov_devices):
Line 56: numvfs_by_device = {}
Line 57: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
but there *is* a case where _VIRTUAL_FUNCTIONS_PATH is missing (e.g. after
upgrade).
I believe you should check for its existence first and return the empty dir.
the former code was right - it simlply did not need to create the directory.
if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
return numvfs_by_device
Line 58: if file_name not in existing_sriov_devices:
Line 59: logging.error('Phisycal device in %s no longer exists.
Skipping '
Line 60: 'numvfs restoration.', file_name)
Line 61: else:
Line 59: Phisycal
spelling: Physical
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 26: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 25:
(3 comments)
https://gerrit.ovirt.org/#/c/40088/25/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 55: def _get_persisted_numvfs(existing_sriov_devices):
Line 56: numvfs_by_device = {}
Line 57:
Line 58: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 59: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
I don't see why creating the path on the makefile (and including it in the rpm)
is yuckie.
But if it is ruled out, how about creating the directory when attempting to
persist to it?
Line 60: return numvfs_by_device
Line 61:
Line 62: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 63: if file_name not in existing_sriov_devices:
Line 60: return numvfs_by_device
Line 61:
Line 62: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 63: if file_name not in existing_sriov_devices:
Line 64: logging.error('Phisycal device in %s no longer exists.
Skipping '
actually, the former spelling (Physical) is the correct one.
Line 65: 'numvfs restoration.', file_name)
Line 66: else:
Line 67: with open(os.path.join(
Line 68: _VIRTUAL_FUNCTIONS_PATH, file_name)) as f:
Line 77:
Line 78: for device in sriov_devices:
Line 79: desired_numvfs = persisted_numvfs.get(device)
Line 80: if desired_numvfs is None:
Line 81: logging.info('SRIOV network device which is not persisted
found '
ok, let's be paranoid
Line 82: 'at: %s.', device)
Line 83: else:
Line 84: logging.info('Changing number of virtual functions for
device %s '
Line 85: '- %s', device, desired_numvfs)
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 25: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40088/25/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 55: def _get_persisted_numvfs(existing_sriov_devices):
Line 56: numvfs_by_device = {}
Line 57:
Line 58: if not os.path.exists(_VIRTUAL_FUNCTIONS_PATH):
Line 59: os.makedirs(_VIRTUAL_FUNCTIONS_PATH)
I don't see why creating the path on the makefile (and including it in the
this directory should be created when we persist a running config, right? If
it's not there - it's understandable. I don't see why we need to create it here
at all.
Line 60: return numvfs_by_device
Line 61:
Line 62: for file_name in os.listdir(_VIRTUAL_FUNCTIONS_PATH):
Line 63: if file_name not in existing_sriov_devices:
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 25: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 22: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 22: Verified+1 tested that the proper values (number of vfs) are written into proper places and that those are indeed persisted upon setSafeNetworkConfig and restored during reboot. -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 23: Verified+1 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 23: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 20: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 19: Verified+1 -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 19: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Ido Barkan has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 18:
(5 comments)
https://gerrit.ovirt.org/#/c/40088/18/vdsm/network/api.py
File vdsm/network/api.py:
Line 557: stored. A call to setSafeNetworkConfig() will persist it across
reboots.
Line 558: Garbage is collected during network restoration.
Line 559:
Line 560: logger = logging.getLogger(change_numvfs)
Line 561: logger.info(changing number of vfs on device %s - %s.,
there is no much use for this getLogger - it has no real context or special
Done
Line 562: device_name, numvfs)
Line 563: _update_numvfs(device_name, numvfs)
Line 564:
Line 565: logger.info(changing number of vfs on device %s - %s.
succeeded.,
https://gerrit.ovirt.org/#/c/40088/18/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 27:
Line 28: from vdsm.config import config
Line 29: from vdsm import netinfo
Line 30: from vdsm import utils
Line 31: from vdsm.constants import P_VDSM_RUN, P_VDSM_LIB
please pull constant from vdsm.netconfpersist - constants is just a pile
P_VDSM_RUN_NETCONF was the one I added, and now it is declared only in
vdsm.netconfpersistance.py
Line 32: import hostdev
Line 33:
Line 34: # Ifcfg persistence restoration
Line 35: from network.configurators import ifcfg
Line 64: missing_devices.append(file_name)
Line 65: else:
Line 66: with open(os.path.join(
Line 67: _VIRTUAL_FUNCTIONS_PATH, file_name)) as f:
Line 68: numvfs_by_device[file_name] = int(f.read().strip())
let's use the same kind of semantics: if one PF failed, let us skip it.
Done
Line 69:
Line 70: return numvfs_by_device, missing_devices
Line 71:
Line 72:
Line 73: def _garbage_collect_devices_persistence(missing_devices):
Line 74: for file_name in missing_devices:
Line 75: path_to_remove = os.path.join(_VIRTUAL_FUNCTIONS_PATH,
file_name)
Line 76: logging.debug('Removing %s. Device no longer exists.',
path_to_remove)
Line 77: utils.rmFile(path_to_remove)
here too - let us just skip the missing VFs, log the fact (as an ERROR), bu
So this function should not be called ever.
Line 78:
Line 79:
Line 80: def _restore_sriov_numvfs():
Line 81: sriov_devices = _get_sriov_devices()
Line 107: Builds a setupNetworks command from the persistent configuration
to set it
Line 108: as running configuration.
Line 109:
Line 110: _restore_sriov_numvfs()
Line 111:
how come pep8 did not bite?
removed
Line 112: _remove_networks_in_running_config()
Line 113:
Line 114: _flush_configurators_leftovers()
Line 115:
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
Dan Kenigsberg has posted comments on this change.
Change subject: network: persist sriov devices number of vfs
..
Patch Set 18: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/40088/18/vdsm/network/api.py
File vdsm/network/api.py:
Line 557: stored. A call to setSafeNetworkConfig() will persist it across
reboots.
Line 558: Garbage is collected during network restoration.
Line 559:
Line 560: logger = logging.getLogger(change_numvfs)
Line 561: logger.info(changing number of vfs on device %s - %s.,
there is no much use for this getLogger - it has no real context or special
handlers.
let's use
logging.info('bla')
Line 562: device_name, numvfs)
Line 563: _update_numvfs(device_name, numvfs)
Line 564:
Line 565: logger.info(changing number of vfs on device %s - %s.
succeeded.,
https://gerrit.ovirt.org/#/c/40088/18/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 27:
Line 28: from vdsm.config import config
Line 29: from vdsm import netinfo
Line 30: from vdsm import utils
Line 31: from vdsm.constants import P_VDSM_RUN, P_VDSM_LIB
please pull constant from vdsm.netconfpersist - constants is just a pile of
unrelated junk.
Line 32: import hostdev
Line 33:
Line 34: # Ifcfg persistence restoration
Line 35: from network.configurators import ifcfg
Line 64: missing_devices.append(file_name)
Line 65: else:
Line 66: with open(os.path.join(
Line 67: _VIRTUAL_FUNCTIONS_PATH, file_name)) as f:
Line 68: numvfs_by_device[file_name] = int(f.read().strip())
let's use the same kind of semantics: if one PF failed, let us skip it.
Line 69:
Line 70: return numvfs_by_device, missing_devices
Line 71:
Line 72:
Line 73: def _garbage_collect_devices_persistence(missing_devices):
Line 74: for file_name in missing_devices:
Line 75: path_to_remove = os.path.join(_VIRTUAL_FUNCTIONS_PATH,
file_name)
Line 76: logging.debug('Removing %s. Device no longer exists.',
path_to_remove)
Line 77: utils.rmFile(path_to_remove)
here too - let us just skip the missing VFs, log the fact (as an ERROR), but
keep them available for next boot.
Line 78:
Line 79:
Line 80: def _restore_sriov_numvfs():
Line 81: sriov_devices = _get_sriov_devices()
Line 107: Builds a setupNetworks command from the persistent configuration
to set it
Line 108: as running configuration.
Line 109:
Line 110: _restore_sriov_numvfs()
Line 111:
how come pep8 did not bite?
Line 112: _remove_networks_in_running_config()
Line 113:
Line 114: _flush_configurators_leftovers()
Line 115:
--
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: persist sriov devices number of vfs
automat...@ovirt.org has posted comments on this change. Change subject: network: persist sriov devices number of vfs .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
