Change in vdsm[master]: network: publish and honor blockingdhcp setting
Antoni Segura Puimedon has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 6: Verified+1 Verified by running all the functional tests (including the new one from this patch: tonif2001 tests (5a4de6f) # ./run_tests_local.sh -x functional/networkTests.py nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$'] NetworkTest testAddDelBondedNetwork(kwargs=False) OK testAddDelBondedNetwork(kwargs=True)OK testAddDelNetwork(kwargs=False) OK testAddDelNetwork(kwargs=True) OK testAddNetworkBondWithManyVlans(kwargs=False) OK testAddNetworkBondWithManyVlans(kwargs=True)OK testAddNetworkManyVlans(kwargs=False) OK testAddNetworkManyVlans(kwargs=True)OK testAddNetworkVlan(kwargs=False)OK testAddNetworkVlan(kwargs=True) OK testAddNetworkVlanBond(kwargs=False)OK testAddNetworkVlanBond(kwargs=True) OK testAddVlanedBridgeless OK testAddVlanedBridgeless_oneCommand OK testAfterNetworkSetupHook OK testBeforeNetworkSetupHook OK testBondHwAddress(kwargs=False) OK testBondHwAddress(kwargs=True) OK testBrokenBridgelessNetReplacement OK testDelNetworkBondAccumulation OK testDelNetworkWithMTU(kwargs=False) OK testDelNetworkWithMTU(kwargs=True) OK testDelWithoutAdd(kwargs=False) OK testDelWithoutAdd(kwargs=True) OK testDhclientLeases(kwargs='default')SKIP : No firewall service detected. testDhclientLeases(kwargs='local') SKIP : No firewall service detected. testEditWithoutAdd(kwargs=False)OK testEditWithoutAdd(kwargs=True) OK testFailWithInvalidBondingName(kwargs=False)OK testFailWithInvalidBondingName(kwargs=True) OK testFailWithInvalidBridgeName OK testFailWithInvalidIpConfig OK testFailWithInvalidNic(kwargs=False)OK testFailWithInvalidNic(kwargs=True) OK testFailWithInvalidParams(kwargs=False) OK testFailWithInvalidParams(kwargs=True) OK testGetRouteDeviceToOK testHonorBlockingDhcp OK testIPv6ConfigNetwork OK testIpLinkWrapper OK testLowerMtuDoesNotOverride OK testNoBridgeLeftovers OK testQosNetwork OK testRouteExists OK testRuleExists OK testSafeNetworkConfig(kwargs=False) OK testSafeNetworkConfig(kwargs=True) OK testSetupNetworksAddBadParams(bridged=False)OK testSetupNetworksAddBadParams(bridged=True) OK testSetupNetworksAddBondWithManyVlans(kwargs=False) OK testSetupNetworksAddBondWithManyVlans(kwargs=True) OK testSetupNetworksAddDelBondedNetwork(kwargs=False) OK testSetupNetworksAddDelBondedNetwork(kwargs=True) OK testSetupNetworksAddDelDhcp(kwargs=False) SKIP : No firewall service detected. testSetupNetworksAddDelDhcp(kwargs=True)SKIP : No firewall service detected. testSetupNetworksAddManyVlans(kwargs=False) OK testSetupNetworksAddManyVlans(kwargs=True) OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondBreaking(kwargs=True)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=False)OK testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True)OK
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 6: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1413/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8488/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 6: Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1414/ : The patch does not pass the network functional tests -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Antoni Segura Puimedon has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 8: Verified+1 Fixed the two tests that failed in the previous run: tonif2001 tests (5a4de6f*) # NOSE_TESTMATCH=testSetupNetworksAddDelDhcp ./run_tests_local.sh -x functional/networkTests.py nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$'] NetworkTest testSetupNetworksAddDelDhcp(kwargs=False) OK testSetupNetworksAddDelDhcp(kwargs=True)OK -- Ran 2 tests in 14.389s OK tonif2001 tests (5a4de6f*) # -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change.
Change subject: network: publish and honor blockingdhcp setting
..
Patch Set 8: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/28048/8/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1806: veth.setLinkUp(left)
Line 1807: with dnsmasqDhcp(left):
Line 1808: network = {NETWORK_NAME: {'nic': right, 'bridged':
bridged,
Line 1809: 'bootproto': 'dhcp',
Line 1810: 'blockingdhcp': True}}
oh dear
Line 1811:
Line 1812: status, msg = self.vdsm_net.setupNetworks(network,
{}, NOCHK)
Line 1813: self.assertEqual(status, SUCCESS, msg)
Line 1814: self.assertNetworkExists(NETWORK_NAME)
--
To view, visit http://gerrit.ovirt.org/28048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: publish and honor blockingdhcp setting .. network: publish and honor blockingdhcp setting blockingdhcp is an old unpublished network option that allows the user to specify that the network configuring should wait for the result of upping a dhcp configured interface. When moving to the packed (as oposed to unpacked, i.e., **opts) options for objectivizeNetworks, this option stopped reaching the network models, and thus, stopped being applied. This patch re-enables blockingdhcp, publishing it in the API so that we continue to honor it. Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28048 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py M vdsm/network/api.py M vdsm/network/models.py M vdsm_api/vdsmapi-schema.json 4 files changed, 23 insertions(+), 7 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1358/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1415/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9446/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8515/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1416/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9304/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9447/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8516/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 5: Verified-1 I cannot guess why, however: 19:58:49 FAIL: testHonorBlockingDhcp (networkTests.NetworkTest) -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: network: publish and honor blockingdhcp setting
..
network: publish and honor blockingdhcp setting
blockingdhcp is an old unpublished network option that allows the
user to specify that the network configuring should wait for the
result of upping a dhcp configured interface. When moving to the
packed (as oposed to unpacked, i.e., **opts) options for
objectivizeNetworks, this option stopped reaching the network
models, and thus, stopped being applied.
This patch re-enables blockingdhcp, publishing it in the API so
that we continue to honor it.
Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/network/api.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/28048/1
diff --git a/vdsm/network/api.py b/vdsm/network/api.py
index 5e2399e..281d831 100755
--- a/vdsm/network/api.py
+++ b/vdsm/network/api.py
@@ -301,14 +301,15 @@
configurator = ConfiguratorClass()
bootproto = options.pop('bootproto', None)
+blockingdhcp = options.pop('blockingdhcp', None)
netEnt = objectivizeNetwork(
bridge=network if bridged else None, vlan=vlan, bonding=bonding,
bondingOptions=bondingOptions, nics=nics, mtu=mtu, ipaddr=ipaddr,
netmask=netmask, gateway=gateway, bootproto=bootproto,
-ipv6addr=ipv6addr, ipv6gateway=ipv6gateway, ipv6autoconf=ipv6autoconf,
-defaultRoute=defaultRoute, _netinfo=_netinfo,
-configurator=configurator, opts=options)
+blockingdhcp=blockingdhcp, ipv6addr=ipv6addr, ipv6gateway=ipv6gateway,
+ipv6autoconf=ipv6autoconf, defaultRoute=defaultRoute,
+_netinfo=_netinfo, configurator=configurator, opts=options)
netEnt.configure(**options)
configurator.configureLibvirtNetwork(network, netEnt,
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 50b1a3f..554d9f8 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -57,6 +57,10 @@
# @bootproto: #optional Interface autoconfiguration protocol (typically
# 'dhcp' or 'static')
#
+# @blockingdhcp:#optional whether ifaces that have 'dhcp' as bootproto
+# should wait to get an address before returning creation
+# success
+#
# @bondingOptions: #optional A string of space-separated option=value
pairs
#
# @qosInbound: #optional BandwidthParams for incoming traffic.
--
To view, visit http://gerrit.ovirt.org/28048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1389/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9207/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9350/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8419/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change.
Change subject: network: publish and honor blockingdhcp setting
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28048/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 300: if configurator is None:
Line 301: configurator = ConfiguratorClass()
Line 302:
Line 303: bootproto = options.pop('bootproto', None)
Line 304: blockingdhcp = options.pop('blockingdhcp', None)
Why should we have a tristate here (True/False/None)? Booleans with a default
are nicer.
Line 305:
Line 306: netEnt = objectivizeNetwork(
Line 307: bridge=network if bridged else None, vlan=vlan,
bonding=bonding,
Line 308: bondingOptions=bondingOptions, nics=nics, mtu=mtu,
ipaddr=ipaddr,
http://gerrit.ovirt.org/#/c/28048/1/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 58: # 'dhcp' or 'static')
Line 59: #
Line 60: # @blockingdhcp:#optional whether ifaces that have 'dhcp' as
bootproto
Line 61: # should wait to get an address before returning
creation
Line 62: # success
Please state the awkward default (False).
(
I hate this option, I hate its default, and I hate it that we need to carry it
along...)
Line 63: #
Line 64: # @bondingOptions: #optional A string of space-separated
option=value pairs
Line 65: #
Line 66: # @qosInbound: #optional BandwidthParams for incoming traffic.
--
To view, visit http://gerrit.ovirt.org/28048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 1: Please add a functional test so this issue would not repeat (defining a dhcp network over a dummy iface, and making sure it does not block) -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1397/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9365/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8434/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1398/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9366/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8435/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
Dan Kenigsberg has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 3: Code-Review-1 Please add a functional test so this issue would not repeat (defining a dhcp network over a dummy iface, and making sure it does not block) -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1405/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9374/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8443/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: publish and honor blockingdhcp setting
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: publish and honor blockingdhcp setting .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1410/ : The patch does not pass the network functional tests http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9379/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8448/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20bdf848dd0ace8d958a1665b3a54b3c18c9b23 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
