Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-13 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


networkTests: give an instructory message when an address could not be added

On recent Fedoras and EL7 NetworkManager sets the sysctl property disable_ipv6
on some interfaces (including veths) silently, as a workaround to IPv6LL
(link-local address) assignment clash between NM and the kernel, see e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=1102064

In the next commits this problem will be addressed by telling NM to unmanage
our veth pairs and dummy devices.

Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/37699
Reviewed-by: Ido Barkan ibar...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M tests/functional/dummy.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Ondřej Svoboda: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-13 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/637/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/236/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4620/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/613/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/240/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/638/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/240/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/227/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/634/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6459/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15580/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14778/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15749/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2625/ 
: There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/556/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-11 Thread osvoboda
Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 1: Verified+1

Skipped tests (all of testDhclientLeases and testSetupNetworksAddDelDhcp 
instances) now inform that:

SKIP : Failed to add the IPv6 address fdb3:84e5:4ff4:55e3::1/64 to device 
veth_xrSWAagFYW: ['RTNETLINK answers: Permission denied']; NetworkManager may 
have set the sysctl disable_ipv6 flag on the device, please see e.g. RH BZ 
#1102064

testSetupNetworksOverDhcpIface and testSetupNetworksReconfigureBridge do not 
currently add an IPv6 address and are thus unaffected.

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-11 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review.

Change subject: networkTests: give an instructory message when an address could 
not be added
..

networkTests: give an instructory message when an address could not be added

On recent Fedoras and EL7 NetworkManager sets the sysctl property disable_ipv6
on some interfaces (including veths) silently, as a workaround to IPv6LL
(link-local address) assignment clash between NM and the kernel, see e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=1102064

In the next commits this problem will be addressed by telling NM to unmanage
our veth pairs and dummy devices.

Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M tests/functional/dummy.py
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/37699/1

diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index 92ce563..f036784 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -54,7 +54,12 @@
 try:
 addrAdd(dummyName, ipaddr, netmask, family)
 except IPRoute2Error as e:
-raise SkipTest('Failed to set device ip: %s' % e)
+message = ('Failed to add the IPv%s address %s/%s to device %s: %s'
+   % (family, ipaddr, netmask, dummyName, e))
+if family == 6:
+message += ('; NetworkManager may have set the sysctl disable_ipv6'
+' flag on the device, please see e.g. RH BZ #1102064')
+raise SkipTest(message)
 
 
 def setLinkUp(dummyName):


-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: networkTests: give an instructory message when an address co...

2015-02-11 Thread ibarkan
Ido Barkan has posted comments on this change.

Change subject: networkTests: give an instructory message when an address could 
not be added
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches