Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has uploaded a new change for review. Change subject: new vdsm config to output libvirtd log to file .. new vdsm config to output libvirtd log to file Having the config value libvirt_log_file=True will add to libvirtd.conf the field log_outputs=1:file:/var/log/libvirt/libvirtd.log. otherwise libvirtd uses the default output which is currently only to syslog. Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Signed-off-by: Yaniv Bronhaim --- M lib/vdsm/config.py.in M lib/vdsm/tool/configurators/libvirt.py 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/41395/1 diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in index 03a63c8..ca8517b 100644 --- a/lib/vdsm/config.py.in +++ b/lib/vdsm/config.py.in @@ -160,6 +160,10 @@ ('ssl', 'true', 'Whether to use ssl encryption and authentication.'), +('libvirt_log_file', 'False', +'True to print libvirtd logs to /var/log/libvirt/libvirtd.log.' +'False will uses the service default.'), + ('vds_responsiveness_timeout', '60', None), ('vdsm_nice', '-5', None), diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py index e182231..891b188 100644 --- a/lib/vdsm/tool/configurators/libvirt.py +++ b/lib/vdsm/tool/configurators/libvirt.py @@ -72,6 +72,7 @@ config.read(_getFile('VDSM_CONF')) vdsmConfiguration = { 'ssl_enabled': config.getboolean('vars', 'ssl'), +'log_to_file': config.getboolen('vars', 'libvirt_log_file'), 'sanlock_enabled': constants.SANLOCK_ENABLED, 'libvirt_selinux': constants.LIBVIRT_SELINUX } @@ -343,6 +344,14 @@ }, }, +{ +'conditions': { +"log_to_file": True, +}, +'content': { +'log_outputs': '1:file:/var/log/libvirt/libvirtd.log', +}, +}, ] }, -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Dan Kenigsberg has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41395/2/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 71: Line 72: config.read(_getFile('VDSM_CONF')) Line 73: vdsmConfiguration = { Line 74: 'ssl_enabled': config.getboolean('vars', 'ssl'), Line 75: 'log_to_file': config.getboolean('vars', 'libvirt_log_file'), I see no use case for having this configured in vdsm.conf. This little feature (of configuring verbose libvirt logging) was requested by QE personal. all they need is vdsm-tool configure --module libvirt --verbose Line 76: 'sanlock_enabled': constants.SANLOCK_ENABLED, Line 77: 'libvirt_selinux': constants.LIBVIRT_SELINUX Line 78: } Line 79: -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: this patch on hold for now - currently I don't pass parameters to the module configure verb and having --verbos flags will make the configure verb very confusing - only libvirt has this flag? how the rest of the configurators should act with this flag? this a bit weird. and I guess that if we will introduce this flag everyone will use it - so why not to leave the debug log the default as we did before falling to libvirt default? -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: I start to feel like we (vdsm) should return the config for full libvirtd debug log to a file. we got too many problems to understand libvirtd crashed with it recently . please let me know your opinion -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
automat...@ovirt.org has posted comments on this change. Change subject: new vdsm config to output libvirtd log to file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: new vdsm config to output libvirtd log to file
Yaniv Bronhaim has abandoned this change. Change subject: new vdsm config to output libvirtd log to file .. Abandoned for now I abandon this work - I don't see the benefit here for the long run. its only one liner change in livbirtd.conf file that can be added manually -- To view, visit https://gerrit.ovirt.org/41395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iaa9c47273b134cf102dfe85dcb628619c1de53b5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches