Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-29 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 9: Code-Review+2

yes, it's nicer this way.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-29 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


packaging: rename supervdsmServer.py to supervdsmServer and add environment file

supervdsm process is started by "python supervdsmServer.pyc". This is a
bit verbose when it is put in the SysV init script and SystemD service
unit. This patch renames supervdsmServer.py to supervdsmServer to enable
the init script start supervdsmServer directly.

In this patch, an environment file is also add for supervdsmd service.

Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Signed-off-by: Zhou Zheng Sheng 
Reviewed-on: http://gerrit.ovirt.org/17100
Reviewed-by: Alon Bar-Lev 
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
M vdsm/Makefile.am
R vdsm/supervdsmServer
M vdsm/supervdsmd.init.in
M vdsm/supervdsmd.service.in
5 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Verified



-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-26 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 9: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 9: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 9: Verified+1

Parent updated, rebase and solve confilcts. Test on RHEL6, Fedora and Ubuntu.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-23 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 9:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4109/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3214/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4030/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-17 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 8: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-16 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 8: Verified+1

The parent patch has been changed, so rebase this patch too. The patch itself 
has no changes. Thanks reviewers.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-16 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3967/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3884/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3078/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-15 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 7:

(1 comment)


File vdsm/supervdsmd.service.in
Line 3: Requires=libvirtd.service
Line 4: 
Line 5: [Service]
Line 6: Type=simple
Line 7: EnvironmentFile=-/etc/sysconfig/supervdsmd
to be able to specify environment, and we do not install it, it is optional.
Line 8: ExecStart=@VDSMDIR@/daemonAdapter "@VDSMDIR@/supervdsmServer" 
--sockfile "@VDSMRUNDIR@/svdsm.sock"


-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 7:

(1 comment)


File vdsm/supervdsmd.service.in
Line 3: Requires=libvirtd.service
Line 4: 
Line 5: [Service]
Line 6: Type=simple
Line 7: EnvironmentFile=-/etc/sysconfig/supervdsmd
why do we need EnvironmentFile and where do we install it\use it?
Line 8: ExecStart=@VDSMDIR@/daemonAdapter "@VDSMDIR@/supervdsmServer" 
--sockfile "@VDSMRUNDIR@/svdsm.sock"


-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 7: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3928/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3845/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3039/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 6: Verified+1

The parent is changed, so this one is rebased and I solve the conflicts. No 
other changes.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-14 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3921/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3838/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3032/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-13 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3891/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3808/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3002/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-13 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 5: Verified+1

Rebase the patch because the parent and the upstream are changed, solve the 
conflicts and test on RHEL, Fedora and Ubuntu.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-08 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 4: Verified+1

Test on Fedora, RHEL and Ubuntu. 

The new patch set is rebased to master, and I solve the conflicts due tom 
changes in latest master. No other changes.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-08-07 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3805/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3722/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2914/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-26 Thread Gerrit Code Review 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2710/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3517/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3601/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-26 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 3: Verified

The parent patch is rebased to the latest master and solved some conflicts, so 
this patch is rebased too. Test on Fedora and RHEL.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-21 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 2: Verified

Test on Fedora and RHEL.

The new version of parent patch calls daemon adapter directly, instead of 
calling it with "python daemonAdpater", so this patch has to be rebased. There 
are no other changes.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-21 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 1: (1 inline comment)


File vdsm/supervdsmd.service.in
Line 3: 
Line 4: [Service]
Line 5: Type=simple
Line 6: EnvironmentFile=-/etc/sysconfig/supervdsmd
Line 7: ExecStart=@PYTHON@ "@VDSMDIR@/daemonAdapter" 
"@VDSMDIR@/supervdsmServer" --sockfile "@VDSMRUNDIR@/svdsm.sock"
Thanks. I find the first @PYTHON@ is from the parent patch. I'll fix this 
problem in its parent.


-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-21 Thread Gerrit Code Review 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2597/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3404/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3488/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-19 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 1: (1 inline comment)


File vdsm/supervdsmd.service.in
Line 3: 
Line 4: [Service]
Line 5: Type=simple
Line 6: EnvironmentFile=-/etc/sysconfig/supervdsmd
Line 7: ExecStart=@PYTHON@ "@VDSMDIR@/daemonAdapter" 
"@VDSMDIR@/supervdsmServer" --sockfile "@VDSMRUNDIR@/svdsm.sock"
why do you need PYTHON here?


-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Alon Bar-Lev 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-19 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 1: Verified

Test on Fedora and RHEL.

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-19 Thread Gerrit Code Review 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2579/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3386/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3470/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: packaging: rename supervdsmServer.py to supervdsmServer and ...

2013-07-19 Thread zhshzhou 
Zhou Zheng Sheng has uploaded a new change for review.

Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add 
environment file
..

packaging: rename supervdsmServer.py to supervdsmServer and add environment file

supervdsm process is started by "python supervdsmServer.pyc". This is a
bit verbose when it is put in the SysV init script and SystemD service
unit. This patch renames supervdsmServer.py to supervdsmServer to enable
the init script start supervdsmServer directly.

In this patch, an environment file is also add for supervdsmd service.

Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Signed-off-by: Zhou Zheng Sheng 
---
M vdsm.spec.in
M vdsm/Makefile.am
R vdsm/supervdsmServer
M vdsm/supervdsmd.init.in
M vdsm/supervdsmd.service.in
5 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/17100/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0af0680..2de2ed8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -826,7 +826,7 @@
 %{_datadir}/%{vdsm_name}/sourceRoute.py*
 %{_datadir}/%{vdsm_name}/sourceRouteThread.py*
 %{_datadir}/%{vdsm_name}/supervdsm.py*
-%{_datadir}/%{vdsm_name}/supervdsmServer.py*
+%{_datadir}/%{vdsm_name}/supervdsmServer
 %{_datadir}/%{vdsm_name}/vmChannels.py*
 %{_datadir}/%{vdsm_name}/tc.py*
 %{_datadir}/%{vdsm_name}/vdsm
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index eba50f1..ba403da 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -49,7 +49,6 @@
sourceRoute.py \
sourceRouteThread.py \
supervdsm.py \
-   supervdsmServer.py \
tc.py \
vdsmDebugPlugin.py \
vmChannels.py \
@@ -95,6 +94,7 @@
get-conf-item \
respawn \
set-conf-item \
+   supervdsmServer \
vdsm \
vdsm-restore-net-config \
$(NULL)
diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer
similarity index 99%
rename from vdsm/supervdsmServer.py
rename to vdsm/supervdsmServer
old mode 100644
new mode 100755
index 64becaf..318b403
--- a/vdsm/supervdsmServer.py
+++ b/vdsm/supervdsmServer
@@ -1,3 +1,4 @@
+#!/usr/bin/python
 # Copyright 2011 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
diff --git a/vdsm/supervdsmd.init.in b/vdsm/supervdsmd.init.in
index 388e1cb..605ef57 100755
--- a/vdsm/supervdsmd.init.in
+++ b/vdsm/supervdsmd.init.in
@@ -18,12 +18,13 @@
 # Short-Description: init script for the Super VDS management server
 ### END INIT INFO
 
-SUPERVDSM_BIN=@VDSMDIR@/supervdsmServer.pyc
+SUPERVDSM_BIN=@VDSMDIR@/supervdsmServer
 PIDFILE=@VDSMRUNDIR@/supervdsmd.pid
 RESPAWNPIDFILE=@VDSMRUNDIR@/supervdsm_respawn.pid
 SOCKFILE=@VDSMRUNDIR@/svdsm.sock
 prog=supervdsm
 
+[ -f /etc/sysconfig/supervdsmd ] && . /etc/sysconfig/supervdsmd
 . /etc/init.d/functions
 
 log_failure_msg() { echo -n "$@"; failure "$@"; echo; }
@@ -36,8 +37,7 @@
 
 "@VDSMDIR@/daemonAdapter" -c /dev/null "@VDSMDIR@/respawn" \
 --minlifetime 10 --daemon --masterpid "${RESPAWNPIDFILE}" \
-"@PYTHON@" "${SUPERVDSM_BIN}" --sockfile "${SOCKFILE}" \
---pidfile "${PIDFILE}"
+"${SUPERVDSM_BIN}" --sockfile "${SOCKFILE}" --pidfile "${PIDFILE}"
 RETVAL=$?
 [ "$RETVAL" -eq 0 ] && log_success_msg "$prog start" || 
log_failure_msg "$prog start"
 }
diff --git a/vdsm/supervdsmd.service.in b/vdsm/supervdsmd.service.in
index 32a7a2b..33e960b 100644
--- a/vdsm/supervdsmd.service.in
+++ b/vdsm/supervdsmd.service.in
@@ -3,5 +3,6 @@
 
 [Service]
 Type=simple
-ExecStart=@PYTHON@ "@VDSMDIR@/daemonAdapter" "@PYTHON@" 
"@VDSMDIR@/supervdsmServer.pyc" --sockfile "@VDSMRUNDIR@/svdsm.sock"
+EnvironmentFile=-/etc/sysconfig/supervdsmd
+ExecStart=@PYTHON@ "@VDSMDIR@/daemonAdapter" "@VDSMDIR@/supervdsmServer" 
--sockfile "@VDSMRUNDIR@/svdsm.sock"
 Restart=on-abort


-- 
To view, visit http://gerrit.ovirt.org/17100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbcfcfb6f22040d038541c79ac4d0e66ac106504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches