Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[dkuznets]

Dima Kuznetsov has uploaded a new change for review.

Change subject: pep8: Fix indentation in supervdsmServer
..

pep8: Fix indentation in supervdsmServer

Fix pep8 issue in supervdsmServer and added its path to PEP8_WHITELIST
to make sure don't oversee other pep8 issues in the file.

Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com
---
M Makefile.am
M vdsm/supervdsmServer
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/27899/1

diff --git a/Makefile.am b/Makefile.am
index d2ac39a..f72576c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -63,6 +63,7 @@
 
 PEP8_WHITELIST = \
vdsm-tool/vdsm-tool \
+   vdsm/supervdsmServer \
$(NULL)
 
 
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index ffcedb8..498517b 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -265,8 +265,8 @@
 @logDecorator
 def appropriateDevice(self, guid, thiefId):
 ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
-rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % (guid,
-   DISKIMAGE_USER, DISKIMAGE_GROUP)
+rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \
+(guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
 with open(ruleFile, w) as rf:
 self.log.debug(Creating rule %s: %r, ruleFile, rule)
 rf.write(rule)


-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9037/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9178/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8249/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[dkuznets]

Dima Kuznetsov has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 1: Verified+1

verified with make check-local

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[asegurap]

Antoni Segura Puimedon has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 265: @logDecorator
Line 266: def appropriateDevice(self, guid, thiefId):
Line 267: ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 268: rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \
Line 269: (guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
For Python files '(' is preferred to escaping '\'. Thus, this could just be:
rule = 'SUMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % (
guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
Line 270: with open(ruleFile, w) as rf:
Line 271: self.log.debug(Creating rule %s: %r, ruleFile, rule)
Line 272: rf.write(rule)
Line 273: 


-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[dkuznets]

Dima Kuznetsov has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 265: @logDecorator
Line 266: def appropriateDevice(self, guid, thiefId):
Line 267: ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 268: rule = 'SYMLINK==mapper/%s, OWNER=%s, GROUP=%s\n' % \
Line 269: (guid, DISKIMAGE_USER, DISKIMAGE_GROUP)
 For Python files '(' is preferred to escaping '\'. Thus, this could just be
Done
Line 270: with open(ruleFile, w) as rf:
Line 271: self.log.debug(Creating rule %s: %r, ruleFile, rule)
Line 272: rf.write(rule)
Line 273: 


-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[asegurap]

Antoni Segura Puimedon has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9048/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9189/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8260/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[dkuznets]

Dima Kuznetsov has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 2: Verified+1

verified with make check-local

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: pep8: Fix indentation in supervdsmServer
..


pep8: Fix indentation in supervdsmServer

Fix pep8 issue in supervdsmServer and added its path to PEP8_WHITELIST
to make sure don't oversee other pep8 issues in the file.

Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/27899
Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M Makefile.am
M vdsm/supervdsmServer
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dima Kuznetsov: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: pep8: Fix indentation in supervdsmServer
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1315/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/27899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6af53e01ce7da4c802d65dac19df87e31d60c7fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches