Change in vdsm[master]: periodic: simplify per_vm_operation
Dan Kenigsberg has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
Dan Kenigsberg has submitted this change and it was merged. Change subject: periodic: simplify per_vm_operation .. periodic: simplify per_vm_operation per_vm_operation was added, as helper, together with _dispatched_operation, for the sake of code readability. However, the usage of a separate function and functools.partial produced the opposite effect. This patch redoes per_vm_operation as private inner function, making it closer to its users and coalescing two separate helpers in one. This also makes the code shorter, so better in at least one objective metric. Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40327 Reviewed-by: Dan Kenigsberg --- M vdsm/virt/periodic.py 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
Francesco Romani has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 6: Verified+1 verified running a patched VDSM and checking that the periodic operations still run (they do): periodic.Scheduler::DEBUG::2015-05-04 15:26:34,856::periodic::182::periodic.Operation::(_step) after 15.00 seconds: VmDispatcher() periodic.Scheduler::DEBUG::2015-05-04 15:26:34,857::periodic::182::periodic.Operation::(_step) after 15.00 seconds: VmDispatcher() periodic.Scheduler::DEBUG::2015-05-04 15:26:34,857::periodic::182::periodic.Operation::(_step) after 15.00 seconds: periodic.Scheduler::DEBUG::2015-05-04 15:26:34,887::periodic::182::periodic.Operation::(_step) after 2.00 seconds: VmDispatcher() JsonRpc (StompReactor)::DEBUG::2015-05-04 15:26:35,115::stompReactor::94::Broker.StompAdapter::(handle_frame) Handling message JsonRpcServer::DEBUG::2015-05-04 15:26:35,116::__init__::482::jsonrpc.JsonRpcServer::(serve_requests) Waiting for request Thread-157::DEBUG::2015-05-04 15:26:35,116::stompReactor::158::yajsonrpc.StompServer::(send) Sending response -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1634/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18403/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 5: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1634/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 5: -Verified Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18403/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18350/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1580/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1580/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18350/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1566/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1566/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18336/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18256/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1486/ : 0 -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1486/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18256/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1475/ : 0 -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1475/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18245/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
Francesco Romani has uploaded a new change for review. Change subject: periodic: simplify per_vm_operation .. periodic: simplify per_vm_operation per_vm_operation was added, as helper, together with _dispatched_operation, for the sake of code readability. However, the usage of a separate function and functools.partial produced the opposite effect. This patch redoes per_vm_operation as private inner function, making it closer to its users and coalescing two separate helpers in one. This also makes the code shorter, so better in at least one objective metric. Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Signed-off-by: Francesco Romani --- M vdsm/virt/periodic.py 1 file changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/40327/1 diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py index fe8bbc8..ef3ae37 100644 --- a/vdsm/virt/periodic.py +++ b/vdsm/virt/periodic.py @@ -22,7 +22,6 @@ code to perform periodic maintenance and bookkeeping of the VMs. """ -import functools import logging import threading @@ -59,18 +58,16 @@ return interval / 2. -def _dispatched_operation(get_vms, func, period): -disp = VmDispatcher(get_vms, _executor, func, _timeout_from(period)) -return Operation(disp, period) - - def start(cif): global _operations _scheduler.start() _executor.start() -per_vm_operation = functools.partial(_dispatched_operation, cif.getVMs) +def per_vm_operation(func, period): +disp = VmDispatcher( +cif.getVMs, _executor, func, _timeout_from(period)) +return Operation(disp, period) _operations = [ # needs dispatching becuse updating the volume stats needs the -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
