Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: python3: fix forgotten python2-ish syntax
..


python3: fix forgotten python2-ish syntax

A print statement and a few old-style octal literal hid in py.in files.
Now `make python3` passes when run after `make`.

Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/40511
Reviewed-by: mooli tayer 
Reviewed-by: Douglas Schilling Landgraf 
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/tool/validate_ovirt_certs.py.in
M vdsm_reg/deployUtil.py.in
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  mooli tayer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-06 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-05 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-05 Thread dougsland 
Douglas Schilling Landgraf has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-05 Thread mtayer 
mooli tayer has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-04 Thread danken 
Dan Kenigsberg has uploaded a new change for review.

Change subject: python3: fix forgotten python2-ish syntax
..

python3: fix forgotten python2-ish syntax

A print statement and a few old-style octal literal hid in py.in files.
Now `make python3` passes when run after `make`.

Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/tool/validate_ovirt_certs.py.in
M vdsm_reg/deployUtil.py.in
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/40511/1

diff --git a/lib/vdsm/tool/validate_ovirt_certs.py.in 
b/lib/vdsm/tool/validate_ovirt_certs.py.in
index ead6f9a..5ac9474 100644
--- a/lib/vdsm/tool/validate_ovirt_certs.py.in
+++ b/lib/vdsm/tool/validate_ovirt_certs.py.in
@@ -54,7 +54,7 @@
 if len(args) > 1:
 raise ExtraArgsError()
 
-print "checking certs.."
+print("checking certs..")
 uid, gid = pwd.getpwnam('vdsm')[2:4]
 if not is_our_cafile(PATH_CACERT):
 for f in os.listdir(PATH_CERT):
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in
index 8901236..2931040 100644
--- a/vdsm_reg/deployUtil.py.in
+++ b/vdsm_reg/deployUtil.py.in
@@ -769,7 +769,7 @@
 if not os.path.exists(P_ROOT_SSH):
 logging.debug("handleSSHKey: creating .ssh dir.")
 try:
-os.mkdir(P_ROOT_SSH, 0700)
+os.mkdir(P_ROOT_SSH, 0o700)
 silentRestoreCon(P_ROOT_SSH)
 except OSError:
 fReturn = False
@@ -785,7 +785,7 @@
 
 if fReturn:
 try:
-os.chmod(P_ROOT_AUTH_KEYS, 0644)
+os.chmod(P_ROOT_AUTH_KEYS, 0o644)
 silentRestoreCon(P_ROOT_AUTH_KEYS)
 except:
 fReturn = False
@@ -1364,11 +1364,11 @@
 # install .pem files
 shutil.copy(cert_pemfile, VDSMCERT)
 os.chown(VDSMCERT, nUID, nGID)
-os.chmod(VDSMCERT, 0444)
+os.chmod(VDSMCERT, 0o444)
 if not os.path.exists(CACERT):
 shutil.copy(ca_pemfile, CACERT)
 os.chown(CACERT, nUID, nGID)
-os.chmod(CACERT, 0444)
+os.chmod(CACERT, 0o444)
 
 if isOvirt():
 # save the certificates
@@ -1384,7 +1384,7 @@
 os.makedirs(SPICEPKIPATH)
 
 os.chown(SPICEPKIPATH, 0, nGID)
-os.chmod(SPICEPKIPATH, 0750)
+os.chmod(SPICEPKIPATH, 0o750)
 
 _linkOrPersist(CACERT, ts + '/libvirt-spice/ca-cert.pem')
 _linkOrPersist(VDSMCERT, ts + '/libvirt-spice/server-cert.pem')
@@ -1462,7 +1462,7 @@
 uUserInfo = pwd.getpwnam(VDSM_USER)
 nUID = uUserInfo.pw_uid
 os.chown(vdsmKey, nUID, nGID)
-os.chmod(vdsmKey, 0440)
+os.chmod(vdsmKey, 0o440)
 
 if isOvirt():
 # save the certificates


-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: python3: fix forgotten python2-ish syntax

2015-05-04 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: python3: fix forgotten python2-ish syntax
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I023f4c727fb5fe1f9ee412a21377c3a08231fee3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches