Change in vdsm[master]: require NetworkManager-config-server

[automation]

gerrit-hooks has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 4:

* #1326798::Update tracker: OK
* Set MODIFIED::bug 1326798#1326798IGNORE, not all related patches are 
closed, check 56146

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: require NetworkManager-config-server
..


require NetworkManager-config-server

Request NetworkManager not to approriate newly-created network devices.
With this configuration on host, vdsm can create bonding and vlan
devices without them taken down by NM.

This patch implictly add NetworkManager as a vdsm requirement, but this
is not a very big deal as NetworkManager is ubiquitous.

Bug-Url: https://bugzilla.redhat.com/1326798
Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/56622
Continuous-Integration: Jenkins CI
Reviewed-by: Fabian Deutsch 
Reviewed-by: Piotr Kliczewski 
Tested-by: Fabian Deutsch 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Fabian Deutsch: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[automation]

gerrit-hooks has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 3:

* #1326798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1326798::OK, public bug
* Check Product::#1326798::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 2: Code-Review+1

Good point. Looks good to me.

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[automation]

gerrit-hooks has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 1:

reloading NM would be taken care of by 
https://gerrit.ovirt.org/#/c/56365/4/vdsm.spec.in@798

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 1: Code-Review-1

Yes, we do need to run systemctl reload NetworkManager to apply these changes.

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[fabiand]

Fabian Deutsch has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 1: Code-Review+1

NM probably needs to be reloaded to pickup the new configuration.

Otherwise: Great!

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[automation]

gerrit-hooks has posted comments on this change.

Change subject: require NetworkManager-config-server
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require NetworkManager-config-server

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: require NetworkManager-config-server
..

require NetworkManager-config-server

Request NetworkManager not to approriate newly-created network devices.
With this configuration on host, vdsm can create bonding and vlan
devices without them taken down by NM.

This patch implictly add NetworkManager as a vdsm requirement, but this
is not a very big deal as NetworkManager is ubiquitous.

Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Signed-off-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/56622/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4095195..8088f49 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -247,6 +247,7 @@
 Requires: libselinux-python
 Requires: %{name}-python = %{version}-%{release}
 Requires: %{name}-hook-vmfex-dev = %{version}-%{release}
+Requires: NetworkManager-config-server
 
 Requires(post): /usr/sbin/saslpasswd2
 


-- 
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22d5a05b3d3d9273adc8301696bac3abed0d046f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches