Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
Saggi Mizrahi has submitted this change and it was merged. Change subject: schema: ConnectionError should be an object not a tuple .. schema: ConnectionError should be an object not a tuple We don't want to try and support a tuple type in the API just to accomodate this use case which would be much more usable as a regular type with 'code' and 'message' members. Convert it. Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Signed-off-by: Adam Litke --- M vdsm_api/vdsmapi-schema.json 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Saggi Mizrahi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
Saggi Mizrahi has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/332/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 4: Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/332/ -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
Adam Litke has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/304/ : ABORTED -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/304/ -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/292/ : FAILURE -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/292/ -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/13/ : FAILURE -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: ConnectionError should be an object not a tuple .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/13/ -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: ConnectionError should be an object not a tuple
Adam Litke has uploaded a new change for review. Change subject: schema: ConnectionError should be an object not a tuple .. schema: ConnectionError should be an object not a tuple We don't want to try and support a tuple type in the API just to accomodate this use case which would be much more usable as a regular type with 'code' and 'message' members. Convert it. Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Signed-off-by: Adam Litke --- M vdsm_api/vdsmapi-schema.json 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/7016/1 -- To view, visit http://gerrit.ovirt.org/7016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac8c639f42f2ecf080aa41878a6050d9bc385ddc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
