Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Francesco Romani has uploaded a new change for review.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
schema: require vmId in {Exited,Running}VmStats
On http://gerrit.ovirt.org/#/c/37694/3 we were reminded
in an harsh way that vmId must always be present in
the Vm.getStats() output.
One of the problems was that the vmId field was injected
the Vm.getStats() output by API.py, and this value was
not documented in the schema.
So, this patches update the schema to reflect the
reality of the Engine's needs.
Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Related-To: https://bugzilla.redhat.com/1191405
Signed-off-by: Francesco Romani
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/37696/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 93b6691..1d919e8 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6433,6 +6433,8 @@
#
# Statistics about a VM that no longer running.
#
+# @vmId: The UUID of the Vm
+#
# @exitCode: Code indicating whether the VM exit was normal or in error
#
# @status: The current VM status
@@ -6446,8 +6448,9 @@
# Since: 4.10.0
##
{'type': 'ExitedVmStats',
- 'data': {'exitCode': 'VmExitCode', 'status': 'VmStatus', 'exitMessage': 'str',
- 'exitReason': 'VmExitReason', '*timeOffset': 'int'}}
+ 'data': {'vmId': 'UUID', 'exitCode': 'VmExitCode', 'status': 'VmStatus',
+ 'exitMessage': 'str', 'exitReason': 'VmExitReason',
+ '*timeOffset': 'int'}}
##
# @VmDiskStats:
@@ -6765,6 +6768,8 @@
#
# Statistics for a running virtual machine.
#
+# @vmId: The UUID of the Vm
+#
# @displayPort:The port in use for unencrypted display data
#
# @displaySecurePort: The port in use for encrypted display data
@@ -6861,7 +6866,7 @@
# Since: 4.10.0
##
{'type': 'RunningVmStats',
- 'data': {'displayPort': 'uint', 'displaySecurePort': 'uint',
+ 'data': {'vmId': 'UUID', 'displayPort': 'uint', 'displaySecurePort': 'uint',
'displayType': 'VmDisplayType', 'displayIp': 'str', 'pid': 'uint',
'vmType': 'VmType', 'kvmEnable': 'bool',
'network': 'NetworkInterfaceStatsMap',
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15577/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14775/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15746/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/553/ :
FAILURE
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Francesco Romani has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1: Verified+1
verified using the tests.
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Francesco Romani has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 2:
version 2 changes the reference to the breakage from gerrit id to commit sha,
with no code changes.
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15620/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14818/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15789/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/596/ :
FAILURE
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
schema: require vmId in {Exited,Running}VmStats
On commit bb45b4b619c9a30a8fb35865fbd99f680295ac15
we were reminded in an harsh way that vmId must
always be present in the Vm.getStats() output.
One of the problems was that the vmId field was injected
the Vm.getStats() output by API.py, and this value was
not documented in the schema.
So, this patches update the schema to reflect the
reality of the Engine's needs.
Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Related-To: https://bugzilla.redhat.com/1191405
Signed-off-by: Francesco Romani
Reviewed-on: http://gerrit.ovirt.org/37696
Reviewed-by: Piotr Kliczewski
Reviewed-by: Dan Kenigsberg
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Dan Kenigsberg has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/639/ :
SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/238/
: FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4622/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/615/ :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/242/
: SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/640/ :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/242/
: SUCCESS
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/229/
: FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/636/ :
FAILURE
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6461/ :
FAILURE
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
automat...@ovirt.org has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
automat...@ovirt.org has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
automat...@ovirt.org has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
Piotr Kliczewski has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
