Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Francesco Romani has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: On this paste, I made a representation of how response of this verb look like, will look like and SHOULD look like. http://fpaste.org/201925/ -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Francesco Romani has posted comments on this change.
Change subject: schema: temporarily hide getMigrationStatus return
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39062/1//COMMIT_MSG
Commit Message:
Line 7: schema: temporarily hide getMigrationStatus return
Line 8:
Line 9: Commit b8df0ff261c unveiled a dark corner of VDSM
Line 10: and highlighted that the return value of
Line 11: VM.getMigrationStatus() API is inconsistent
can you tell more about that dark corner?
The dark corner is made of two dark spots:
- for VM_getMigrationStatus verb, we pollute our standard response {'status':
{'code': X, 'message': SOMETHING}} with more top level keys, which is unusual
and clutters the API. Most notably {'progress': Y, 'status': {'code': X,
'message': SOMETHING}}. This is actaully my bad, back in time I didn't noticed
that the added 'progress' key was exported at API level. However.
- the schema is actually wrong, as we don't return a MigrationStatusInfo type,
but rather an augmented status as I reported above
So, this patch _is_ a temporary hack/fix because we still have an inconstency
between code and schema, but we trade an explicit inconsistency for a subtler
one, which has the only benefit to unbreak master.
Line 12: and not passes the schema validation.
Line 13:
Line 14: This patch reverts the schema change and unbreaks
Line 15: the build until we figure out the proper clean fix.
--
To view, visit https://gerrit.ovirt.org/39062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Piotr Kliczewski has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: What do you think about adding VM.getMigrationStatus to IGNORED_CMDS in schemaValidation module with comment that it is temporary solution? -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Dan Kenigsberg has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39062/1//COMMIT_MSG Commit Message: Line 7: schema: temporarily hide getMigrationStatus return Line 8: Line 9: Commit b8df0ff261c unveiled a dark corner of VDSM Line 10: and highlighted that the return value of Line 11: VM.getMigrationStatus() API is inconsistent can you tell more about that dark corner? I'd rather mark this explicitly in a specific @brokentest() decorator, over reverting to our state of ignorance. Line 12: and not passes the schema validation. Line 13: Line 14: This patch reverts the schema change and unbreaks Line 15: the build until we figure out the proper clean fix. -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17219/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Francesco Romani has uploaded a new change for review.
Change subject: schema: temporarily hide getMigrationStatus return
..
schema: temporarily hide getMigrationStatus return
Commit b8df0ff261c unveiled a dark corner of VDSM
and highlighted that the return value of
VM.getMigrationStatus() API is inconsistent
and not passes the schema validation.
This patch reverts the schema change and unbreaks
the build until we figure out the proper clean fix.
This patch must be consider only a temporary fix.
Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/39062/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 477f712..6eb0cae 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6457,8 +6457,7 @@
#'message')
##
{'command': {'class': 'VM', 'name': 'getMigrationStatus'},
- 'data': {'vmID': 'UUID'},
- 'returns': 'MigrationStatusInfo'}
+ 'data': {'vmID': 'UUID'}}
##
# @VmExitCode:
--
To view, visit https://gerrit.ovirt.org/39062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
automat...@ovirt.org has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17045/ -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17219/ -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
