Change in vdsm[master]: service: change vdsm KillMode to mixed
gerrit-hooks has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 10: * #1189200::Update tracker: OK * Set MODIFIED::bug 1189200#1189200OK -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Dan Kenigsberg has submitted this change and it was merged. Change subject: service: change vdsm KillMode to mixed .. service: change vdsm KillMode to mixed When SIGTERM is sent to vdsm, automatically systemd sends the same signal to its childs processes, this can cause them to exit before vdsm closes fds to them properly. Using mixed KillMode in .service will send SIGTERM only to main vdsm service at first, sigkill will be sent to its children after a timeout. http://www.freedesktop.org/software/systemd/man/systemd.kill.html Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1189200 Signed-off-by: Yeela Kaplan Reviewed-on: https://gerrit.ovirt.org/45038 Reviewed-by: Yaniv Bronhaim Reviewed-by: Dima Kuznetsov Reviewed-by: Douglas Schilling Landgraf Reviewed-by: Fabian Deutsch Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski Tested-by: Yaniv Bronhaim Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M init/systemd/vdsmd.service.in M vdsm.spec.in 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dima Kuznetsov: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Dan Kenigsberg has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
gerrit-hooks has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 9: * #1189200::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: Verified+1 looks fine over f23 and centos7 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Piotr Kliczewski has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: We need to verify it first. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: can it be merged? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Piotr Kliczewski has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/45038/8/init/systemd/vdsmd.service.in File init/systemd/vdsmd.service.in: Line 20: User=@VDSMUSER@ Line 21: Group=@VDSMGROUP@ Line 22: PermissionsStartOnly=true Line 23: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@ Line 24: KillMode=mixed > Is this option available on all platforms? if not, can we generate this fil all platforms use systemd, so yes. should be .. I will tests if over rhel to be sure Line 25: Line 26: [Install] -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Nir Soffer has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/45038/8/init/systemd/vdsmd.service.in File init/systemd/vdsmd.service.in: Line 20: User=@VDSMUSER@ Line 21: Group=@VDSMGROUP@ Line 22: PermissionsStartOnly=true Line 23: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@ Line 24: KillMode=mixed Is this option available on all platforms? if not, can we generate this file for each platform so we can this fix now? Line 25: Line 26: [Install] -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Fabian Deutsch has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Nir Soffer has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: I updated the commit message. not sure about the "timeout" before the sigkill, but please re-visit it and comment if you don't agree with the patch. I don't see additional reason to delay it -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
gerrit-hooks has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: * #1189200::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
gerrit-hooks has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 7: * #1189200::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Nir Soffer has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review-1 (1 comment) Looks correct the commit message is not clear enough. https://gerrit.ovirt.org/#/c/45038/6//COMMIT_MSG Commit Message: Line 12: Using mixed KillMode will send SIGTERM only to main vdsm Line 13: service at first, Line 14: sigkill will be sent to its children after a timeout. Line 15: Line 16: This will allow vdsm to close everything properly. This commit message is not clear to someone who does not understand this problem. There is no chance that someone will understand this change 1 year from now. Please describe the flow of signals with current code and the flow of events with this change. Line 17: Line 18: Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1189200 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Douglas Schilling Landgraf has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review+1 Hi Oved, I was wondering if the patch sill valid as it's old one or if it's going to other approach. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Douglas - can you elaborate? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Douglas Schilling Landgraf has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: if this patch is not needed anymore, please abandon. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review+1 I assumed that you (vdsm) do want to kill its subprocesses cleanly. But as you say, this might grants that we won't have zombies as the zombierepear did (btw, it means that we can remove it now?) . I agree with this say, just tried to find the length of this timeout you refer to and I couldn't find exact values for how long systemd will wait before the sigkill.. Another btw, don't we want to set it in supervdsmd.service as well instead of zombierepear to be consist with the behavior ? I would love to hear more opinions about it ... -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yeela Kaplan has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Yaniv, If we set killmode to process: only the main process itself is killed. Which means that we could end up with vdsm zombie children that won't be killed. If we set killmode to mixed: the initial SIGTERM signal is sent to the main process (vdsm only). and after a delay if children processes still remain another signal this time: SIGKILL signal is sent to all remaining processes of the unit's control group. This means that we get both benefits of using 'process' mode and 'control-group' mode. First of all we systemd will termainate only vdsm. If, after a delay, its children did not terminate on their own, then a SIGKILL will be sent to them. This way we make sure no zombies are left. I believe it is our best option. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: -Code-Review Don't you need to use killMode=process? http://www.freedesktop.org/software/systemd/man/systemd.kill.html - otherwise you send sigkill directly to all subprocesses. don't we want vdsm to kill the ioprocesses? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yeela Kaplan has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Waiting till vdsm no longer supports el7.1, since killmode mixed is only backported to 7.2. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yaniv Bronhaim has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/45038/6//COMMIT_MSG Commit Message: Line 6: Line 7: service: change vdsm KillMode to mixed Line 8: Line 9: SIGTERM sent to vdsm, is sent to its child processes Line 10: as well, disrupting vdsm from closing everything properly. disturbing Line 11: Line 12: Using mixed KillMode will send SIGTERM only to main vdsm Line 13: service at first, Line 14: sigkill will be sent to its children after a timeout. Line 9: SIGTERM sent to vdsm, is sent to its child processes Line 10: as well, disrupting vdsm from closing everything properly. Line 11: Line 12: Using mixed KillMode will send SIGTERM only to main vdsm Line 13: service at first, I would add a link to http://www.freedesktop.org/software/systemd/man/systemd.kill.html Line 14: sigkill will be sent to its children after a timeout. Line 15: Line 16: This will allow vdsm to close everything properly. Line 17: -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Piotr Kliczewski has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45038/5/vdsm.spec.in
File vdsm.spec.in:
Line 200: Requires: selinux-policy-targeted >= 3.12.1-177
Line 201: # In order to avoid a policycoreutils bug (rhbz 889698) when selinux
is
Line 202: # disabled we now require the version 2.1.13-55 (or newer) of Fedora.
Line 203: Requires: policycoreutils >= 2.1.13-55
Line 204: Requires: systemd >= 209
Is this correct version number?
Line 205: %endif
Line 206:
Line 207: %if 0%{?rhel}
Line 208: Requires: qemu-kvm-rhev >= 10:2.1.2-23.el7_1.2
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
automat...@ovirt.org has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: * Update tracker::#1189200::OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct classification oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
automat...@ovirt.org has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 5: * Update tracker::#1189200::OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct classification oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: thanks for the clarification. -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Yeela Kaplan has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: This patch is verified on fedora. The mixed option is not yet backported to EL. So this patch is waiting for 7.2 (see 'depends on' flag in BZ). -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Oved Ourfali has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Yeela - can you verify? Can we merge this? -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Piotr Kliczewski has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
Dima Kuznetsov has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: service: change vdsm KillMode to mixed
automat...@ovirt.org has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 4: * Update tracker::#1189200::OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check Product::#1189200::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
