Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Dan Kenigsberg has submitted this change and it was merged. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. storage: Fix the case when VDSM host is not a gluster peer Currently when using glusterSD, VDSM has the need to know the transport type of gluster volume for which it uses gluster cli which assumes that VDSM host is part of gluster cluster (peer). This may not be true always and imposes a constraint that VDSM host must be a gluster peer. This patch fixes the above by doing 2 things... Adds support for --remote-host gluster cli option to volumeInfo API. This helps retrieve gluster volume info from a host that is not a gluster peer (Eg. VDSM host) Adds support to use the ability of gluster cli (--remote-host) to retrieve the gluster volume info even when VDSM host is not a gluster peer. Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Signed-off-by: Deepak C Shetty --- M vdsm/gluster/cli.py M vdsm/storage/glusterVolume.py 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Deepak C Shetty: Verified -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Dan Kenigsberg has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Bala.FA has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: gluster/cli.py - no changes since the last patch storage/glusterVolume.py - implemented suggestion from federico and squashed 14667 in this thanx, deepak -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2271/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1432/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2335/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has abandoned this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Abandoned squash with 14666 -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Will squash this with 14666 per fsimonce's suggestion hence abandoning this change -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2335/ (2/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1432/ (3/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2271/ (1/3) -- To view, visit http://gerrit.ovirt.org/14666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5967f42555db27c104cd64449fccdc9b5fbc779 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 1: (1 inline comment)
File vdsm/storage/glusterVolume.py
Line 26: svdsmProxy = svdsm.getProxy()
Line 27: try:
Line 28: volInfo = svdsmProxy.glusterVolumeInfo(volname,
volfileServer)
Line 29: volTrans =
VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
Line 30: except:
Done
Line 31: # In case of issues with finding transport type, default
to tcp
Line 32: self.log.warning("Unable to find transport type for
GlusterFS"
Line 33: "volume %s. GlusterFS server = %s",
Line 34: (volname, volfileServer), exc_info=True)
--
To view, visit http://gerrit.ovirt.org/14667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Deepak C Shetty
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Federico Simoncelli has posted comments on this change.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
Patch Set 1: (1 inline comment)
Maybe you can squash this with http://gerrit.ovirt.org/#/c/14666
File vdsm/storage/glusterVolume.py
Line 26: svdsmProxy = svdsm.getProxy()
Line 27: try:
Line 28: volInfo = svdsmProxy.glusterVolumeInfo(volname,
volfileServer)
Line 29: volTrans =
VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
Line 30: except:
I think you should try to catch the correct exception
Line 31: # In case of issues with finding transport type, default
to tcp
Line 32: self.log.warning("Unable to find transport type for
GlusterFS"
Line 33: "volume %s. GlusterFS server = %s",
Line 34: (volname, volfileServer), exc_info=True)
--
To view, visit http://gerrit.ovirt.org/14667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2227/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1388/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2291/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2227/ (3/3) -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1388/ (1/3) -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
oVirt Jenkins CI Server has posted comments on this change. Change subject: storage: Fix the case when VDSM host is not a gluster peer .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2291/ (2/3) -- To view, visit http://gerrit.ovirt.org/14667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Fix the case when VDSM host is not a gluster peer
Deepak C Shetty has uploaded a new change for review.
Change subject: storage: Fix the case when VDSM host is not a gluster peer
..
storage: Fix the case when VDSM host is not a gluster peer
Currently when using glusterSD, VDSM has the need to know the
transport type of gluster volume for which it uses gluster cli
which assumes that VDSM host is part of gluster cluster (peer).
This may not be true always and imposes a constraint that VDSM
host must be a gluster peer.
This patch uses the ability of gluster cli (--remote-host) to
retrieve the gluster volume info even when VDSM host is not a
gluster peer.
Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7
Signed-off-by: Deepak C Shetty
---
M vdsm/storage/glusterVolume.py
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/14667/1
diff --git a/vdsm/storage/glusterVolume.py b/vdsm/storage/glusterVolume.py
index 73ded57..76ea37a 100644
--- a/vdsm/storage/glusterVolume.py
+++ b/vdsm/storage/glusterVolume.py
@@ -24,8 +24,15 @@
# Extract the volume's transport using gluster cli
svdsmProxy = svdsm.getProxy()
-volInfo = svdsmProxy.glusterVolumeInfo(volname)
-volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
+try:
+volInfo = svdsmProxy.glusterVolumeInfo(volname, volfileServer)
+volTrans = VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
+except:
+# In case of issues with finding transport type, default to tcp
+self.log.warning("Unable to find transport type for GlusterFS"
+ "volume %s. GlusterFS server = %s",
+ (volname, volfileServer), exc_info=True)
+volTrans = VOLUME_TRANS_MAP['TCP']
# Use default port
volPort = "0"
--
To view, visit http://gerrit.ovirt.org/14667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54ad86d12e40973c9e50821506cb21a17fc2a1d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
