Change in vdsm[master]: storage: Move legality check in prepareImage
Jenkins CI RO has abandoned this change. Change subject: storage: Move legality check in prepareImage .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam LitkeGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Move legality check in prepareImage
gerrit-hooks has posted comments on this change. Change subject: storage: Move legality check in prepareImage .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam LitkeGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Move legality check in prepareImage
Nir Soffer has posted comments on this change. Change subject: storage: Move legality check in prepareImage .. Patch Set 1: Code-Review-1 (1 comment) Need more thinking before we touch this. https://gerrit.ovirt.org/#/c/55228/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3194: Line 3195: for volUUID in imgVolumes: Line 3196: legality = dom.produceVolume(imgUUID, volUUID).getLegality() Line 3197: if legality == volume.ILLEGAL_VOL: Line 3198: raise se.prepareIllegalVolumeError(volUUID) This leaks the image links created in line 3189. Callers typically call teardownImage only if prepareImage succeeded. But this issue exists also dom.linkBCImage failed, or preparing volInfo failed, so this is only minor regression :-) I would consider instead killing the BC image link, and having same directory layout in all cases. Line 3199: Line 3200: leafPath = os.path.join(runImgPath, leafUUID) Line 3201: for volUUID in imgVolumes: Line 3202: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam LitkeGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move legality check in prepareImage
Adam Litke has posted comments on this change. Change subject: storage: Move legality check in prepareImage .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam LitkeGerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move legality check in prepareImage
gerrit-hooks has posted comments on this change. Change subject: storage: Move legality check in prepareImage .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam LitkeGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move legality check in prepareImage
Adam Litke has uploaded a new change for review. Change subject: storage: Move legality check in prepareImage .. storage: Move legality check in prepareImage The legality check causes volume objects to be produced so that the legality flag can be checked. Unfortunately, the Volume constructor has a side effect of creating an image directory for the volume in the storage repository. This preempts the image links creation that would normally be performed by prepareImage. In order to restore the previous behavior, move the legality check after prepareImage has created the image links. The result of this patch is that on an HSM host, the directory: /rhev/data-center/mnt/blockSD//images/ will be a symlink to /var/run/vdsm/storage// instead of the current behavior where: /rhev/data-center/mnt/blockSD//images/ is an actual directory containing symlinks that point to /dev//. Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Signed-off-by: Adam Litke--- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/55228/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index c4305bd..ec91c1a 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3186,17 +3186,17 @@ if leafUUID not in imgVolumes: raise se.VolumeDoesNotExist(leafUUID) -for volUUID in imgVolumes: -legality = dom.produceVolume(imgUUID, volUUID).getLegality() -if legality == volume.ILLEGAL_VOL: -raise se.prepareIllegalVolumeError(volUUID) - imgPath = dom.activateVolumes(imgUUID, imgVolumes) if spUUID and spUUID != sd.BLANK_UUID: runImgPath = dom.linkBCImage(imgPath, imgUUID) else: runImgPath = imgPath +for volUUID in imgVolumes: +legality = dom.produceVolume(imgUUID, volUUID).getLegality() +if legality == volume.ILLEGAL_VOL: +raise se.prepareIllegalVolumeError(volUUID) + leafPath = os.path.join(runImgPath, leafUUID) for volUUID in imgVolumes: path = os.path.join(dom.domaindir, sd.DOMAIN_IMAGES, imgUUID, -- To view, visit https://gerrit.ovirt.org/55228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2c2e4eac2dccf72102a3cd7cdf361fc1d079beb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches