Change in vdsm[master]: storage: add getHostId to DomainMonitor
Adam Litke has uploaded a new change for review. Change subject: storage: add getHostId to DomainMonitor .. storage: add getHostId to DomainMonitor Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Signed-off-by: Adam Litke --- M vdsm/storage/monitor.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/50630/1 diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py index d5156f3..b4a0846 100644 --- a/vdsm/storage/monitor.py +++ b/vdsm/storage/monitor.py @@ -149,6 +149,9 @@ status[sdUUID] = monitor.getHostStatus(hostId) return status +def getHostId(self, sdUUID): +return self._monitors[sdUUID].hostId + def shutdown(self): """ Called during shutdown to stop all monitors without releasing the host -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 1: Code-Review+1 I like it, waiting for other people reviews. -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50630/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-12-16 15:41:26 -0500 Line 6: Line 7: storage: add getHostId to DomainMonitor Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Trailing whitespace Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. Line 13: Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. Explain why we don't use: getPools()[0].id Line 13: Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50630/3//COMMIT_MSG Commit Message: Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. Please explain why not use getPools()[0].id Line 13: Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Adam Litke has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50630/3//COMMIT_MSG Commit Message: Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. > Please explain why not use getPools()[0].id Done Line 13: Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Adam Litke has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 4: Verified+1 Verified by testing the SDM.create_volume verb (from later in this topic). -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
Nir Soffer has submitted this change and it was merged. Change subject: storage: add getHostId to DomainMonitor .. storage: add getHostId to DomainMonitor Some SDM verbs need to acquire the domainLock during their job. In order to do this they must be passed the domain's hostId property. An easy way to expose this is to add a getHostId method to the DomainMonitor. Another method (not chosen) is for IRS to access the host id via the StorageDomainManifest.getPools method: dom_manifest.getPools()[0].id The main reason for using the domainMonitor is to avoid adding any new users of the StoragePool class. Since the domainMonitor acquires the hostID via SANLock, it seems qualified to communicate that hostID to its owner. Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/50630 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M vdsm/storage/monitor.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: add getHostId to DomainMonitor
gerrit-hooks has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
