Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: storage: extend drives name to allow sata interface
..


storage: extend drives name to allow sata interface

SATA is widely used physical interface for storage devices. The
interface uses SCSI protocol, making it similar to SCSI itself in
terms of naming, but libvirt distinguishes the physical interfaces.

We therefore add SATA name generation to properly support SATA devices.

Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/56803
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 8: -Verified

The test is wrong (contains wrong data), shouldn't be marked as verified, 
submitting new version asap.

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 8:

Martin, is your self-inflicted -1 still relevant?

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-15 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 7:

Please rebease on master, should fix ci failure.

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 5: Code-Review+2

restoring score

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-11 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56803/4/tests/vmStorageTests.py
File tests/vmStorageTests.py:

PS4, Line 637: ['sata', -1, 'sda'],
 : ['sata', 0, 'sda'],
 : ['sata', 1, 'sda'],
 : ['sata', 2, 'sdb'],
 : ['sata', 26, 'sdz'],
 : ['sata', 27, 'sda'],
 : ['sata', 28, 'sdb'],
is wrong and git is refusing to push the correct version


-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 2: Code-Review+2

please try to make jenkins happy!

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-03 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-05-02 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-29 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: extend drives name to allow sata interface
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: extend drives name to allow sata interface

2016-04-28 Thread mpolednik 
Martin Polednik has uploaded a new change for review.

Change subject: storage: extend drives name to allow sata interface
..

storage: extend drives name to allow sata interface

SATA is widely used physical interface for storage devices. The
interface uses SCSI protocol, making it similar to SCSI itself in
terms of naming, but libvirt distinguishes the physical interfaces.

We therefore add SATA name generation to properly support SATA devices.

Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Signed-off-by: Martin Polednik 
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 10 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/56803/1

diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index 9534f69..af95aab 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -633,6 +633,14 @@
 ['fdc', 26, 'fdz'],
 ['fdc', 27, 'fda'],
 ['fdc', 28, 'fdb'],
+
+['sata', -1, 'sda'],
+['sata', 0, 'sda'],
+['sata', 1, 'sda'],
+['sata', 2, 'sdb'],
+['sata', 26, 'sdz'],
+['sata', 27, 'sda'],
+['sata', 28, 'sdb'],
 ])
 def test_ide_drive(self, interface, index, expected_name):
 conf = drive_config(
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 74e03b2..713f996 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -352,7 +352,8 @@
 pass  # Ignore if custom disk cache is missing
 
 def _makeName(self):
-devname = {'ide': 'hd', 'scsi': 'sd', 'virtio': 'vd', 'fdc': 'fd'}
+devname = {'ide': 'hd', 'scsi': 'sd', 'virtio': 'vd', 'fdc': 'fd',
+   'sata': 'sd'}
 devindex = ''
 
 i = int(self.index)


-- 
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibec60639922a410218e0e48d0d607ce46e5ed4a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches