Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Nir Soffer has submitted this change and it was merged. Change subject: storagetests: Rename make_blocksd .. storagetests: Rename make_blocksd Over time make_blocksd has evolved to work more like make_filesd_manifest. Now that it performs the same functionality as its file counterpart we should make the names similar as well. Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/54569 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland --- M tests/storagetestlib.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Freddy Rolland has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Nir Soffer has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Adam Litke has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Nir Soffer has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54569/2/tests/storagetestlib.py File tests/storagetestlib.py: Line 56: with namedTemporaryDir() as tmpdir: Line 57: lvm = FakeLVM(tmpdir) Line 58: with MonkeyPatchScope([(blockSD, 'lvm', lvm), Line 59:(blockVolume, 'lvm', lvm), Line 60:(sd, 'storage_repository', tmpdir)]): Related? Looks like this needs a rebase. Line 61: sd_manifest = make_blocksd_manifest(tmpdir, lvm) Line 62: yield FakeEnv(sd_manifest, lvm=lvm) Line 63: Line 64: -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Adam Litke has uploaded a new change for review. Change subject: storagetests: Rename make_blocksd .. storagetests: Rename make_blocksd Over time make_blocksd has evolved to work more like make_filesd_manifest. Now that it performs the same functionality as its file counterpart we should make the names similar as well. Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Signed-off-by: Adam Litke --- M tests/storagetestlib.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/54569/1 diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py index c3c508f..5184124 100644 --- a/tests/storagetestlib.py +++ b/tests/storagetestlib.py @@ -58,7 +58,7 @@ with MonkeyPatchScope([(blockSD, 'lvm', lvm), (blockVolume, 'lvm', lvm), (sd, 'storage_repository', tmpdir)]): -sd_manifest = make_blocksd(tmpdir, lvm) +sd_manifest = make_blocksd_manifest(tmpdir, lvm) yield FakeEnv(sd_manifest, lvm=lvm) @@ -76,7 +76,8 @@ return md -def make_blocksd(tmpdir, fake_lvm, sduuid=None, devices=None, metadata=None): +def make_blocksd_manifest(tmpdir, fake_lvm, sduuid=None, devices=None, + metadata=None): if sduuid is None: sduuid = str(uuid.uuid4()) if devices is None: -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
