Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storagetests: add a test for normalize_local_path
..


storagetests: add a test for normalize_local_path

This patch adds a legitimate test permutation to
MountConnectionTests.test_normalize_local_path.
Since the new permutation breaks the test, it was marked as
@brokentests.

Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Related-To: https://bugzilla.redhat.com/1305529
Signed-off-by: Idan Shaby 
Reviewed-on: https://gerrit.ovirt.org/55181
Reviewed-by: Adam Litke 
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storageServerTests.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11:

This is ready, but I'm waiting for the next patch, since this patch mark good 
tests as broken.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[alitke]

Adam Litke has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 10: -Verified

There've been too many rebases since the last time I verified.
Marking as not verified until the next patch is reviewed, and then I'll verify 
them together.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 5: Code-Review+1

Failing tests looks good, we need to add the other failing tests that require 
the fixes in the next patch.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 3:

Nir, this series of patches are aimed to fix a bug.
Please don't delay them with a request to fix other things "on the way". We can 
upload a patch to fix it later.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 2: Verified+1

The tests fail as it should

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 2:

Looks fine - lets fine the other places doing path normalization when a spec 
enter vdsm and add failing tests for them.

I don't want to fix this only in once place since this will lead to regression. 
We must fix this issue globally in all code paths.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 2: Verified-1

(1 comment)

Marking verified=-1 as for my note in storageServerTests.py.

https://gerrit.ovirt.org/#/c/55181/1/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 66: self.assertEquals(mount_con._mount.fs_spec, "dummy-spec")
Line 67: self.assertEquals(mount_con._mount.fs_file, "/tmp/dummy-spec")
Line 68: 
Line 69: @permutations([
Line 70: # spec, localpath
> Please remove the @brokentest, until we are sure that the failures are caus
Removing the @brokentest.
Please *DO NOT* merge this patch until I bring back the @brokentest.
Line 71: ("server:/a/", "/tmp/server:_a"),
Line 72: ("server:/a//", "/tmp/server:_a"),
Line 73: ("server:/a/b", "/tmp/server:_a_b"),
Line 74: ("server:/a//b", "/tmp/server:_a_b"),


-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches