Change in vdsm[master]: supervdsm: fix trigger docstring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: supervdsm: fix trigger docstring
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/45939/3/lib/vdsm/udevadm.py
File lib/vdsm/udevadm.py:

Line 66: Request device events from the kernel.
Line 67: 
Line 68: Arguments:
Line 69: 
Line 70: attr_matchesAn iterable of attribute name, value pairs.
> this might be more correct, but it's much less legible. Adding a parenthesi
Maybe:

An iterable of attribute (name, value) pairs
Line 71: These are expanded like this:
Line 72: 
Line 73: [('a', 'b'), ('c', 'd')] ~>
Line 74: --attr-match=a=b --attr-match=c=d


-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/45939/3/lib/vdsm/udevadm.py
File lib/vdsm/udevadm.py:

Line 70: attribute name, value
this might be more correct, but it's much less legible. Adding a parenthesis 
may help.

 An iterable of (attribute name, value) pairs


-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 3: Verified+1

annoyance that slipped through

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[automation]

automat...@ovirt.org has posted comments on this change.

Change subject: supervdsm: fix trigger docstring
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: fix trigger docstring

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: supervdsm: fix trigger docstring
..

supervdsm: fix trigger docstring

Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Signed-off-by: Martin Polednik 
---
M lib/vdsm/udevadm.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/45939/1

diff --git a/lib/vdsm/udevadm.py b/lib/vdsm/udevadm.py
index 35970fe..88c19ee 100644
--- a/lib/vdsm/udevadm.py
+++ b/lib/vdsm/udevadm.py
@@ -67,29 +67,29 @@
 
 Arguments:
 
-attr_matchesList of 2-tuples that contain attribute name and
-it's value. These are expanded like this:
+attr_matchesAn iterable of attribute name, value pairs.
+These are expanded like this:
 
 [('a', 'b'), ('c', 'd')] ~>
 --attr-match=a=b --attr-match=c=d
 
-and causes only events from devices that match
+and cause only events from devices that match
 given attributes to be triggered.
 
-property_matchesSimilar to attr_matches. Expects list of 2-tuples
+property_matchesSimilar to attr_matches. Expects an iterable of pairs
 that expand in similar fashion, that is
 
 [('a', 'b'), ('c', 'd')] ~>
 --property-match=a=b --property-match=c=d
 
-and causes only events from devices that match
+and cause only events from devices that match
 given property to be triggered.
 
 subsystem_matches   Expects an iterable of subsystems.
 
 ('a', 'b') ~> --subsystem-match=a --subsystem-match=b
 
-Causes only events related to specified subsystem to
+Cause only events related to specified subsystem to
 be triggered.
 '''
 _run_command(['control', '--reload'])


-- 
To view, visit https://gerrit.ovirt.org/45939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief9af5dd73fc38b366fb4903b313bc420e2a4172
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches