Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
automat...@ovirt.org has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
automat...@ovirt.org has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
Nir Soffer has uploaded a new change for review. Change subject: test: Move assertXMLEqual to testlib [1/4] .. test: Move assertXMLEqual to testlib [1/4] assertXMLEqual should be part of testlib, so we can use it in other tests easily. To do that, we need to: 1. Remove unused assertXMLNone 2. Remove the dependency on xml.dom.minidom 3. Separate finding xml fragment from asserting 4. Move assertXMLEqual up to testlib.VdsmTestcase This pach removes the unused assertXMLNone method. Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Signed-off-by: Nir Soffer nsof...@redhat.com --- M tests/vmTests.py 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/36981/1 diff --git a/tests/vmTests.py b/tests/vmTests.py index f763cb2..6455720 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -149,11 +149,6 @@ XMLs are different:\nActual:\n%s\nExpected:\n%s\n % (actualXML, expectedXML)) -def assertXMLNone(self, element, path): -elem = ET.fromstring(element.toprettyxml()) -converted = elem.find(./%s % path) -self.assertEqual(converted, None) - def assertBuildCmdLine(self, confToDom): with namedTemporaryDir() as tmpDir: with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/')]): -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
Nir Soffer has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
oVirt Jenkins CI Server has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15090/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14921/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14133/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
Francesco Romani has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 1: Code-Review+1 Yep, seems unused. Good riddance to this method. -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
Dan Kenigsberg has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
Dan Kenigsberg has submitted this change and it was merged. Change subject: test: Move assertXMLEqual to testlib [1/4] .. test: Move assertXMLEqual to testlib [1/4] assertXMLEqual should be part of testlib, so we can use it in other tests easily. To do that, we need to: 1. Remove unused assertXMLNone 2. Remove the dependency on xml.dom.minidom 3. Separate finding xml fragment from asserting 4. Move assertXMLEqual up to testlib.VdsmTestcase This pach removes the unused assertXMLNone method. Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36981 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmTests.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Move assertXMLEqual to testlib [1/4]
oVirt Jenkins CI Server has posted comments on this change. Change subject: test: Move assertXMLEqual to testlib [1/4] .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6318/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/496/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/491/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/473/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/99/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/99/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/99/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/98/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4483/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I400848ae6c1dad6dc92a1bb71477a619802f317e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
