Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-04 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 2:

Starting OVS service from a test module should have happened only once, it is 
costly to repeat it for each test group.

The change preferred here should be in the spirit of py.test module level 
fixture.

Please consider improving this in a following patch.
(I guess we should wait for py.test, then it will be simpler)

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: test: validate that OVS tests runs as root
..


test: validate that OVS tests runs as root

Move OVS service handling to class level, as they it is not needed
for all classes (TestOvsVsctlCommand).

This patch is needed to fix non-root RPM builds on docker.

Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/56952
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M tests/network/ovs_driver_test.py
1 file changed, 14 insertions(+), 12 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/56952/1/tests/network/ovs_driver_test.py
File tests/network/ovs_driver_test.py:

Line 223: self.ovsdb.add_br(TEST_BRIDGE).execute()
Line 224: 
Line 225: def tearDown(self):
Line 226: self.ovsdb.del_br(TEST_BRIDGE).execute()
Line 227: self.ovs_service.teardown()
this has adds needless slowdown when running all tests, but let us first 
unbreak master.
Line 228: 
Line 229: def test_create_vlan_as_fake_bridge(self):
Line 230: with self.ovsdb.transaction() as t:
Line 231: t.add(self.ovsdb.add_vlan(TEST_BRIDGE, 100))


-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 1: Verified+1

Passed both with super and regular user. Fixed RPM build problem.

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 1: Code-Review+1

It fixes the problem I had with `make rpm' in Vdsm.

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread phoracek 
Petr Horáček has uploaded a new change for review.

Change subject: test: validate that OVS tests runs as root
..

test: validate that OVS tests runs as root

Move OVS service handling to class level, as they it is not needed
for all classes (TestOvsVsctlCommand).

This patch is needed to fix non-root RPM builds on docker.

Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Signed-off-by: Petr Horáček 
---
M tests/network/ovs_driver_test.py
1 file changed, 14 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/56952/1

diff --git a/tests/network/ovs_driver_test.py b/tests/network/ovs_driver_test.py
index 31249d3..c9e59a4 100644
--- a/tests/network/ovs_driver_test.py
+++ b/tests/network/ovs_driver_test.py
@@ -26,20 +26,10 @@
 from .nettestlib import dummy_device
 from .ovsnettestlib import OvsService, TEST_BRIDGE, TEST_BOND
 from testlib import VdsmTestCase
+from testValidation import ValidateRunningAsRoot
 
 from vdsm.network.ovs.driver import create
 from vdsm.network.ovs.driver import vsctl
-
-
-ovs_service = OvsService()
-
-
-def setup_module():
-ovs_service.setup()
-
-
-def teardown_module():
-ovs_service.teardown()
 
 
 @attr(type='unit')
@@ -182,6 +172,14 @@
 @attr(type='integration')
 class TestOvsApiBase(VdsmTestCase):
 
+@ValidateRunningAsRoot
+def setUp(self):
+self.ovs_service = OvsService()
+self.ovs_service.setup()
+
+def tearDown(self):
+self.ovs_service.teardown()
+
 def test_instantiate_vsctl_implementation(self):
 self.assertIsNotNone(create('vsctl'))
 
@@ -216,13 +214,17 @@
 @attr(type='integration')
 class TestOvsApiWithSingleRealBridge(VdsmTestCase):
 
+@ValidateRunningAsRoot
 def setUp(self):
-self.ovsdb = create()
+self.ovs_service = OvsService()
+self.ovs_service.setup()
 
+self.ovsdb = create()
 self.ovsdb.add_br(TEST_BRIDGE).execute()
 
 def tearDown(self):
 self.ovsdb.del_br(TEST_BRIDGE).execute()
+self.ovs_service.teardown()
 
 def test_create_vlan_as_fake_bridge(self):
 with self.ovsdb.transaction() as t:


-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: validate that OVS tests runs as root

2016-05-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: test: validate that OVS tests runs as root
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04404531ad85ca357dce3ed72ca7fd3f2be9c533
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches