Change in vdsm[master]: testrunner P_VDSM path fix
Dan Kenigsberg has submitted this change and it was merged. Change subject: testrunner P_VDSM path fix .. testrunner P_VDSM path fix when running run_tests_local.sh the tests that want to find modules that would usually be installed to /usr/share/vdsm should look in $repo_root/vdsm instead of $repo_root. Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20020 Reviewed-by: mooli tayer mta...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/testrunner.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Verified mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Dan Kenigsberg has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 2: Code-Review+2 In a private communication I've understood that this currently affects only looking for vdsm-restore-net-config, and as such has not been noticed until now. -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Antoni Segura Puimedon has uploaded a new change for review. Change subject: testrunner P_VDSM path fix .. testrunner P_VDSM path fix when running run_tests_local.sh the tests that want to find modules in that would usually be installed to /usr/share/vdsm should look in $repo_root/vdsm instead of $repo_root. Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com --- M tests/testrunner.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/20020/1 diff --git a/tests/testrunner.py b/tests/testrunner.py index bf49dd1..2d4dcc9 100644 --- a/tests/testrunner.py +++ b/tests/testrunner.py @@ -319,7 +319,7 @@ instead of installed ones.\n) if findRemove(sys.argv, --local-modules): from vdsm import constants -constants.P_VDSM = ../ +constants.P_VDSM = ../vdsm/ # Mock panic() calls for tests utils.panic = panicMock -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
oVirt Jenkins CI Server has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4782/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3973/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Yaniv Bronhaim has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: Seems like right and important fix, but what did fail due to that bug ? how did you encounter that mistake ? -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Antoni Segura Puimedon has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: @Yaniv: running local tests for http://gerrit.ovirt.org/#/c/17010/ that uses P_VDSM to find and call vdsm-restore-net-config -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Yaniv Bronhaim has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: Code-Review+1 Odd that we missed that till now Thanks. -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Antoni Segura Puimedon has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: (1 comment) Commit Message Line 6: Line 7: testrunner P_VDSM path fix Line 8: Line 9: when running run_tests_local.sh the tests that want to find modules Line 10: in that would usually be installed to /usr/share/vdsm should look Ooops. Good catch :-) Line 11: in $repo_root/vdsm instead of $repo_root. Line 12: Line 13: Change-Id: I7ce18ceacbf95813c587238863e271f200322478 -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
oVirt Jenkins CI Server has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4806/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4882/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3997/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
mooli tayer has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 1: (1 comment) Commit Message Line 6: Line 7: testrunner P_VDSM path fix Line 8: Line 9: when running run_tests_local.sh the tests that want to find modules Line 10: in that would usually be installed to /usr/share/vdsm should look please remove 'in' Line 11: in $repo_root/vdsm instead of $repo_root. Line 12: Line 13: Change-Id: I7ce18ceacbf95813c587238863e271f200322478 -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
mooli tayer has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testrunner P_VDSM path fix
Antoni Segura Puimedon has posted comments on this change. Change subject: testrunner P_VDSM path fix .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/20020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ce18ceacbf95813c587238863e271f200322478 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
