Change in vdsm[master]: tests: Introduce FakeSanlock

2016-09-08 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 4: Code-Review+2

Need to check why jenkins is grumpy

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-17 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-12 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 1:

None currently.  We mocked the clusterlock for SDM.create_volume and that could 
be converted to the new code in a followup patch.  The old sanlock hack was 
just to work around ImportErrors when the sanlock python module was not 
installed.

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-11 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62265/1//COMMIT_MSG
Commit Message:

Line 7: tests: Introduce FakeSanlock
Line 8: 
Line 9: For the few tests that depend on sanlock, introduce FakeSanlock which
Line 10: does nothing except record acquire and release calls so that we can
Line 11: check that locks were acquired as expected.
We don't have any test in current code that need a fake sanlock?
Line 12: 
Line 13: Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca


-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

2016-08-11 Thread alitke 
Adam Litke has uploaded a new change for review.

Change subject: tests: Introduce FakeSanlock
..

tests: Introduce FakeSanlock

For the few tests that depend on sanlock, introduce FakeSanlock which
does nothing except record acquire and release calls so that we can
check that locks were acquired as expected.

Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/62265/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 7ea0cee..d52e19e 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -307,3 +307,21 @@
 
 def manuallyRemoveDomain(self, sdUUID):
 self.domains.pop(sdUUID, None)
+
+
+class FakeSanlock(object):
+SLKFD = 15
+
+def register(self):
+return self.SLKFD
+
+def init_resource(self, sdUUID, volUUID, lockDisk):
+pass
+
+@recorded
+def acquire(self, lockspace, resource, lease, slkfd):
+pass
+
+@recorded
+def release(self, lockspace, resource, lease, slkfd):
+pass


-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org