Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
unified pers: fix restoration when moving from ifcfg pers
Up until now we were only flushing the persistence of the
configurator currently set up. This had the problem that when
switching between configurators and persistence models, old
persistence remainders could be left over.
Bug-Url https://bugzilla.redhat.com/1064530
Signed-off-by: Antoni S. Puimedon
Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856
---
M vdsm/vdsm-restore-net-config
1 file changed, 25 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/25063/1
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index fc2308b..8f758fd 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -1,6 +1,6 @@
#! /usr/bin/python
#
-# Copyright 2011-2012 Red Hat, Inc.
+# Copyright 2011-2014 Red Hat, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -18,14 +18,19 @@
#
# Refer to the README and COPYING files for full details of the license
#
-
import logging
import logging.config
-from netconf import ifcfg
from vdsm.config import config
+
+# Ifcfg persistence restoration
+from netconf import ifcfg
+
+# Unified persistence restoration
from vdsm.netconfpersistence import RunningConfig, PersistentConfig
-from configNetwork import setupNetworks, ConfiguratorClass
+from configNetwork import setupNetworks
+import pkgutil
+import netconf
def ifcfg_restoration():
@@ -38,7 +43,6 @@
Builds a setupNetworks command from the persistent configuration to set it
as running configuration.
"""
-configurator = ConfiguratorClass()
runningConfig = RunningConfig()
removeNetworks = {}
removeBonds = {}
@@ -51,7 +55,11 @@
setupNetworks(removeNetworks, removeBonds, connectivityCheck=False,
_inRollback=True)
-configurator.flush()
+# Flush vdsm configurations left-overs from any configurator on the system
+# so that changes of configurator and persistence system are smooth.
+for configurator_cls in _get_all_configurators():
+configurator_cls().flush()
+
persistentConfig = PersistentConfig()
nets = persistentConfig.networks
bonds = persistentConfig.bonds
@@ -60,6 +68,17 @@
setupNetworks(nets, bonds, connectivityCheck=False, _inRollback=True)
+def _get_all_configurators():
+"""Returns the class objects of all the configurators in the netconf pkg"""
+prefix = netconf.__name__ + '.'
+for importer, moduleName, isPackage in pkgutil.iter_modules(
+netconf.__path__, prefix):
+__import__(moduleName, fromlist="_")
+
+for cls in netconf.Configurator.__subclasses__():
+yield cls
+
+
def restore():
if config.get('vars', 'net_persistence') == 'unified':
unified_restoration()
--
To view, visit http://gerrit.ovirt.org/25063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 1: Verification done with: dev-10 vdsm (3956802) # ll /etc/sysconfig/network-scripts/ifcfg* -rw-rw-r--. 1 root root 114 Feb 26 09:17 /etc/sysconfig/network-scripts/ifcfg-dummy_21 -rw-rw-r--. 1 root root 115 Feb 26 10:39 /etc/sysconfig/network-scripts/ifcfg-dummy_31 -rw-rw-r--. 1 root root 114 Feb 26 10:39 /etc/sysconfig/network-scripts/ifcfg-dummy_4 -rw-rw-r--. 1 root root 114 Feb 26 09:17 /etc/sysconfig/network-scripts/ifcfg-dummy_6 -rw-rw-r--. 1 root root 129 Feb 25 14:24 /etc/sysconfig/network-scripts/ifcfg-em1 -rw-rw-r--. 1 root root 56 Jan 24 17:40 /etc/sysconfig/network-scripts/ifcfg-em2 -rw-r--r--. 1 root root 254 Oct 10 16:48 /etc/sysconfig/network-scripts/ifcfg-lo -rw-r--r--. 1 root root 159 Feb 25 14:24 /etc/sysconfig/network-scripts/ifcfg-ovirtmgmt changing at this point net_persistence and net_configurator to "unified" and "iproute2" dev-10 vdsm (3956802) # /usr/share/vdsm/vdsm-restore-net-config dev-10 vdsm (3956802) # ll /etc/sysconfig/network-scripts/ifcfg* -rw-rw-r--. 1 root root 56 Jan 24 17:40 /etc/sysconfig/network-scripts/ifcfg-em2 -rw-r--r--. 1 root root 254 Oct 10 16:48 /etc/sysconfig/network-scripts/ifcfg-lo dev-10 vdsm (3956802) # ll /var/run/vdsm/netconf/nets/ovirtmgmt -rw-r--r--. 1 root root 35 Feb 26 11:41 /var/run/vdsm/netconf/nets/ovirtmgmt dev-10 vdsm (3956802) # -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7310/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7428/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 1: To fix the bug, another patch should be made to the upgrade scripts so that they also flush the previous configurators. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7314/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7432/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Douglas Schilling Landgraf has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 2: I got the same behavior from my bug#1064530. Toni, I can provide logs or even access to my machine. Fell free to ping me. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Douglas Schilling Landgraf has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 2: Toni, As you know, my previous tests were with wrong vdsm because during the deploy vdsm get replaced by higher version. However, now with the correct one still cannot start vdsm after reboot. Can you please login into my machine to double check? -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7362/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7480/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7363/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7368/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Verified+1 Ran these two flows successfully: Flow 1 (No computer reboot) === 1. Edit /etc/vdsm/vdsm.conf so that in [vars] net_persistence = unified net_configurator = iproute2 2. restart vdsm service vdsmd stop service supervdsmd stop service vdsmd start This will have loaded the unified persistence's RunningConfig and PersistentConfig. 3. restore vdsm networks vdsm-tool restore-nets This will use RunningConfig (from step 2) to take down the networks set up by the old configurator, flush all the configurators config files and finally use the PersistentConfig (from step 2) to recover the networking. 4. You're done ;-) Flow 2 (Computer reboot) 1. Edit /etc/vdsm/vdsm.conf so that in [vars] net_persistence = unified net_configurator = iproute2 2. Reboot your computer. What will happen is: a) on reboot, the old configurator files will still be there. They will be picked up by that configurator (its init service should still be enabled for this flow to succeed), b) The upgrade script will run generating RunningConfig and PersistentConfig c) /usr/share/vdsm/vdsm-restore-net-config will run and will do the equivalent of step 3 of the flow above. Did that while having ovirtmgmt as a non-vlanned bridged network over em1 before step 1 of any of the flows. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
oVirt Jenkins CI Server has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7379/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Douglas Schilling Landgraf has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Verified+1 jenkins failure not related to the patch. Toni, do you mind to add those notes how to test to ovirt wiki related topic? Other then that, the patch works. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: I'll add the notes Douglas. Thanks for the verification effort! -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Antoni Segura Puimedon has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: @Douglas: Notes added in http://www.ovirt.org/Feature/NetworkReloaded#Upgrading_to_the_unified_persistence_and_iproute2_as_configurators -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Douglas Schilling Landgraf has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: thanks a lot. Users will enjoy the doc. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Dan Kenigsberg has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Thanks Toni for solving this bug, but I am a bit dismayed by having forgotten why we no longer call vdsm-restore-net-config during boot, but rather on service restart. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Dan Kenigsberg has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 3: Code-Review+2 Please strike my former question, the answer lies in the commit message of http://gerrit.ovirt.org/17010 . /var/run/vdsm/nets_restored makes sure that a plain vdsmd restart would not cause network rollback. -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Dan Kenigsberg has submitted this change and it was merged. Change subject: unified pers: fix restoration when moving from ifcfg pers .. unified pers: fix restoration when moving from ifcfg pers Up until now we were only flushing the persistence of the configurator currently set up. This had the problem that when switching between configurators and persistence models, old persistence remainders could be left over. Bug-Url https://bugzilla.redhat.com/1064530 Signed-off-by: Antoni S. Puimedon Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Reviewed-on: http://gerrit.ovirt.org/25063 Tested-by: Douglas Schilling Landgraf Reviewed-by: Dan Kenigsberg --- M init/vdsmd_init_common.sh.in M vdsm/vdsm-restore-net-config 2 files changed, 26 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unified pers: fix restoration when moving from ifcfg pers
Yaniv Bronhaim has posted comments on this change. Change subject: unified pers: fix restoration when moving from ifcfg pers .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25063/4/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 233: tune_system \ Line 234: test_space \ Line 235: test_lo \ Line 236: unified_network_persistence_upgrade \ Line 237: restore_nets \ if this change of order is mandatory i'd add a comment that it will stay this way Line 238: upgrade_300_nets \ Line 239: " Line 240: ;; Line 241: --post-stop) -- To view, visit http://gerrit.ovirt.org/25063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I584b3b2ee953b508da23874c0adc79fe59e06856 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
