Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7: Code-Review+2

nice

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: v2v: Add tests for get_ova_info
..


v2v: Add tests for get_ova_info

Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/50158
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Tested-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M tests/v2vTests.py
1 file changed, 53 insertions(+), 20 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7: Verified+1

New tests pass in the CI.

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7:

Waiting for Francesco.

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

2015-12-13 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 6:

(3 comments)

Nice!

https://gerrit.ovirt.org/#/c/50158/6/tests/v2vTests.py
File tests/v2vTests.py:

Line 374: vm = v2v.get_ova_info(self.ovapath)
Line 375: self.check(vm['vmList'])
Line 376: 
Line 377: @contextmanager
Line 378: def init(self):
Nice!

Call this temporary_ovf_dir() and yield paths:

Caller can do:

with self.temporary_ovf_dir() as (ovapath, ovfpath):
...
Line 379: with namedTemporaryDir() as base:
Line 380: self.base = base
Line 381: self.ovfpath = os.path.join(base, 'testvm.ovf')
Line 382: self.ovapath = os.path.join(base, 'testvm.ova')


Line 378: def init(self):
Line 379: with namedTemporaryDir() as base:
Line 380: self.base = base
Line 381: self.ovfpath = os.path.join(base, 'testvm.ovf')
Line 382: self.ovapath = os.path.join(base, 'testvm.ova')
context manager that change the instance state is little ugly.
Line 383: ovf = read_ovf('test')
Line 384: 
Line 385: with open(self.ovfpath, 'w') as ovffile:
Line 386: ovffile.write(ovf)


Line 383: ovf = read_ovf('test')
Line 384: 
Line 385: with open(self.ovfpath, 'w') as ovffile:
Line 386: ovffile.write(ovf)
Line 387: yield
yield ovfpath, ovapath
Line 388: 
Line 389: def check(self, vm):
Line 390: self.assertEquals(vm['vmName'], 'First')
Line 391: self.assertEquals(vm['memSize'], 2048)


-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches