Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 6: * #1367839::Update tracker: OK * Set MODIFIED::bug 1367839#1367839::IGNORE, skipping for branch 'master' -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: Running virt-v2v with some sane environment .. v2v: Running virt-v2v with some sane environment Starting virt-v2v with (almost) empty environment no longer works and virt-v2v expects at least PATH to be set properly. Otherwise it will fail to find external tools. Still, even if virt-v2v was OK with it, having empty environment is not a good idea either. Since it depends on couple external tools they may also require some basic environment to work properly. Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Bug-Url: https://bugzilla.redhat.com/1367839 Backport-To: 4.0 Backport-To: 3.6 Signed-off-by: Tomáš Golembiovský Reviewed-on: https://gerrit.ovirt.org/62765 Continuous-Integration: Jenkins CI Reviewed-by: Shahar Havivi Reviewed-by: Francesco Romani --- M lib/vdsm/v2v.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 5: Ignore the rebases, please. It's the result of unsuccessful attempt to cherry-pick the change onto another branch. I have reverted it to state at PS3. -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 5: * #1367839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367839::OK, public bug * Check Product::#1367839::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 4: * #1367839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367839::OK, public bug * Check Product::#1367839::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Francesco Romani has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62765/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS3, Line 467: env['LIBGUESTFS_BACKEND'] = 'direct' > wasn't it always mandatory? Yes. Nothing has changed about it. -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Shahar Havivi has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62765/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS3, Line 467: env['LIBGUESTFS_BACKEND'] = 'direct' wasn't it always mandatory? -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 3: Verified+1 (1 comment) Verified. Now virt-v2v completes the import successfully. https://gerrit.ovirt.org/#/c/62765/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 466: # virt-v2v specific variables Line 467: env['LIBGUESTFS_BACKEND'] = 'direct' Line 468: if 'virtio_iso_path' in self._vminfo: Line 469: env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path'] Line 470: return env > spurious extra line. Nice, but unneeded. Removed. Line 471: Line 472: @contextmanager Line 473: def _password_file(self): Line 474: fd = os.open(self._passwd_file, os.O_WRONLY | os.O_CREAT, 0o600) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Tomas Golembiovsky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 3: * #1367839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367839::OK, public bug * Check Product::#1367839::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Francesco Romani has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62765/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 466: # virt-v2v specific variables Line 467: env['LIBGUESTFS_BACKEND'] = 'direct' Line 468: if 'virtio_iso_path' in self._vminfo: Line 469: env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path'] Line 470: spurious extra line. Nice, but unneeded. Line 471: return env Line 472: Line 473: @contextmanager Line 474: def _password_file(self): -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Jenkins CI has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 2: * #1367839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367839::OK, public bug * Check Product::#1367839::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
gerrit-hooks has posted comments on this change. Change subject: v2v: Running virt-v2v with some sane environment .. Patch Set 1: * #1367839::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367839::OK, public bug * Check Product::#1367839::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: v2v: Running virt-v2v with some sane environment
Tomas Golembiovsky has uploaded a new change for review.
Change subject: v2v: Running virt-v2v with some sane environment
..
v2v: Running virt-v2v with some sane environment
Starting virt-v2v with (almost) empty environment no longer works and
virt-v2v expect at least PATH to be set properly. Otherwise it will fail
to find external tools.
Still, even if virt-v2v was OK with it, having empty environment is not
a good idea either. Since it depends on couple external tools they may
also require some basic environment to work properly.
Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Bug-Url: https://bugzilla.redhat.com/1367839
Signed-off-by: Tomáš Golembiovský
---
M lib/vdsm/v2v.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/62765/1
diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index c6a9943..8b11cf3 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -460,9 +460,14 @@
return path.rsplit(os.sep, 3)[0]
def _environment(self):
-env = {'LIBGUESTFS_BACKEND': 'direct'}
+# Provide some sane environment
+env = os.environ.copy()
+
+# virt-v2v specific variables
+env['LIBGUESTFS_BACKEND'] = 'direct'
if 'virtio_iso_path' in self._vminfo:
env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path']
+
return env
@contextmanager
--
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
