Change in vdsm[master]: v2v: add format for disk conversion

2015-05-30 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-30 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: v2v: add format for disk conversion
..


v2v: add format for disk conversion

Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/40343
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/v2v.py
2 files changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-30 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 8:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-26 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-25 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-25 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-19 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-19 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 418: def _create_command(self):
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw')]
> should be added as optional? on @ExternalVmInfo:
Done
Line 423: cmd.extend(self._generate_disk_parameters())
Line 424: cmd.extend(['--password-file',
Line 425: self._passwd_file,
Line 426: '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-19 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 418: def _create_command(self):
Line 419: cmd = [_VIRT_V2V.cmd,
Line 420:'-ic', self._uri,
Line 421:'-o', 'vdsm',
Line 422:'-of', self._vminfo.get('format', 'raw')]
should be added as optional? on @ExternalVmInfo:
Line 423: cmd.extend(self._generate_disk_parameters())
Line 424: cmd.extend(['--password-file',
Line 425: self._passwd_file,
Line 426: '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-18 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-14 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-07 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-06 Thread mskrivan 
Michal Skrivanek has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/40343/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-28 11:28:15 +0300
Line 4: Commit: Shahar Havivi 
Line 5: CommitDate: 2015-05-03 14:42:11 +0300
Line 6: 
Line 7: v2v: add format for disk conversion
> Why this was not included in the original patch?
this is to add sparse/thin support
Line 8: 
Line 9: Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-28 11:28:15 +0300
Line 4: Commit: Shahar Havivi 
Line 5: CommitDate: 2015-05-03 14:42:11 +0300
Line 6: 
Line 7: v2v: add format for disk conversion
Why this was not included in the original patch?

Can you add some context about the format option? what are the values supported?
Line 8: 
Line 9: Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-05 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-03 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-03 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-03 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 416:(self._id, event))
Line 417: 
Line 418: def _create_command(self):
Line 419: fmt = self._vminfo.get('format', 'raw')
Line 420: cmd = [_VIRT_V2V.cmd, '-ic', self._uri, '-o', 'vdsm', '-of', 
fmt]
> The fmt parameter is not very useful, maybe:
Done
Line 421: cmd.extend(self._generate_disk_parameters())
Line 422: cmd.extend(['--password-file',
Line 423: self._passwd_file,
Line 424: '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-05-01 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40343/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 416:(self._id, event))
Line 417: 
Line 418: def _create_command(self):
Line 419: fmt = self._vminfo.get('format', 'raw')
Line 420: cmd = [_VIRT_V2V.cmd, '-ic', self._uri, '-o', 'vdsm', '-of', 
fmt]
The fmt parameter is not very useful, maybe:

cmd = [_VIRT_V2V.cmd, '-ic', self._uri,
  '-o', 'vdsm',
  '-of', self._vminfo.get('format', 'raw')]
Line 421: cmd.extend(self._generate_disk_parameters())
Line 422: cmd.extend(['--password-file',
Line 423: self._passwd_file,
Line 424: '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-04-28 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18261/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1491/ : 0

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-04-28 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

Build Started (2/2)

0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1491/

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-04-28 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

Build Started (1/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18261/

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-04-28 Thread shavivi 
Shahar Havivi has uploaded a new change for review.

Change subject: v2v: add format for disk conversion
..

v2v: add format for disk conversion

Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Signed-off-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/40343/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index ccc7e83..c3f92f4 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -416,7 +416,8 @@
(self._id, event))
 
 def _create_command(self):
-cmd = [_VIRT_V2V.cmd, '-ic', self._uri, '-o', 'vdsm', '-of', 'raw']
+fmt = self._vminfo.get('format', 'raw')
+cmd = [_VIRT_V2V.cmd, '-ic', self._uri, '-o', 'vdsm', '-of', fmt]
 cmd.extend(self._generate_disk_parameters())
 cmd.extend(['--password-file',
 self._passwd_file,


-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add format for disk conversion

2015-04-28 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: v2v: add format for disk conversion
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1da72771c9b02fa741cc84aa7159e862675fb577
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches