subject:"Change in vdsm\[master\]\: vdsm\: added documentation for downloadImage method"

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-18 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-18 Thread cshereme

Candace Sheremeta has uploaded a new change for review.

Change subject: vdsm: added documentation for downloadImage method
..

vdsm: added documentation for downloadImage method

Added documentation for downloadImage in both vdsClient (for command
line help) and the API. Gave a clearer description of what the
methodArgs parameter is and how it should be used.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128736
Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Signed-off-by: Candace Sheremeta 
---
M client/vdsClient.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/37934/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
old mode 100644
new mode 100755
index 07dbaa2..93cb0fe
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -2592,7 +2592,19 @@
 'downloadImage': (serv.downloadImage, (
 '[]',
 'Download an image from a remote endpoint using the specified',
-'methodArgs.'
+'methodArgs. methodArgs is a dictionary where the user can',
+'specify from where to download the image. Currently, the',
+'only ImageSharingMethod supported is http, so methodArgs should',
+'contain the url where the image to be downloaded is located, as',
+'well as any additional http headers to be used in the request,',
+'and the method http. All other parameters are GUIDs for the',
+'storage pool, storage domain, image, and (optionally) volume.',
+'For example: downloadImage({u\'methodArgs\': {u\'url\':',
+'u\'http://glance.ovirt.org:9292/v1/images/',
+'73786f49-62da-4abe-84af-cf43ab9f8dfa\',',
+'u\'headers\': {}, u\'method\': u\'http\'}, u\'storagepoolID\':',
+'u\'...\', u\'imageID\': u\'...\', u\'volumeID\': u\'...\',',
+'u\'storagedomainID\': u\'...\'})'
 )),
 'prepareImage': (serv.prepareImage, (
 '   []',
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 1d919e8..3d7e70a 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4658,7 +4658,20 @@
 # Download an image to a remote endpoint using the specified method
 # and methodArgs.
 #
-# @methodArgs:   Download method and map of arguments
+# @methodArgs:   Download method and map of arguments. Is a dictionary
+#where the user can specify from where to download the
+#image. Currently, the only ImageSharingMethod supported
+#is http, so methodArgs should contain the url where the
+#image to be downloaded is located, as well as any
+#additional http headers to be used in the request, and
+#the method http. All other parameters are GUIDs for the
+#storage pool, storage domain, image, and (optionally)
+#volume. For example: 
+#downloadImage({u'methodArgs': {u'url':u'http://glance.
+#
ovirt.org:9292/v1/images/73786f49-62da-4abe-84af-cf43ab9f8dfa',
+#u'headers': {}, u'method': u'http'}, u'storagepoolID':
+#u'...', u'imageID': u'...', u'volumeID': u'...',
+#u'storagedomainID': u'...'})
 #
 # @storagepoolID:The UUID of the Storage Pool associated with the Image
 #


-- 
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-18 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15819/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15018/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15989/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/795/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-19 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 1:

(5 comments)

Please show the new help message - looking at the code, I wonder if you tried 
to display it.

http://gerrit.ovirt.org/#/c/37934/1/client/vdsClient.py
File client/vdsClient.py:

Line 2591: )),
Line 2592: 'downloadImage': (serv.downloadImage, (
Line 2593: '[]',
Line 2594: 'Download an image from a remote endpoint using the 
specified',
Line 2595: 'methodArgs. methodArgs is a dictionary where the user 
can',
This should be one string, not lines separated by ",".

Python join together multiple strings (like in C) - see the other docs.
Line 2596: 'specify from where to download the image. Currently, 
the',
Line 2597: 'only ImageSharingMethod supported is http, so 
methodArgs should',
Line 2598: 'contain the url where the image to be downloaded is 
located, as',
Line 2599: 'well as any additional http headers to be used in the 
request,',


Line 2593: '[]',
Line 2594: 'Download an image from a remote endpoint using the 
specified',
Line 2595: 'methodArgs. methodArgs is a dictionary where the user 
can',
Line 2596: 'specify from where to download the image. Currently, 
the',
Line 2597: 'only ImageSharingMethod supported is http, so 
methodArgs should',
ImageSharingMethod? I think that "method" would be more clear as this the key 
name.
Line 2598: 'contain the url where the image to be downloaded is 
located, as',
Line 2599: 'well as any additional http headers to be used in the 
request,',
Line 2600: 'and the method http. All other parameters are GUIDs for 
the',
Line 2601: 'storage pool, storage domain, image, and (optionally) 
volume.',


Line 2596: 'specify from where to download the image. Currently, 
the',
Line 2597: 'only ImageSharingMethod supported is http, so 
methodArgs should',
Line 2598: 'contain the url where the image to be downloaded is 
located, as',
Line 2599: 'well as any additional http headers to be used in the 
request,',
Line 2600: 'and the method http. All other parameters are GUIDs for 
the',
GUIDs -> UUIDs
Line 2601: 'storage pool, storage domain, image, and (optionally) 
volume.',
Line 2602: 'For example: downloadImage({u\'methodArgs\': 
{u\'url\':',
Line 2603: 'u\'http://glance.ovirt.org:9292/v1/images/',
Line 2604: '73786f49-62da-4abe-84af-cf43ab9f8dfa\',',


Line 2597: 'only ImageSharingMethod supported is http, so 
methodArgs should',
Line 2598: 'contain the url where the image to be downloaded is 
located, as',
Line 2599: 'well as any additional http headers to be used in the 
request,',
Line 2600: 'and the method http. All other parameters are GUIDs for 
the',
Line 2601: 'storage pool, storage domain, image, and (optionally) 
volume.',
Should explain that if volume is not specified, the leaf volume is used.
Line 2602: 'For example: downloadImage({u\'methodArgs\': 
{u\'url\':',
Line 2603: 'u\'http://glance.ovirt.org:9292/v1/images/',
Line 2604: '73786f49-62da-4abe-84af-cf43ab9f8dfa\',',
Line 2605: 'u\'headers\': {}, u\'method\': u\'http\'}, 
u\'storagepoolID\':',


Line 2603: 'u\'http://glance.ovirt.org:9292/v1/images/',
Line 2604: '73786f49-62da-4abe-84af-cf43ab9f8dfa\',',
Line 2605: 'u\'headers\': {}, u\'method\': u\'http\'}, 
u\'storagepoolID\':',
Line 2606: 'u\'...\', u\'imageID\': u\'...\', u\'volumeID\': 
u\'...\',',
Line 2607: 'u\'storagedomainID\': u\'...\'})'
This is unreadable, and also not an example of this call.

Improving the documentation is important, but we pleased ignore the 
sub-standard documentation around and write proper documentation.

Should be:

Downloads an image from ...

Arguments

- methodArgs   Python dictionary literal specifying the download method.
The dictionary must be quoted (e.g, '{"method": 
"http", ...}')
Keys:
- methodcurrently only "http" is supported
- urlurl of the source image
- headers   dictionary of optional headers
  XXX is this optional arg? 
must specify that here
- sdUUID  storage domain uuid
   ...
   - volUUID optional volume UUID. If not specified the leaf volume is 
used.

Examples

  vdsClient -s 0 downloadImage \
  '{"method": "http", url: "http://example.com/myimage"

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-19 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/37934/1/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 4670: #downloadImage({u'methodArgs': 
{u'url':u'http://glance.
Line 4671: #
ovirt.org:9292/v1/images/73786f49-62da-4abe-84af-cf43ab9f8dfa',
Line 4672: #u'headers': {}, u'method': u'http'}, 
u'storagepoolID':
Line 4673: #u'...', u'imageID': u'...', u'volumeID': u'...',
Line 4674: #u'storagedomainID': u'...'})
This is duplicate of the documentation for vdsCli, with same issues.

The schema has a way to handle maps, we define new type and describe there the 
possible arguments. See @VolumeInfo.
Line 4675: #
Line 4676: # @storagepoolID:The UUID of the Storage Pool associated with 
the Image
Line 4677: #
Line 4678: # @storagedomainID:  The UUID of the Storage Domain associated with 
the Image


-- 
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-24 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-24 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16050/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15250/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16220/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1026/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-24 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/37934/2/client/vdsClient.py
File client/vdsClient.py:

Line 2592: 'downloadImage': (serv.downloadImage, (
Line 2593: '[]',
Line 2594: 'Download an image from a remote endpoint using the 
specified '
Line 2595: 'methodArgs.\n\n'
Line 2596: '\tArguments:\n'
It is not a good idea to use tabs - first, they may be interrupted differently 
by different tools, and second, they are usually displayed using 8 spaces, 
which is too much indentation for this kind of text. Last, they are harder to 
review, since we do not see how the text looks like in the source.

If you look at man pages and other online help, you can see that usually 2 
spaces are used for indentation.

This also minimize text width which plays better in the shell.
Line 2597: '\tmethodArgs:Python dictionary literal 
specifying the download method.\n'
Line 2598: '\t   The dictionary must be quoted 
(e.g, \'{"methodArgs": {"url": ...}\')\n'
Line 2599: '\t   Keys:\n'
Line 2600: '\t   - url: url of the source 
image\n'


Line 2603: '\tspUUID:The UUID of the Storage Pool 
associated with the Image\n'
Line 2604: '\tsdUUID:The UUID of the Storage Domain 
associated with the Image\n'
Line 2605: '\timgUUID:   The UUID of the Image\n'
Line 2606: '\tvolUUID:   The UUID of the Volume 
(optional)\n\n'
Line 2607: '\tExample:\n'
It is common to show examples after specifying the syntax. This section should 
be last.
Line 2608: '\tvdsClient -s 0 downloadImage \ \n'
Line 2609: '\t{"url": "http://example.com/myimage";, "headers": 
{"Foo": "Bar"}, "method": "http"} \ \n'
Line 2610: '\tspUUID sdUUID imgUUID\n\n'
Line 2611: '\tReturns:\n'


Line 2606: '\tvolUUID:   The UUID of the Volume 
(optional)\n\n'
Line 2607: '\tExample:\n'
Line 2608: '\tvdsClient -s 0 downloadImage \ \n'
Line 2609: '\t{"url": "http://example.com/myimage";, "headers": 
{"Foo": "Bar"}, "method": "http"} \ \n'
Line 2610: '\tspUUID sdUUID imgUUID\n\n'
When showing long command line examples that do not fit in one line, it is 
common to indent all but the first line, showing that the later lines are 
continuation of the first line:

vdsClient -s 0 downloadImage \
{"url": "http://example.com/myimage";, "headers": {"Foo": "Bar"}, 
"method": "http"} \
spUUID sdUUID imgUUID
Line 2611: '\tReturns:\n'
Line 2612: '\tA task UUID'
Line 2613: )),
Line 2614: 'prepareImage': (serv.prepareImage, (


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-27 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2:

The only ways to make the documentation formatted properly are to either add 
commas at the end of each line or to add tabs at the beginning of each line. 
All of the other documentation in this file uses commas. See 
http://imgur.com/hSGZ5Ab

If neither tabs or commas are used, it looks like http://imgur.com/d4iqtvI - 
this makes it hard to determine which lines are documentation for downloadImage 
and which lines are other methods

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-27 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16145/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15345/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16315/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1121/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-02-27 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 4: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16146/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15346/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16316/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1122/ : 
FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-01 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2:

Can you check and address my comments in version 2?
https://gerrit.ovirt.org/#/c/37934/2..4/client/vdsClient.py

You will have to reformat this so it fits in pep8 79
characters limit. This is another reason to use 2 spaces
indentation instead of tabs (8 spaces).

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/37934/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 4657: #
Line 4658: # Download an image to a remote endpoint using the specified method
Line 4659: # and methodArgs.
Line 4660: #
Line 4661: # @methodArgs:   An ImageSharingMethodArgs record specifying the 
download method.
This is only one line, but you can separate it to another patch, since it is 
not related to having better online help in vdsClient.
Line 4662: #
Line 4663: # @storagepoolID:The UUID of the Storage Pool associated with 
the Image
Line 4664: #
Line 4665: # @storagedomainID:  The UUID of the Storage Domain associated with 
the Image


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-03 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/37934/4/client/vdsClient.py
File client/vdsClient.py:

Line 2593: '[]',
Line 2594: 'Download an image from a remote endpoint using the 
specified '
Line 2595: 'methodArgs.\n\n'
Line 2596: '\tArguments:\n'
Line 2597: '\tmethodArgs:Python dictionary literal 
specifying the download method.\n'
Please format this using list of lines as you did in the previous version of 
the patch. I missed the code handling list of lines in the application. Sorry 
for the confusion.
Line 2598: '\t   The dictionary must be quoted 
(e.g, \'{"methodArgs": {"url": ...}\')\n'
Line 2599: '\t   Keys:\n'
Line 2600: '\t   - url: url of the source 
image\n'
Line 2601: '\t   - headers: dictionary of 
headers (optional)\n'


Line 2603: '\tspUUID:The UUID of the Storage Pool 
associated with the Image\n'
Line 2604: '\tsdUUID:The UUID of the Storage Domain 
associated with the Image\n'
Line 2605: '\timgUUID:   The UUID of the Image\n'
Line 2606: '\tvolUUID:   The UUID of the Volume 
(optional)\n\n'
Line 2607: '\tExample:\n'
I commented before that the examples section should come last - do you have any 
reason to keep it here, or you missed my comment?
Line 2608: '\tvdsClient -s 0 downloadImage \ \n'
Line 2609: '\t  {"url": "http://example.com/myimage";, "headers": 
{"Foo": "Bar"}, "method": "http"} \ \n'
Line 2610: '\t  spUUID sdUUID imgUUID\n\n'
Line 2611: '\tReturns:\n'


Line 2608: '\tvdsClient -s 0 downloadImage \ \n'
Line 2609: '\t  {"url": "http://example.com/myimage";, "headers": 
{"Foo": "Bar"}, "method": "http"} \ \n'
Line 2610: '\t  spUUID sdUUID imgUUID\n\n'
Line 2611: '\tReturns:\n'
Line 2612: '\tA task UUID'
To evaluate this code, we must see the result - I can checkout this patch, 
build and install this version, and run vdsClient, but it would be nice if you 
copy and paste the output here (as comment on the patch) instead.

Here is an example:
https://gerrit.ovirt.org/#/c/37494/
Check the Simone comment on Feb 9 3:49 PM.
Line 2613: )),
Line 2614: 'prepareImage': (serv.prepareImage, (
Line 2615: '   []',
Line 2616: 'Prepare an image, making the needed volumes available.'


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 5: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16311/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15511/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16481/ : FAILURE

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/37934/5/client/vdsClient.py
File client/vdsClient.py:

Line 2612: '
copy of console output:

downloadImage
[]
Download an image from a remote endpoint using the specified methodArgs.
Arguments:
methodArgs:Python dictionary literal specifying the download
   method. The dictionary must be quoted (e.g.
   '{"methodArgs": {"url": ...}')
   Keys:
   - url: url of the source image
   - headers: dictionary of headers (optional)
   - method:  currently only "http" is supported
spUUID:UUID of the Storage Pool associated with the Image
sdUUID:UUID of the Storage Domain associated with the Image
imgUUID:   UUID of the Image
volUUID:   UUID of the Volume (optional)
Returns: A task UUID
Example:
vdsClient -s 0 downloadImage \ 
  {"url": "http://example.com/myimage";, "headers": {"Foo": "Bar"}, \ 
  "method": "http"} spUUID sdUUID imgUUID


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6: Code-Review-1 Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16312/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15512/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16482/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-05 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-10 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/37934/6/client/vdsClient.py
File client/vdsClient.py:

Line 2595: 'methodArgs.',
Line 2596: 'Arguments:',
Line 2597: 'methodArgs:Python dictionary literal specifying 
the download',
Line 2598: '   method. The dictionary must be 
quoted (e.g.',
Line 2599: '   \'{"methodArgs": {"url": ...}\')',
There is no such key "methodArgs" - right?

Should be:

The dictionary must be quoted: '{"url": ...}'
Line 2600: '   Keys:',
Line 2601: '   - url: url of the source 
image',
Line 2602: '   - headers: dictionary of headers 
(optional)',
Line 2603: '   - method:  currently only "http" 
is supported',


Line 2608: 'Returns: A task UUID',
Line 2609: 'Example:',
Line 2610: 'vdsClient -s 0 downloadImage \ ',
Line 2611: '  {"url": "http://example.com/myimage";, "headers": 
{"Foo": "Bar"}, \ ',
Line 2612: '  "method": "http"} spUUID sdUUID imgUUID'
We should quote the dict as explained above:

'{"url": "http://example.com/myimage";, "headers": {"foo": "bar}, "method": 
"http"}' \

This example may be too long for pep8, so use:

"this wont fit in 80 characters so no comma here..."
"rest of line",

Python will merge both lines to one line.
Line 2613: )),
Line 2614: 'prepareImage': (serv.prepareImage, (
Line 2615: '   []',
Line 2616: 'Prepare an image, making the needed volumes available.'


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-10 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6:

Candance, it is a little bit unusual to review your own patches :-)

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-10 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6:

Candance, you should fix pep8 errors - check Jenkins output:
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16312/console

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16669/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16841/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7:

output can be seen at http://imgur.com/2qlkbfI

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7:

(1 comment)

When you show output, please use text format, not an image. The easier way is 
to paste here in a comment (adding leading whitespace to make it raw text), and 
it if is does not work for you, try http://fpaste.org/

https://gerrit.ovirt.org/#/c/37934/7/client/vdsClient.py
File client/vdsClient.py:

Line 2613: 'Returns: A task UUID',
Line 2614: 'Example:',
Line 2615: 'vdsClient -s 0 downloadImage \ ',
Line 2616: '  {"url": "http://example.com/myimage";, '
Line 2617: '"headers": {"Foo": "Bar"}, "method": "http"} \ ',
This is still not quoted.
Line 2618: '  spUUID sdUUID imgUUID'
Line 2619: )),
Line 2620: 'prepareImage': (serv.prepareImage, (
Line 2621: '   []',


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7:

(1 comment)

added quotes

https://gerrit.ovirt.org/#/c/37934/7/client/vdsClient.py
File client/vdsClient.py:

Line 2613: 'Returns: A task UUID',
Line 2614: 'Example:',
Line 2615: 'vdsClient -s 0 downloadImage \ ',
Line 2616: '  {"url": "http://example.com/myimage";, '
Line 2617: '"headers": {"Foo": "Bar"}, "method": "http"} \ ',
> This is still not quoted.
Done
Line 2618: '  spUUID sdUUID imgUUID'
Line 2619: )),
Line 2620: 'prepareImage': (serv.prepareImage, (
Line 2621: '   []',


-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8: Verified+1

screenshot of output: http://i.imgur.com/YPwyCCI.png

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16671/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16843/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread cshereme

Candace Sheremeta has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8:

Frankly, posting a clean image is better than text. It allows you to see 
*exactly* what I see, with no chance of font issues or anything else getting in 
the way. Thank you for your opinion, but I will continue to post screenshots. 
Other teams in oVirt use screenshots in gerrit as well.

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-13 Thread nsoffer

Nir Soffer has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8:

Screenshots are good for working on a gui, but when designing a text base 
interface, text is better.

For example, I can copy your text and make changes. This is much harder with a 
screenshot.

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-14 Thread amureini

Allon Mureinik has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 1:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37934
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 4:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 7:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 3:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 6:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 5:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-15 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 2:

* Update tracker::#1128736::OK
* Check Bug-Url::OK
* Check Public Bug::#1128736::OK, public bug
* Check Product::#1128736::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-18 Thread amureini

Allon Mureinik has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8:

Can we move forward with this?

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread danken

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: added documentation for downloadImage method
..


vdsm: added documentation for downloadImage method

Added documentation for downloadImage in vdsClient.
Gave a clearer description of what the methodArgs
parameter is and how it should be used. Formatted
documentation according to standard used in other
methods in vdsClient. See comments for copy of
output.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128736
Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Signed-off-by: Candace Sheremeta 
Reviewed-on: https://gerrit.ovirt.org/37934
Reviewed-by: Nir Soffer 
Reviewed-by: Allon Mureinik 
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClient.py
1 file changed, 25 insertions(+), 2 deletions(-)

Approvals:
  Candace Sheremeta: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread automation

automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

* Update tracker::#1128736::OK
* Check TR::#1128736::ERROR, 3.6.0 should not match .*

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread danken

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 8: Code-Review+2

raising score

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (1/9) -> 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/367/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (2/9) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4746/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (3/9) -> 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/366/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (4/9) -> 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/765/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (5/9) -> 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/768/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (6/9) -> 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/772/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (7/9) -> 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/738/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (8/9) -> 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/356/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Started (9/9) -> 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/361/

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: added documentation for downloadImage method

2015-03-20 Thread oVirt Jenkins CI Server

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: added documentation for downloadImage method
..


Patch Set 9:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/765/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/361/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4746/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/738/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/367/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/768/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/366/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/356/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/772/ : 
SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

56 matches

Mail list logo