Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 14: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: implement NUMA aware KSM policy .. vdsm: implement NUMA aware KSM policy Add monitored parameter ksm_merge_across_nodes to: 1. momIf.py class - append to status report 2. superVdsmServer file - enable writing to the kernel flag Update policy logic (a simple state machine) to 03-ksm.policy merge_across_nodes flag allowed to be changed only after unmerging all pages. This unmerge completion is tested on pages_shared flag == 0. Update policy parameter ksmMergeAcrossNodes to 00-defines.policy Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=840114 Signed-off-by: Dudi Maroshi Reviewed-on: https://gerrit.ovirt.org/40129 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák Tested-by: Martin Sivák Reviewed-by: Dan Kenigsberg --- M vdsm/mom.d/00-defines.policy M vdsm/mom.d/03-ksm.policy M vdsm/momIF.py M vdsm/supervdsmServer 4 files changed, 66 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, but someone else must approve Dudi Maroshi: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Martin Sivák has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 14: Code-Review+1 Verified+1 I saw it working and the policy file now looks much simpler so ACK from me. -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 13: Verified+1 Inserted modification to satisfy comments on patch set 8. Trying to consolidate debug lines created more obscure code. Since a debug massage may contain max 2 arguments. -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 9:
(7 comments)
https://gerrit.ovirt.org/#/c/40129/9/vdsm/mom.d/03-ksm.policy
File vdsm/mom.d/03-ksm.policy:
Line 23: (defvar ksm_free_percent 0.20)
Line 24:
Line 25: # KSM service can unmerged shared pages (ksm_run = 2)
Line 26: # When this happens the KSM is affectivley non responsive
Line 27: (defvar ksm_umerging_pages 0)
> There is probably a typo here. But I believe you do not need the variable a
Done.
A typo for sure.
Yet we do need a global/external variable that persist across function
invocations.
Line 28:
Line 29: ### Helper functions
Line 30: (def change_npages (delta)
Line 31: {
Line 34: (if (< newval ksm_npages_min) (set newval ksm_npages_min) 0)
Line 35: (Host.Control "ksm_pages_to_scan" newval)
Line 36: })
Line 37:
Line 38: (def enable_ksmMergeAcrossNodes()
> please use words separated by _ in names.. and this should probably be call
Done
Will rename the function to better reflect its responsibility.
Line 39: {
Line 40: (debug "entry: enable_ksmMergeAcrossNodes")
Line 41: (debug Host.ksm_run "=ksm_run")
Line 42: (debug Host.ksm_merge_across_nodes "=ksm_merge_across_nodes")
Line 36: })
Line 37:
Line 38: (def enable_ksmMergeAcrossNodes()
Line 39: {
Line 40: (debug "entry: enable_ksmMergeAcrossNodes")
> Please reduce the number of logging lines. (You can merge them to a single
The debug lines are my method of debugging the state machine.
The state machine status is progressing through invocations. Therefore we need
a progress feedback. Also we need feedback about the logic path the program
takes. Need advise as to override debug function with finer control switch
(turn on/off per flag).
The debug lines are also used as documentation.
Need advise to improve debugging technique.
Line 41: (debug Host.ksm_run "=ksm_run")
Line 42: (debug Host.ksm_merge_across_nodes "=ksm_merge_across_nodes")
Line 43: (debug ksmMergeAcrossNodes "=ksmMergeAcrossNodes")
Line 44: (if (!= Host.ksm_merge_across_nodes ksmMergeAcrossNodes){
Line 42: (debug Host.ksm_merge_across_nodes "=ksm_merge_across_nodes")
Line 43: (debug ksmMergeAcrossNodes "=ksmMergeAcrossNodes")
Line 44: (if (!= Host.ksm_merge_across_nodes ksmMergeAcrossNodes){
Line 45: (debug "ksm_merge_across_nodes policy change")
Line 46: (if (== Host.ksm_run 0){
> Please add comments explaining the intended behaviour (in detail!) so we do
Done
Line 47: (debug "ksm_run == 0 : Update ksm_merge_across_nodes")
Line 48: (Host.Control "ksm_merge_across_nodes" ksmMergeAcrossNodes)
Line 49: (debug "ksm_merge_across_nodes configured")}
Line 50: 6)
Line 42: (debug Host.ksm_merge_across_nodes "=ksm_merge_across_nodes")
Line 43: (debug ksmMergeAcrossNodes "=ksmMergeAcrossNodes")
Line 44: (if (!= Host.ksm_merge_across_nodes ksmMergeAcrossNodes){
Line 45: (debug "ksm_merge_across_nodes policy change")
Line 46: (if (== Host.ksm_run 0){
> Shouldn't we unmerge when the across node settings changes to 0 even though
Yes need to unmerge KSM when transition ksmMergeAcrossNode=0 to
ksmMergeAcrossNode=1 as well. Following the official documentation
https://www.kernel.org/doc/Documentation/vm/ksm.txt
Line 47: (debug "ksm_run == 0 : Update ksm_merge_across_nodes")
Line 48: (Host.Control "ksm_merge_across_nodes" ksmMergeAcrossNodes)
Line 49: (debug "ksm_merge_across_nodes configured")}
Line 50: 6)
Line 69: (debug "ksm_merge_across_nodes configured")}
Line 70: 9)
Line 71: } 10)
Line 72: (debug "exit: enable_ksmMergeAcrossNodes")
Line 73: })
> Please use the function as a function.. return the expected ksm_run mode he
Done, need some syntax instructions.
Line 74: ### Main Script
Line 75: # Methodology: Since running KSM does incur some overhead, try to run
it only
Line 76: # when necessary. If the amount of committed KSM shareable memory is
high or if
Line 77: # free memory is low, enable KSM to try to increase free memory.
Large memory
Line 80:
Line 81: (defvar ksm_pressure_threshold (* Host.mem_available ksm_free_percent))
Line 82: (defvar ksm_committed Host.ksm_shareable)
Line 83: (enable_ksmMergeAcrossNodes)
Line 84: (if (== ksm_umerging_pages 0)
> Why didn't you add this as another condition to the nested if and used the
As stated there is separation of concerns, applying_KSM_policy and
activating_KSM. Both share operational kernel flags. applying_KSM_policy
invocation is rare, may take few MoM cycles to complete. While activating_KSM
may override applying_KSM_policy run mode. Therefore we might wish to make
them exclusive to each other (no kernel flags overriding, simpler to
understand).
Line 85: (if (or (and (< (+ ksm_pressure_threshol
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Martin Sivák has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 9: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/40129/9/vdsm/mom.d/03-ksm.policy
File vdsm/mom.d/03-ksm.policy:
Line 27: ksm_umerging_pages
There is probably a typo here. But I believe you do not need the variable at
all.
Line 38: enable_ksmMergeAcrossNodes
please use words separated by _ in names.. and this should probably be called
process_ksm_merge_across_nodes_change or so...
Line 40: entry
Please reduce the number of logging lines. (You can merge them to a single
debug command if that helps you)
Line 46: 0
Shouldn't we unmerge when the across node settings changes to 0 even though the
last cycle did no KSM operation?
I think (but I might be wrong) that a check for the number of shared pages and
possibly ksmMergeAcrossNodes value is needed here.
Line 46:
Please add comments explaining the intended behaviour (in detail!) so we do not
have to analyse the code when a change is needed in the future.
Line 73: })
Please use the function as a function.. return the expected ksm_run mode here
and process it in the main section... (you can also drop ksm_umerging_pages
completely and set the ksm_merge_across_nodes value in the main section.
Line 84: ksm_umerging_pages
Why didn't you add this as another condition to the nested if and used the
return value from the new function in the true branch like this:
(setq ksm_run_mode (process_ksm_merge_across_nodes_change))
(if (== Host.ksm_pages_shared 0)
(Host.Control "ksm_merge_across_nodes" ksmMergeAcrossNodes)
0
)
(if (not enabled or no pressure or ksm_run_mode != 0)
(Host.Control "ksm_run" ksm_run_mode)
{ #else do normal ksm }
)
This way you would be able to drop all the calls to Host.Control from the
enable_ksmMergeAcrossNodes. The method would only detect if unmerge is
requested (so the name would change to detect_ksm_numa_mode or something..) set
the single variable and all would be applied at a single place.
--
To view, visit https://gerrit.ovirt.org/40129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dudi Maroshi
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Roy Golan has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40129/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 319: """
Line 320: rule = os.path.join(_UDEV_RULE_FILE_DIR,
_UDEV_RULE_FILE_PREFIX +
Line 321: "iommu_group_" + iommu_group +
_UDEV_RULE_FILE_EXT)
Line 322: self.log.debug("Removing rule %s", rule)
Line 323: os.remove(rule)
> Change resulting from rebase. Not my commit.
but it looks like you added it(same as above). I guess its not related to your
patch?
Line 324:
Line 325: @logDecorator
Line 326: def ksmTune(self, tuningParams):
Line 327: '''
--
To view, visit https://gerrit.ovirt.org/40129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dudi Maroshi
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 6: Verified+1
(2 comments)
https://gerrit.ovirt.org/#/c/40129/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 309: iommu_group)
Line 310: with open(ruleFile, "w") as rf:
Line 311: self.log.debug("Creating rule %s: %r", ruleFile, rule)
Line 312: rf.write(rule)
Line 313:
Change resulting from rebase. Not my commit.
Line 314: @logDecorator
Line 315: def rmAppropriateIommuGroup(self, iommu_group):
Line 316: """
Line 317: Remove udev rule in /etc/udev/rules.d/ created by
Line 319: """
Line 320: rule = os.path.join(_UDEV_RULE_FILE_DIR,
_UDEV_RULE_FILE_PREFIX +
Line 321: "iommu_group_" + iommu_group +
_UDEV_RULE_FILE_EXT)
Line 322: self.log.debug("Removing rule %s", rule)
Line 323: os.remove(rule)
Change resulting from rebase. Not my commit.
Line 324:
Line 325: @logDecorator
Line 326: def ksmTune(self, tuningParams):
Line 327: '''
--
To view, visit https://gerrit.ovirt.org/40129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dudi Maroshi
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Max Kovgan
Gerrit-Reviewer: Roy Golan
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Max Kovgan has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#840114::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Roy Golan has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: @Max is the -1 still relevant? -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18012/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1241/ : 0 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#840114::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1241/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18012/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Max Kovgan has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 2: Code-Review-1 please catch up with master so the tests are not breaking -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 2: Build Started (2/3) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1222/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18164/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1221/ : 0 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: Build Started (3/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18164/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#840114::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 2: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17993/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: Build Started (2/3) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1221/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dudi Maroshi Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17992/ -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: implement NUMA aware KSM policy .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: implement NUMA aware KSM policy
Dudi Maroshi has uploaded a new change for review.
Change subject: vdsm: implement NUMA aware KSM policy
..
vdsm: implement NUMA aware KSM policy
Add monitored parameter ksm_merge_across_nodes to:
1. momIf.py class - append to status report
2. superVdsmServer file - enable writing to the kernel flag
Update policy logic (a simple state machine) to 03-ksm.policy
merge_across_nodes flag allowed to be changed only after unmerging
all pages. This unmerge completion is tested on pages_shared flag == 0.
Update policy parameter ksmMergeAcrossNodes to 00-defines.policy
Change-Id: Iec607f9ef3284c1448bfc2831d125fc4d81b28d2
Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=840114
Signed-off-by: Dudi Maroshi
---
M vdsm/mom.d/00-defines.policy
M vdsm/mom.d/03-ksm.policy
M vdsm/momIF.py
M vdsm/supervdsmServer
4 files changed, 73 insertions(+), 53 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/40129/1
diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy
index faa6d90..718cf04 100644
--- a/vdsm/mom.d/00-defines.policy
+++ b/vdsm/mom.d/00-defines.policy
@@ -4,6 +4,7 @@
(defvar True 1)
# Define variables for configurable options here
+(defvar ksmMergeAcrossNodes 1)
(defvar ksmEnabled 1)
(defvar balloonEnabled 0)
(defvar cpuTuneEnabled 1)
diff --git a/vdsm/mom.d/03-ksm.policy b/vdsm/mom.d/03-ksm.policy
index 5a3b1bd..9706e5d 100644
--- a/vdsm/mom.d/03-ksm.policy
+++ b/vdsm/mom.d/03-ksm.policy
@@ -22,6 +22,10 @@
# KSM will be started to try and free up some memory.
(defvar ksm_free_percent 0.20)
+# KSM service can unmerged shared pages (ksm_run = 2)
+# When this happens the KSM is affectivley non responsive
+(defvar ksm_umerging_pages 0)
+
### Helper functions
(def change_npages (delta)
{
@@ -31,6 +35,43 @@
(Host.Control "ksm_pages_to_scan" newval)
})
+(def enable_ksmMergeAcrossNodes()
+{
+(debug "entry: enable_ksmMergeAcrossNodes")
+(debug Host.ksm_run "=ksm_run")
+(debug Host.ksm_merge_across_nodes "=ksm_merge_across_nodes")
+(debug ksmMergeAcrossNodes "=ksmMergeAcrossNodes")
+(if (!= Host.ksm_merge_across_nodes ksmMergeAcrossNodes){
+(debug "ksm_merge_across_nodes policy change")
+(if (== Host.ksm_run 0){
+(debug "ksm_run == 0 : Update ksm_merge_across_nodes")
+(Host.Control "ksm_merge_across_nodes" ksmMergeAcrossNodes)
+(debug "ksm_merge_across_nodes configured")}
+ 6)
+(if (== Host.ksm_run 1){
+(debug "ksm_run == 1 : unmerge KSM pages")
+(setq ksm_umerging_pages 1)
+(Host.Control "ksm_run" 2)
+(debug "ksm_run unmerge")}
+ 7)
+(if (== Host.ksm_run 2){
+(debug "ksm_run == 2 : if all pages unmerged, update
ksm_merge_across_nodes. Rest KSM")
+(Host.Control "ksm_run" 2)
+(if (== Host.ksm_pages_shared 0) {
+(debug "ksm_pages_shared == 0")
+(Host.Control "ksm_merge_across_nodes" ksmMergeAcrossNodes)
+(Host.Control "ksm_run" 0)
+(setq ksm_umerging_pages 0)
+}
+{ #else
+(debug "ksm_pages_shared != 0 : continue with unmerging")
+(setq ksm_umerging_pages 1)
+})
+(debug "ksm_merge_across_nodes configured")}
+ 9)
+ } 10)
+(debug "exit: enable_ksmMergeAcrossNodes")
+})
### Main Script
# Methodology: Since running KSM does incur some overhead, try to run it only
# when necessary. If the amount of committed KSM shareable memory is high or
if
@@ -40,16 +81,19 @@
(defvar ksm_pressure_threshold (* Host.mem_available ksm_free_percent))
(defvar ksm_committed Host.ksm_shareable)
-
-(if (or (and (< (+ ksm_pressure_threshold ksm_committed) Host.mem_available)
- (> (Host.StatAvg "mem_free") ksm_pressure_threshold)) (not
ksmEnabled))
-(Host.Control "ksm_run" 0)
-{# else
-(Host.Control "ksm_run" 1)
-(Host.Control "ksm_sleep_millisecs"
-(/ (* ksm_sleep_ms_baseline 16777216) Host.mem_available))
- (if (< (Host.StatAvg "mem_free") ksm_pressure_threshold)
-(change_npages ksm_pages_boost)
- (change_npages ksm_pages_decay))
-}
-)
+(enable_ksmMergeAcrossNodes)
+(if (== ksm_umerging_pages 0)
+(if (or (and (< (+ ksm_pressure_threshold ksm_committed)
Host.mem_available)
+ (> (Host.StatAvg "mem_free") ksm_pressure_threshold))
+ (not ksmEnabled))
+(Host.Control "ksm_run" 0)
+{# else
+(Host.Control "ksm_run" 1)
+(Host.Control "ksm_sleep_millisecs"
+(/ (* ksm_sleep_ms_baseline 16777216) Host.mem_available))
+ (if (< (Host.StatAvg "mem_free") ksm_pressure_thre
