Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-03 Thread mpolednik 
Martin Polednik has uploaded a new change for review.

Change subject: vdsm: refactor has_channel using etree
..

vdsm: refactor has_channel using etree

has_channel is a helper function currently located in vmxml,
which decides whether channel with given name exists in domain's
xml. This patch refactors this function to use dom and adds simple
test to verify it is acting as before.

Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Signed-off-by: Martin Polednik 
---
M tests/vmTests.py
M vdsm/virt/vmxml.py
2 files changed, 23 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/32402/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 6f01e4e..6dd0230 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -118,6 +118,7 @@
 return 1
 
 
+@expandPermutations
 class TestVm(TestCaseBase):
 
 PCI_ADDR = \
@@ -479,6 +480,22 @@
 domxml._appendAgentDevice(path, name)
 self.assertXML(domxml.dom, channelXML, 'devices/channel')
 
+@permutations([[True], [False]])
+def testHasChannel(self, expected):
+path = '/tmp/channel-socket'
+name = 'org.linux-kvm.port.0'
+domxml = vmxml.Domain(self.conf, self.log, caps.Architecture.X86_64)
+
+if expected:
+domxml._appendAgentDevice(path, name)
+
+ret = vmxml.has_channel(domxml.dom.toprettyxml(),
+'org.linux-kvm.port.0')
+if expected:
+self.assertTrue(ret)
+else:
+self.assertFalse(ret)
+
 def testInputXMLX86_64(self):
 expectedXMLs = [
 "",
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index f3d942b..4171c5c 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -22,6 +22,7 @@
 from operator import itemgetter
 import xml.dom
 import xml.dom.minidom
+import xml.etree.ElementTree as etree
 
 from vdsm import constants
 from vdsm import utils
@@ -30,14 +31,14 @@
 
 
 def has_channel(domXML, name):
-domObj = xml.dom.minidom.parseString(domXML)
-devices = domObj.getElementsByTagName('devices')
+domObj = etree.fromstring(domXML)
+devices = domObj.findall('devices')
 
 if len(devices) == 1:
-for chan in devices[0].getElementsByTagName('channel'):
-targets = chan.getElementsByTagName('target')
+for chan in devices[0].findall('channel'):
+targets = chan.findall('target')
 if len(targets) == 1:
-if targets[0].getAttribute('name') == name:
+if targets[0].attrib['name'] == name:
 return True
 
 return False


-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-03 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 1: Code-Review+1

(2 comments)

nice start. A few comments inside about test improvements.

http://gerrit.ovirt.org/#/c/32402/1/tests/vmTests.py
File tests/vmTests.py:

Line 481: self.assertXML(domxml.dom, channelXML, 'devices/channel')
Line 482: 
Line 483: @permutations([[True], [False]])
Line 484: def testHasChannel(self, expected):
Line 485: path = '/tmp/channel-socket'
better


  with namedTemporaryDir() as path:
...
Line 486: name = 'org.linux-kvm.port.0'
Line 487: domxml = vmxml.Domain(self.conf, self.log, 
caps.Architecture.X86_64)
Line 488: 
Line 489: if expected:


Line 493: 'org.linux-kvm.port.0')
Line 494: if expected:
Line 495: self.assertTrue(ret)
Line 496: else:
Line 497: self.assertFalse(ret)
I find

  self.assertEqual(ret, expected)

shorter and nicer
Line 498: 
Line 499: def testInputXMLX86_64(self):
Line 500: expectedXMLs = [
Line 501: "",


-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-03 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11289/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12231/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12078/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1609/ : 
There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/32402/1/tests/vmTests.py
File tests/vmTests.py:

Line 481: self.assertXML(domxml.dom, channelXML, 'devices/channel')
Line 482: 
Line 483: @permutations([[True], [False]])
Line 484: def testHasChannel(self, expected):
Line 485: path = '/tmp/channel-socket'
> better
I believe that is not required at all as the path is only mentioned in XML, no 
file is created (as long as domain XML's not started)
Line 486: name = 'org.linux-kvm.port.0'
Line 487: domxml = vmxml.Domain(self.conf, self.log, 
caps.Architecture.X86_64)
Line 488: 
Line 489: if expected:


Line 493: 'org.linux-kvm.port.0')
Line 494: if expected:
Line 495: self.assertTrue(ret)
Line 496: else:
Line 497: self.assertFalse(ret)
> I find
perfect, knew there had to be nicer way :)
Line 498: 
Line 499: def testInputXMLX86_64(self):
Line 500: expectedXMLs = [
Line 501: "",


-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11298/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12240/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12087/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1611/ : 
There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 2:

question: are we really interested in if len(devices) == 1 check? why would 
validity of the dom xml itself be done via has_channels function and not 
elsewhere?

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11303/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12246/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12092/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1614/ : 
There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11310/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12253/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12099/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1617/ : 
There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-04 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11314/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12257/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12103/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1621/ : 
There was an infra issue, please contact in...@ovirt.org

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-29 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 6:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11707/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12651/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1697/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12496/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-09-29 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-10-02 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-10-03 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-10-03 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: refactor has_channel using etree
..


vdsm: refactor has_channel using etree

has_channel is a helper function currently located in vmxml,
which decides whether channel with given name exists in domain's
xml. This patch refactors this function to use dom and adds simple
test to verify it is acting as before.

Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Signed-off-by: Martin Polednik 
Reviewed-on: http://gerrit.ovirt.org/32402
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M tests/vmXmlTests.py
M vdsm/virt/vmxml.py
2 files changed, 13 insertions(+), 5 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: refactor has_channel using etree

2014-10-03 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: refactor has_channel using etree
..


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/258/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5890/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4050/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/60/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/56/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/63/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/36/ : 
SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/32402
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie35718b7abc8cb2aea75afc1bd3b939bae68903f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches