Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 2:

* Update tracker::#1115556::OK
* Check Bug-Url::OK
* Check Public Bug::#1115556::OK, public bug
* Check Product::#1115556::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: removed optional markers for volUUID
..


vdsm: removed optional markers for volUUID

after examining the code, it's clear that the volUUID parameter
for vdsClient's prepareImage command is NOT optional. therefore,
I have removed any comments marking it as optional in the
vdsClient documentation and in vdsmapi-schema.json

Bug-Url: https://bugzilla.redhat.com/1115556
Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Signed-off-by: Candace Sheremeta 
Reviewed-on: https://gerrit.ovirt.org/38440
Tested-by: Allon Mureinik 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Adam Litke 
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/bindingxmlrpc.py
M vdsm/rpc/vdsmapi-schema.json
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-07-07 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 3:

* Update tracker::#1115556::OK
* Check TR::#1115556::ERROR, 3.6.0 should not match .*

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-05 Thread cshereme 
Candace Sheremeta has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-05 Thread cshereme 
Candace Sheremeta has uploaded a new change for review.

Change subject: vdsm: removed optional markers for volUUID
..

vdsm: removed optional markers for volUUID

after examining the code, it's clear that the volUUID parameter
for vdsClient's prepareImage command is NOT optional. therefore,
I have removed any comments marking it as optional in the
vdsClient documentation and in vdsmapi-schema.json

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115556
Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Signed-off-by: Candace Sheremeta 
---
M client/vdsClient.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/38440/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 07dbaa2..c8aa7cf 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -2595,7 +2595,7 @@
 'methodArgs.'
 )),
 'prepareImage': (serv.prepareImage, (
-'   []',
+'   ',
 'Prepare an image, making the needed volumes available.'
 )),
 'teardownImage': (serv.teardownImage, (
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 1d919e8..5b99aaa 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4715,13 +4715,13 @@
 #
 # @imageID:  The UUID of the Image
 #
-# @volumeID: #optional The UUID of the Volume (optional)
+# @volumeID: The UUID of the Volume
 #
 # Since: 4.15.0
 ##
 {'command': {'class': 'Image', 'name': 'prepare'},
  'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID',
-  'imageID': 'UUID', '*volumeID': 'UUID'}}
+  'imageID': 'UUID', 'volumeID': 'UUID'}}
 
 ##
 # @Image.teardown:


-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-05 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16314/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15514/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16484/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-11 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-14 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1: Code-Review-1

Nice catch, but this fix is partial. We have to fix the entire stack:

- vdsm/rpc/BindingXMLRPC.py
  defined as optional
- vdsm/API.py
  defined as optional

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Candace Sheremeta 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: removed optional markers for volUUID

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: vdsm: removed optional markers for volUUID
..


Patch Set 1:

* Update tracker::#1115556::OK
* Check Bug-Url::OK
* Check Public Bug::#1115556::OK, public bug
* Check Product::#1115556::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches