Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread eedri 
Eyal Edri has posted comments on this change.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..


Patch Set 1: Verified+1 Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..


vdsm-tool: fix qemu-sanlock configuration

Fixing the logic about qemu-sanlock configuration: if sanlock is
enabled then qemu-sanlock.conf needs to be updated.

Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Signed-off-by: Federico Simoncelli 
Reviewed-on: http://gerrit.ovirt.org/19094
Reviewed-by: Eyal Edri 
Tested-by: Eyal Edri 
Reviewed-by: Allon Mureinik 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eyal Edri: Verified; Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..


Patch Set 1: Code-Review+2

We need to take the other part of 
http://gerrit.ovirt.org/#/c/19005/3/lib/vdsm/tool/libvirt_configure.sh.in too. 
(the one regarding selinux)

-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4352/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3455/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4271/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-tool: fix qemu-sanlock configuration

2013-09-10 Thread fsimonce 
Federico Simoncelli has uploaded a new change for review.

Change subject: vdsm-tool: fix qemu-sanlock configuration
..

vdsm-tool: fix qemu-sanlock configuration

Fixing the logic about qemu-sanlock configuration: if sanlock is
enabled then qemu-sanlock.conf needs to be updated.

Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Signed-off-by: Federico Simoncelli 
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/19094/1

diff --git a/lib/vdsm/tool/libvirt_configure.sh.in 
b/lib/vdsm/tool/libvirt_configure.sh.in
index c4f56a9..2ab5334 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -30,7 +30,7 @@
 QCONF="@sysconfdir@/libvirt/qemu.conf"
 LDCONF="@sysconfdir@/sysconfig/libvirtd"
 QLCONF="@sysconfdir@/libvirt/qemu-sanlock.conf"
-[ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ] && QLCONF="/dev/null"
+[ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ] || QLCONF="/dev/null"
 
 # trigger for reconfiguration
 FORCE_RECONFIGURE="@VDSMLIBDIR@/reconfigure"


-- 
To view, visit http://gerrit.ovirt.org/19094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d2a6b05fb8fbf0ef2e9599fd1a740a7091680d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches