Change in vdsm[master]: vdsm-tool: remove register verb
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has abandoned this change. Change subject: vdsm-tool: remove register verb .. Abandoned The verb will remain. -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 2: Code-Review-1 pending decision. -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Fabian Deutsch has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-tool: remove register verb
..
vdsm-tool: remove register verb
git://gerrit.ovirt.org/ovirt-register provides the
generic registration which should deprecate the vdsm-tool
register as the registration must be triggered without
VDSM.
Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M debian/vdsm-python.install
M lib/vdsm/tool/Makefile.am
D lib/vdsm/tool/register.py
M vdsm.spec.in
4 files changed, 0 insertions(+), 553 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/43921/1
diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index d9402c3..b74d0e9 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -37,7 +37,6 @@
./usr/lib/python2.7/dist-packages/vdsm/tool/configurator.py
./usr/lib/python2.7/dist-packages/vdsm/tool/nwfilter.py
./usr/lib/python2.7/dist-packages/vdsm/tool/passwd.py
-./usr/lib/python2.7/dist-packages/vdsm/tool/register.py
./usr/lib/python2.7/dist-packages/vdsm/tool/restore_nets.py
./usr/lib/python2.7/dist-packages/vdsm/tool/service.py
./usr/lib/python2.7/dist-packages/vdsm/tool/transient.py
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index c8979ca..e4afc98 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -37,7 +37,6 @@
nwfilter.py \
configfile.py \
configurator.py \
- register.py \
restore_nets.py \
service.py \
transient.py \
diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py
deleted file mode 100644
index 31121c0..000
--- a/lib/vdsm/tool/register.py
+++ /dev/null
@@ -1,550 +0,0 @@
-# Copyright (C) 2012-2015 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; version 2 of the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
-# MA 02110-1301, USA. A copy of the GNU General Public License is
-# also available at http://www.gnu.org/copyleft/gpl.html.
-from __future__ import absolute_import
-import argparse
-import getpass
-import hashlib
-import logging
-import os
-import pwd
-import socket
-import ssl
-import sys
-import tempfile
-
-import requests
-import selinux
-
-from . import expose
-from .. import utils
-
-from vdsm.utils import getHostUUID, tobool
-
-
-class Register(object):
-
-def __init__(self, engine_fqdn, engine_https_port=None,
- fingerprint=None, ssh_port=None,
- ssh_user=None, check_fqdn=True,
- vdsm_port=None, node_fqdn=None,
- node_name=None):
-
-Attributes:
-
-engine_fqdn - Engine FQDN
-engine_https_port - Engine http port
-fingeprint- Fingerprint to be validated
-ssh_user - SSH user that will establish the connection
-from Engine
-ssh_port - Port of ssh daemon is running
-check_fqdn- Validate Engine FQDN against CA (True or False)
-Default is TRUE
-vdsm_port - VDSM listen port
-node_fqdn - Specify node FQDN
-node_name - Specify node name
-
-self.logger = self._set_logger()
-self.logger.debug(===)
-self.logger.debug(Registering the node)
-self.logger.debug(===)
-self.logger.debug(Received the following attributes:)
-
-self.engine_fqdn = engine_fqdn
-self.logger.debug(Engine FQDN: {fqdn}.format(fqdn=self.engine_fqdn))
-
-self.engine_url = https://{e}.format(e=engine_fqdn)
-if engine_https_port is None:
-self.engine_port = 443
-else:
-self.engine_port = engine_https_port
-self.engine_url = https://{e}:{p}.format(e=self.engine_fqdn,
- p=self.engine_port)
-
-self.logger.debug(Engine URL: {url}.format(url=self.engine_url))
-self.logger.debug(Engine https port: {hp}.format(
- hp=self.engine_port))
-
-if check_fqdn is None:
-self.check_fqdn = True
-else:
-self.check_fqdn = tobool(check_fqdn)
-self.logger.debug(Check FQDN:
Change in vdsm[master]: vdsm-tool: remove register verb
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: remove register verb
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-tool: remove register verb .. Patch Set 1: Verified+1 I could build vdsm and generate rpm without register.py -- To view, visit https://gerrit.ovirt.org/43921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c2e06b42bc8211ce900316498f28c9214044bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
